upstream/mercurial-mirror Files · tests/test-journal-exists.t

tryimportone: use dirstateguard instead of beginparentchange/endparentchange...

tryimportone: use dirstateguard instead of beginparentchange/endparentchange To fix the issue that the recent (in memory) dirstate isn't visible to external process (e.g. "precommit" hook), a subsequent patch makes "localrepository.commit()" invoke "dirstate.write()" in it. This change will make "beginparentchange()" and "endparentchange()" on dirstate in "cmdutil.tryimportone()" meaningless, because: - "dirstate.write()" writes changed data into ".hg/dirstate", but - aborting between "beginparentchange()" and "endparentchange()" doesn't cause any restoring ".hg/dirstate" it just discards changes in memory. This patch uses "dirstateguard" instead of "beginparentchange()" and "endparentchange()" in "cmdutil.tryimportone()" to restore ".hg/dirstate" during a failure even if "dirstate.write()" is executed before a failure. This patch uses "lockmod.release(dsguard)" instead of "dsguard.release()", because processing may be aborted before assignment to "dsguard" , and the "if dsguard" examination for safety is redundant.

Johan Bjork - - Load All Authors

File last commit:

r21274:3b4c7569 default


                r24995:0579b0c2

default

Download file

             test-journal-exists.t
        
                    37 lines
            
             | 805 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-journal-exists.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init

        $ echo a > a

        $ hg ci -Am0

        adding a

        $ hg -q clone . foo

        $ touch .hg/store/journal

        $ echo foo > a

        $ hg ci -Am0

        abort: abandoned transaction found!

        (run 'hg recover' to clean up transaction)

        [255]

        $ hg recover

        rolling back interrupted transaction

        checking changesets

        checking manifests

        crosschecking files in changesets and manifests

        checking files

        1 files, 1 changesets, 1 total revisions

      Check that zero-size journals are correctly aborted:

      #if unix-permissions no-root

        $ hg bundle -qa repo.hg

        $ chmod -w foo/.hg/store/00changelog.i

        $ hg -R foo unbundle repo.hg

        adding changesets

        abort: Permission denied: $TESTTMP/foo/.hg/store/.00changelog.i-* (glob)

        [255]

        $ if test -f foo/.hg/store/journal; then echo 'journal exists :-('; fi

      #endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init
				$ echo a > a
				$ hg ci -Am0
				adding a

				$ hg -q clone . foo

				$ touch .hg/store/journal

				$ echo foo > a
				$ hg ci -Am0
				abort: abandoned transaction found!
				(run 'hg recover' to clean up transaction)
				[255]

				$ hg recover
				rolling back interrupted transaction
				checking changesets
				checking manifests
				crosschecking files in changesets and manifests
				checking files
				1 files, 1 changesets, 1 total revisions

				Check that zero-size journals are correctly aborted:

				#if unix-permissions no-root
				$ hg bundle -qa repo.hg
				$ chmod -w foo/.hg/store/00changelog.i

				$ hg -R foo unbundle repo.hg
				adding changesets
				abort: Permission denied: $TESTTMP/foo/.hg/store/.00changelog.i-* (glob)
				[255]

				$ if test -f foo/.hg/store/journal; then echo 'journal exists :-('; fi
				#endif