upstream/mercurial-mirror Files · tests/test-committer.t

wireprotov2: implement commands as a generator of objects...

wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

timeless - - Load All Authors

File last commit:

r28962:ad2cd2ef default


                r39595:07b58266

default

Download file

             test-committer.t
        
                    110 lines
            
             | 2.5 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-committer.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ unset HGUSER

        $ EMAIL="My Name <myname@example.com>"

        $ export EMAIL

        $ hg init test

        $ cd test

        $ touch asdf

        $ hg add asdf

        $ hg commit -m commit-1

        $ hg tip

        changeset:   0:53f268a58230

        tag:         tip

        user:        My Name <myname@example.com>

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     commit-1

        $ unset EMAIL

        $ echo 1234 > asdf

        $ hg commit -u "foo@bar.com" -m commit-1

        $ hg tip

        changeset:   1:3871b2a9e9bf

        tag:         tip

        user:        foo@bar.com

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     commit-1

        $ echo "[ui]" >> .hg/hgrc

        $ echo "username = foobar <foo@bar.com>" >> .hg/hgrc

        $ echo 12 > asdf

        $ hg commit -m commit-1

        $ hg tip

        changeset:   2:8eeac6695c1c

        tag:         tip

        user:        foobar <foo@bar.com>

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     commit-1

        $ echo 1 > asdf

        $ hg commit -u "foo@bar.com" -m commit-1

        $ hg tip

        changeset:   3:957606a725e4

        tag:         tip

        user:        foo@bar.com

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     commit-1

        $ echo 123 > asdf

        $ echo "[ui]" > .hg/hgrc

        $ echo "username = " >> .hg/hgrc

        $ hg commit -m commit-1

        abort: no username supplied

        (use 'hg config --edit' to set your username)

        [255]

      # test alternate config var

        $ echo 1234 > asdf

        $ echo "[ui]" > .hg/hgrc

        $ echo "user = Foo Bar II <foo2@bar.com>" >> .hg/hgrc

        $ hg commit -m commit-1

        $ hg tip

        changeset:   4:6f24bfb4c617

        tag:         tip

        user:        Foo Bar II <foo2@bar.com>

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     commit-1

      # test prompt username

        $ cat > .hg/hgrc <<EOF

        > [ui]

        > askusername = True

        > EOF

        $ echo 12345 > asdf

        $ hg commit --config ui.interactive=False -m ask

        enter a commit username: 

        no username found, using '[^']*' instead (re)

        $ hg rollback -q

        $ hg commit --config ui.interactive=True -m ask <<EOF

        > Asked User <ask@example.com>

        > EOF

        enter a commit username: Asked User <ask@example.com>

        $ hg tip

        changeset:   5:84c91d963b70

        tag:         tip

        user:        Asked User <ask@example.com>

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     ask

      # test no .hg/hgrc (uses generated non-interactive username)

        $ echo space > asdf

        $ rm .hg/hgrc

        $ hg commit -m commit-1 2>&1

        no username found, using '[^']*' instead (re)

        $ echo space2 > asdf

        $ hg commit -u ' ' -m commit-1

        transaction abort!

        rollback completed

        abort: empty username!

        [255]

      # don't add tests here, previous test is unstable

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ unset HGUSER
				$ EMAIL="My Name <myname@example.com>"
				$ export EMAIL

				$ hg init test
				$ cd test
				$ touch asdf
				$ hg add asdf
				$ hg commit -m commit-1
				$ hg tip
				changeset: 0:53f268a58230
				tag: tip
				user: My Name <myname@example.com>
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: commit-1


				$ unset EMAIL
				$ echo 1234 > asdf
				$ hg commit -u "foo@bar.com" -m commit-1
				$ hg tip
				changeset: 1:3871b2a9e9bf
				tag: tip
				user: foo@bar.com
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: commit-1

				$ echo "[ui]" >> .hg/hgrc
				$ echo "username = foobar <foo@bar.com>" >> .hg/hgrc
				$ echo 12 > asdf
				$ hg commit -m commit-1
				$ hg tip
				changeset: 2:8eeac6695c1c
				tag: tip
				user: foobar <foo@bar.com>
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: commit-1

				$ echo 1 > asdf
				$ hg commit -u "foo@bar.com" -m commit-1
				$ hg tip
				changeset: 3:957606a725e4
				tag: tip
				user: foo@bar.com
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: commit-1

				$ echo 123 > asdf
				$ echo "[ui]" > .hg/hgrc
				$ echo "username = " >> .hg/hgrc
				$ hg commit -m commit-1
				abort: no username supplied
				(use 'hg config --edit' to set your username)
				[255]

				# test alternate config var

				$ echo 1234 > asdf
				$ echo "[ui]" > .hg/hgrc
				$ echo "user = Foo Bar II <foo2@bar.com>" >> .hg/hgrc
				$ hg commit -m commit-1
				$ hg tip
				changeset: 4:6f24bfb4c617
				tag: tip
				user: Foo Bar II <foo2@bar.com>
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: commit-1

				# test prompt username

				$ cat > .hg/hgrc <<EOF
				> [ui]
				> askusername = True
				> EOF

				$ echo 12345 > asdf
				$ hg commit --config ui.interactive=False -m ask
				enter a commit username:
				no username found, using '[^']*' instead (re)
				$ hg rollback -q

				$ hg commit --config ui.interactive=True -m ask <<EOF
				> Asked User <ask@example.com>
				> EOF
				enter a commit username: Asked User <ask@example.com>
				$ hg tip
				changeset: 5:84c91d963b70
				tag: tip
				user: Asked User <ask@example.com>
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: ask


				# test no .hg/hgrc (uses generated non-interactive username)

				$ echo space > asdf
				$ rm .hg/hgrc
				$ hg commit -m commit-1 2>&1
				no username found, using '[^']*' instead (re)

				$ echo space2 > asdf
				$ hg commit -u ' ' -m commit-1
				transaction abort!
				rollback completed
				abort: empty username!
				[255]

				# don't add tests here, previous test is unstable

				$ cd ..