upstream/mercurial-mirror Files · tests/test-url-download.t

wireprotov2: implement commands as a generator of objects...

wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

Boris Feld - - Load All Authors

File last commit:

r35748:05d41579 default


                r39595:07b58266

default

Download file

             test-url-download.t
        
                    68 lines
            
             | 1.9 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-url-download.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require serve

        $ hg init server

        $ hg serve -R server -p $HGPORT -d --pid-file=hg1.pid -E ../error.log

        $ cat hg1.pid >> $DAEMON_PIDS

      Check basic fetching

        $ hg debugdownload "http://localhost:$HGPORT/?cmd=lookup&key=tip"

        1 0000000000000000000000000000000000000000

        $ hg debugdownload  -o null.txt "http://localhost:$HGPORT/?cmd=lookup&key=null"

        $ cat null.txt

        1 0000000000000000000000000000000000000000

      Check the request is made from the usual Mercurial logic

      (rev details, give different content if the request has a Mercurial user agent)

        $ get-with-headers.py --headeronly "localhost:$HGPORT" "rev/tip" content-type

        200 Script output follows

        content-type: text/html; charset=ascii

        $ hg debugdownload "http://localhost:$HGPORT/rev/tip"

        # HG changeset patch

        # User 

        # Date 0 0

        # Node ID 0000000000000000000000000000000000000000

      Check other kind of compatible url

        $ hg debugdownload ./null.txt

        1 0000000000000000000000000000000000000000

      Test largefile URL

      ------------------

        $ cat << EOF >> $HGRCPATH

        > [extensions]

        > largefiles=

        > EOF

        $ killdaemons.py

        $ rm -f error.log hg1.pid

        $ hg serve -R server -p $HGPORT -d --pid-file=hg1.pid -E error.log

        $ cat hg1.pid >> $DAEMON_PIDS

        $ hg -R server debuglfput null.txt

        a57b57b39ee4dc3da1e03526596007f480ecdbe8

        $ hg --traceback debugdownload "largefile://a57b57b39ee4dc3da1e03526596007f480ecdbe8" --config paths.default=http://localhost:$HGPORT/

        1 0000000000000000000000000000000000000000

      from within a repository

        $ hg clone http://localhost:$HGPORT/ client

        no changes found

        updating to branch default

        0 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cd client

        $ hg path

        default = http://localhost:$HGPORT/

        $ hg debugdownload "largefile://a57b57b39ee4dc3da1e03526596007f480ecdbe8"

        1 0000000000000000000000000000000000000000

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require serve

				$ hg init server
				$ hg serve -R server -p $HGPORT -d --pid-file=hg1.pid -E ../error.log
				$ cat hg1.pid >> $DAEMON_PIDS

				Check basic fetching

				$ hg debugdownload "http://localhost:$HGPORT/?cmd=lookup&key=tip"
				1 0000000000000000000000000000000000000000
				$ hg debugdownload -o null.txt "http://localhost:$HGPORT/?cmd=lookup&key=null"
				$ cat null.txt
				1 0000000000000000000000000000000000000000

				Check the request is made from the usual Mercurial logic
				(rev details, give different content if the request has a Mercurial user agent)

				$ get-with-headers.py --headeronly "localhost:$HGPORT" "rev/tip" content-type
				200 Script output follows
				content-type: text/html; charset=ascii
				$ hg debugdownload "http://localhost:$HGPORT/rev/tip"

				# HG changeset patch
				# User
				# Date 0 0
				# Node ID 0000000000000000000000000000000000000000





				Check other kind of compatible url

				$ hg debugdownload ./null.txt
				1 0000000000000000000000000000000000000000

				Test largefile URL
				------------------

				$ cat << EOF >> $HGRCPATH
				> [extensions]
				> largefiles=
				> EOF

				$ killdaemons.py
				$ rm -f error.log hg1.pid
				$ hg serve -R server -p $HGPORT -d --pid-file=hg1.pid -E error.log
				$ cat hg1.pid >> $DAEMON_PIDS

				$ hg -R server debuglfput null.txt
				a57b57b39ee4dc3da1e03526596007f480ecdbe8

				$ hg --traceback debugdownload "largefile://a57b57b39ee4dc3da1e03526596007f480ecdbe8" --config paths.default=http://localhost:$HGPORT/
				1 0000000000000000000000000000000000000000

				from within a repository

				$ hg clone http://localhost:$HGPORT/ client
				no changes found
				updating to branch default
				0 files updated, 0 files merged, 0 files removed, 0 files unresolved

				$ cd client
				$ hg path
				default = http://localhost:$HGPORT/
				$ hg debugdownload "largefile://a57b57b39ee4dc3da1e03526596007f480ecdbe8"
				1 0000000000000000000000000000000000000000
				$ cd ..