upstream/mercurial-mirror Files · rust/hg-core/src/re2/mod.rs

packaging: integrate signing into run_wix_packaging()...

packaging: integrate signing into run_wix_packaging() Previously, signing was implemented via a separate function which called build_installer() and then called signing functionality. In this model, in order to implement an alternative build mechanism, we would have to invent a new variant to handle signing as well. This commit merges the signing logic into the function invoking wix. If we pass an argument holding metadata about how to sign, we sign hg.exe and the installer. This means all we have to do is pass in signing info and the signing just works. A slight change here is that signing of hg.exe happens in the staging directory as opposed to before the staging directory is populated. I don't think this matters. Differential Revision: https://phab.mercurial-scm.org/D8475

Raphaël Gomès - - Load All Authors

File last commit:

r44786:d8d4fa9a default


                r45258:08423196

default

Download file

             mod.rs
        
                    21 lines
            
             | 1.0 KiB
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / re2 / mod.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      /// re2 module

      ///

      /// The Python implementation of Mercurial uses the Re2 regex engine when

      /// possible and if the bindings are installed, falling back to Python's `re`

      /// in case of unsupported syntax (Re2 is a non-backtracking engine).

      ///

      /// Using it from Rust is not ideal. We need C++ bindings, a C++ compiler,

      /// Re2 needs to be installed... why not just use the `regex` crate?

      ///

      /// Using Re2 from the Rust implementation guarantees backwards compatibility.

      /// We know it will work out of the box without needing to figure out the

      /// subtle differences in syntax. For example, `regex` currently does not

      /// support empty alternations (regex like `a||b`) which happens more often

      /// than we might think. Old benchmarks also showed worse performance from

      /// regex than with Re2, but the methodology and results were lost, so take

      /// this with a grain of salt.

      ///

      /// The idea is to use Re2 for now as a temporary phase and then investigate

      /// how much work would be needed to use `regex`.

      mod re2;

      pub use re2::Re2;

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				/// re2 module
				///
				/// The Python implementation of Mercurial uses the Re2 regex engine when
				/// possible and if the bindings are installed, falling back to Python's `re`
				/// in case of unsupported syntax (Re2 is a non-backtracking engine).
				///
				/// Using it from Rust is not ideal. We need C++ bindings, a C++ compiler,
				/// Re2 needs to be installed... why not just use the `regex` crate?
				///
				/// Using Re2 from the Rust implementation guarantees backwards compatibility.
				/// We know it will work out of the box without needing to figure out the
				/// subtle differences in syntax. For example, `regex` currently does not
				/// support empty alternations (regex like `a\|\|b`) which happens more often
				/// than we might think. Old benchmarks also showed worse performance from
				/// regex than with Re2, but the methodology and results were lost, so take
				/// this with a grain of salt.
				///
				/// The idea is to use Re2 for now as a temporary phase and then investigate
				/// how much work would be needed to use `regex`.
				mod re2;
				pub use re2::Re2;