##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

subrepo: handle 'C:' style paths on the command line (issue5770)...
subrepo: handle 'C:' style paths on the command line (issue5770) If you think 'C:' and 'C:\' are equivalent paths, see the inline comment before proceeding. The problem here was that several commands that take a URL argument (incoming, outgoing, pull, and push) will use that value to set 'repo._subtoppath' on the repository object after command specific manipulation of it, but before converting it to an absolute path. When an operation is performed on a relative subrepo, subrepo._abssource() will posixpath.join() this value with the relative subrepo path. That adds a '/' after the drive letter, changing how it is evaluated by abspath()/realpath() in vfsmod.vfs(..., realpath=True) as the subrepo is instantiated. I initially tried sanitizing the path in url.localpath(), because url.isabs() only checks that it starts with a drive letter. By the sample behavior, this is clearly not an absolute path. (Though the comment in isabs() is weasely- this style path can't be joined either.) But not everything funnels through there, and it required explicitly calling localpath() in hg.parseurl() and assigning to url.path to fix. But then tests failed with urls like 'a#0'. Next up was sanitizing the path in the url constructor. That caused doctest failures, because there are drive letter tests, so those got expanded in system specific ways. Yuya correctly pointed out that util.url is a parser, and shouldn't be substituting the path too. Rather than fixing every command call site, just convert it in the common subrepo location. I don't see any sanitizing on the path config options, so I fixed those too. Note that while the behavior is fixed here, there are still places where 'comparing with C:' gets printed out, and that's not great for debugging purposes. (Specifically I saw it in `hg incoming -B C:`, without subrepos.) While clone will write out an absolute default path, I wonder what would happen if a user edited that path to be 'C:'. (I don't think supporting relative paths in .hgrc is a sane thing to do, but while we're poking holes in things...) Since this is such an oddball case, it still leaks through in places, and there seems to be a lot of duplicate url parsing, maybe the url parsing should be moved to dispatch, and provide the command with a url object? Then we could convert this to an absolute path once, and not have to worry about it in the rest of the code. I also checked '--cwd C:' on the command line, and it was previously working because os.chdir() will DTRT. Finally, one other note from the url.localpath() experimenting. I don't see any cases where 'self._hostport' can hold a drive letter. So I'm wondering if that is wrong/old code.
Matt Harbison -
r35795:0c0689a7 default
Show More
Name Size Modified Last Commit Author
/ contrib / win32
ReadMe.html Loading ...
buildlocal.bat Loading ...
hg.bat Loading ...
hgwebdir_wsgi.py Loading ...
mercurial.ico Loading ...
mercurial.ini Loading ...
mercurial.iss Loading ...
postinstall.txt Loading ...
win32-build.txt Loading ...


<html>
<head>
<title>Mercurial for Windows</title>
<meta http-equiv="Content-Type" content="text/html;charset=utf-8" >
<style type="text/css">

</style>
</head>

<body>

Mercurial for Windows



Welcome to Mercurial for Windows!




Mercurial is a command-line application. You must run it from
the Windows command prompt (or if you're hard core, a <a<br /> href="http://www.mingw.org/">MinGW shell).




Note: the standard http://www.mingw.org/">MinGW
msys startup script uses rxvt which has problems setting up
standard input and output. Running bash directly works
correctly.




For documentation, please visit the <a<br /> href="https://mercurial-scm.org/">Mercurial web site.
You can also download a free book, <a<br /> href="https://book.mercurial-scm.org/">Mercurial: The Definitive
Guide.




By default, Mercurial installs to C:\Program
Files\Mercurial. The Mercurial command is called
hg.exe.



Testing Mercurial after you've installed it




The easiest way to check that Mercurial is installed properly is
to just type the following at the command prompt:




hg



This command should print a useful help message. If it does,
other Mercurial commands should work fine for you.



Configuration notes


Default editor



The default editor for commit messages is 'notepad'. You can set
the EDITOR (or HGEDITOR) environment variable
to specify your preference or set it in mercurial.ini:



[ui]
editor = whatever


Configuring a Merge program



It should be emphasized that Mercurial by itself doesn't attempt
to do a Merge at the file level, neither does it make any
attempt to Resolve the conflicts.




By default, Mercurial will use the merge program defined by the
HGMERGE environment variable, or uses the one defined
in the mercurial.ini file. (see <a<br /> href="https://mercurial-scm.org/wiki/MergeProgram">MergeProgram
on the Mercurial Wiki for more information)



Reporting problems




Before you report any problems, please consult the <a<br /> href="https://mercurial-scm.org/">Mercurial web site
and see if your question is already in our list of <a<br /> href="https://mercurial-scm.org/wiki/FAQ">Frequently
Answered Questions (the "FAQ").




If you cannot find an answer to your question, please feel free
to send mail to the Mercurial mailing list, at <a<br /> href="mailto:mercurial@mercurial-scm.org">mercurial@mercurial-scm.org.
Remember, the more useful information you include in your
report, the easier it will be for us to help you!




If you are IRC-savvy, that's usually the fastest way to get
help. Go to #mercurial on irc.freenode.net.



Author and copyright information




Mercurial was written by http://www.selenic.com">Matt
Mackall, and is maintained by Matt and a team of volunteers.




The Windows installer was written by <a<br /> href="http://www.serpentine.com/blog">Bryan O'Sullivan.




Mercurial is Copyright 2005-2018 Matt Mackall and others. See
the Contributors.txt file for a list of contributors.




Mercurial is free software; you can redistribute it and/or
modify it under the terms of the <a<br /> href="http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt">GNU
General Public License version 2 or any later version.




Mercurial is distributed in the hope that it will be useful, but
without any warranty; without even the implied warranty
of merchantability or fitness for a particular
purpose. See the GNU General Public License for more
details.


</body>
</html>