upstream/mercurial-mirror Files · tests/test-check-config.t

revset: use phasecache.getrevset to calculate public()...

revset: use phasecache.getrevset to calculate public() Other revsets like secret(), draft(), _nonpublic() are using phasescache.getrevset already. The latter is more efficient after D1606. So let's migrate the public() revset function too. Tested using: $ hg debugshell --hidden --cwd hg-committed` In [1]: %timeit len(repo.revs('public()')) * Before D1606: 10 loops, best of 3: 22.5 ms per loop * Before this change, after D1606: 10 loops, best of 3: 28.6 ms per loop * After this change: 10 loops, best of 3: 20.2 ms per loop Therefore `public()` revset becomes even slightly faster after the data structure change by D1606. A similar performance win could also be observed on a large repo. A side effect is `phasecache.getrevset` needs to take a `subset` parameter. That was added with a default value so it won't cause BC issues. Differential Revision: https://phab.mercurial-scm.org/D1620

Ryan McElroy - - Load All Authors

File last commit:

r33571:e470f12d default


                r35331:0c1aff6d

default

Download file

             test-check-config.t
        
                    47 lines
            
             | 1.5 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-config.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require test-repo

        $ . "$TESTDIR/helpers-testrepo.sh"

      Sanity check check-config.py

        $ cat > testfile.py << EOF

        > # Good

        > foo = ui.config('ui', 'username')

        > # Missing

        > foo = ui.config('ui', 'doesnotexist')

        > # Missing different type

        > foo = ui.configint('ui', 'missingint')

        > # Missing with default value

        > foo = ui.configbool('ui', 'missingbool1', default=True)

        > foo = ui.configbool('ui', 'missingbool2', False)

        > # Inconsistent values for defaults.

        > foo = ui.configint('ui', 'intdefault', default=1)

        > foo = ui.configint('ui', 'intdefault', default=42)

        > # Can suppress inconsistent value error

        > foo = ui.configint('ui', 'intdefault2', default=1)

        > # inconsistent config: ui.intdefault2

        > foo = ui.configint('ui', 'intdefault2', default=42)

        > EOF

        $ cat > files << EOF

        > mercurial/help/config.txt

        > $TESTTMP/testfile.py

        > EOF

        $ cd "$TESTDIR"/..

        $ $PYTHON contrib/check-config.py < $TESTTMP/files

        foo = ui.configint('ui', 'intdefault', default=42)

        conflict on ui.intdefault: ('int', '42') != ('int', '1')

        at $TESTTMP/testfile.py:12: (glob)

        undocumented: ui.doesnotexist (str)

        undocumented: ui.intdefault (int) [42]

        undocumented: ui.intdefault2 (int) [42]

        undocumented: ui.missingbool1 (bool) [True]

        undocumented: ui.missingbool2 (bool)

        undocumented: ui.missingint (int)

      New errors are not allowed. Warnings are strongly discouraged.

        $ testrepohg files "set:(**.py or **.txt) - tests/**" | sed 's|\\|/|g' |

        >   $PYTHON contrib/check-config.py

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require test-repo

				$ . "$TESTDIR/helpers-testrepo.sh"

				Sanity check check-config.py

				$ cat > testfile.py << EOF
				> # Good
				> foo = ui.config('ui', 'username')
				> # Missing
				> foo = ui.config('ui', 'doesnotexist')
				> # Missing different type
				> foo = ui.configint('ui', 'missingint')
				> # Missing with default value
				> foo = ui.configbool('ui', 'missingbool1', default=True)
				> foo = ui.configbool('ui', 'missingbool2', False)
				> # Inconsistent values for defaults.
				> foo = ui.configint('ui', 'intdefault', default=1)
				> foo = ui.configint('ui', 'intdefault', default=42)
				> # Can suppress inconsistent value error
				> foo = ui.configint('ui', 'intdefault2', default=1)
				> # inconsistent config: ui.intdefault2
				> foo = ui.configint('ui', 'intdefault2', default=42)
				> EOF

				$ cat > files << EOF
				> mercurial/help/config.txt
				> $TESTTMP/testfile.py
				> EOF

				$ cd "$TESTDIR"/..

				$ $PYTHON contrib/check-config.py < $TESTTMP/files
				foo = ui.configint('ui', 'intdefault', default=42)
				conflict on ui.intdefault: ('int', '42') != ('int', '1')
				at $TESTTMP/testfile.py:12: (glob)
				undocumented: ui.doesnotexist (str)
				undocumented: ui.intdefault (int) [42]
				undocumented: ui.intdefault2 (int) [42]
				undocumented: ui.missingbool1 (bool) [True]
				undocumented: ui.missingbool2 (bool)
				undocumented: ui.missingint (int)

				New errors are not allowed. Warnings are strongly discouraged.

				$ testrepohg files "set:(.py or .txt) - tests/**" \| sed 's\|\\\|/\|g' \|
				> $PYTHON contrib/check-config.py