upstream/mercurial-mirror Files · mercurial/revlogutils/concurrency_checker.py

interfaces: move peer `capabilities()` to the `ipeercapabilities` interface...

interfaces: move peer `capabilities()` to the `ipeercapabilities` interface I'm not sure why this was on the `ipeercommands` interface. It appears to be because these interfaces started out as `_basewirecommands` to hold wire commands, back in 558f5b2ee10e. The capabilities interface wasn't split out until 98861a2298b5, when it pulled the capability related methods off of the `ipeerbase` interface. Perhaps it was an oversight to not look at the commands interface because, while this is a wire command, both `sshpeer` and `httppeer` now perform a handshake while instantiating the peer object, and cache a fixed list of capabilities in that object. Likewise, `localpeer` is given a fixed set of capabilities when instantiated. Back in 558f5b2ee10e, `httppeer` looks like it issued a wire command when this method was called, but `sshpeer` obtained and cached the capabilities when instantiated, and this method always returned a fixed value. There's a perfectly good interface with other capability related methods, and having it here makes it easier to implement the base `peer` mixin class.

Matt Harbison - - Load All Authors

File last commit:

r52757:1c5810ce default


                r53417:1554bd50

default

Download file

             concurrency_checker.py
        
                    40 lines
            
             | 1.5 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / revlogutils / concurrency_checker.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import annotations

      from ..i18n import _

      from .. import error

      def get_checker(ui, revlog_name=b'changelog'):

          """Get a function that checks file handle position is as expected.

          This is used to ensure that files haven't been modified outside of our

          knowledge (such as on a networked filesystem, if `hg debuglocks` was used,

          or writes to .hg that ignored locks happened).

          Due to revlogs supporting a concept of buffered, delayed, or diverted

          writes, we're allowing the files to be shorter than expected (the data may

          not have been written yet), but they can't be longer.

          Please note that this check is not perfect; it can't detect all cases (there

          may be false-negatives/false-OKs), but it should never claim there's an

          issue when there isn't (false-positives/false-failures).

          """

          vpos = ui.config(b'debug', b'revlog.verifyposition.' + revlog_name)

          # Avoid any `fh.tell` cost if this isn't enabled.

          if not vpos or vpos not in [b'log', b'warn', b'fail']:

              return None

          def _checker(fh, fn, expected):

              if fh.tell() <= expected:

                  return

              msg = _(b'%s: file cursor at position %d, expected %d')

              # Always log if we're going to warn or fail.

              ui.log(b'debug', msg + b'\n', fn, fh.tell(), expected)

              if vpos == b'warn':

                  ui.warn((msg + b'\n') % (fn, fh.tell(), expected))

              elif vpos == b'fail':

                  raise error.RevlogError(msg % (fn, fh.tell(), expected))

          return _checker

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import annotations

				from ..i18n import _
				from .. import error


				def get_checker(ui, revlog_name=b'changelog'):
				"""Get a function that checks file handle position is as expected.

				This is used to ensure that files haven't been modified outside of our
				knowledge (such as on a networked filesystem, if `hg debuglocks` was used,
				or writes to .hg that ignored locks happened).

				Due to revlogs supporting a concept of buffered, delayed, or diverted
				writes, we're allowing the files to be shorter than expected (the data may
				not have been written yet), but they can't be longer.

				Please note that this check is not perfect; it can't detect all cases (there
				may be false-negatives/false-OKs), but it should never claim there's an
				issue when there isn't (false-positives/false-failures).
				"""

				vpos = ui.config(b'debug', b'revlog.verifyposition.' + revlog_name)
				# Avoid any `fh.tell` cost if this isn't enabled.
				if not vpos or vpos not in [b'log', b'warn', b'fail']:
				return None

				def _checker(fh, fn, expected):
				if fh.tell() <= expected:
				return

				msg = _(b'%s: file cursor at position %d, expected %d')
				# Always log if we're going to warn or fail.
				ui.log(b'debug', msg + b'\n', fn, fh.tell(), expected)
				if vpos == b'warn':
				ui.warn((msg + b'\n') % (fn, fh.tell(), expected))
				elif vpos == b'fail':
				raise error.RevlogError(msg % (fn, fh.tell(), expected))

				return _checker