upstream/mercurial-mirror Files · mercurial/bitmanipulation.h

revset: use phasecache.getrevset...

revset: use phasecache.getrevset This is part of a refactoring that moves some phase query optimization from revset.py to phases.py. See the previous patch for motivation. This patch changes revset code to use phasecache.getrevset so it no longer accesses the private field: _phasecache._phasesets directly. For performance impact, this patch was tested using the following query, on my hg-committed repo: for i in 'public()' 'not public()' 'draft()' 'not draft()'; do echo $i; hg perfrevset "$i"; hg perfrevset "$i" --hidden; done For the CPython implementation, most operations are unchanged (within +/- 1%), while "not public()" and "draft()" is noticeably faster on an unfiltered repo. It may be because the new code avoids a set copy if filteredrevs is empty. revset | public() | not public() | draft() | not draft() hidden | yes | no | yes | no | yes | no | yes | no ------------------------------------------------------------------ before | 19006 | 17352 | 239 | 286 | 180 | 228 | 7690 | 5745 after | 19137 | 17231 | 240 | 207 | 182 | 150 | 7687 | 5658 delta | | -38% | | -52% | (timed in microseconds) For the pure Python implementation, some operations are faster while "not draft()" is noticeably slower: revset | public() | not public() | draft() | not draft() hidden | yes | no | yes | no | yes | no | yes | no ------------------------------------------------------------------------ before | 18852 | 17183 | 17758 | 15921 | 17505 | 15973 | 41521 | 39822 after | 18924 | 17380 | 17558 | 14545 | 16727 | 13593 | 48356 | 43992 delta | | -9% | -5% | -15% | +16% | +10% That may be the different performance characters of generatorset vs. filteredset. The "not draft()" query could be optimized in this case where both "public" and "secret" are passed to "getrevsets" so it won't iterate the whole repo twice.

Maciej Fijalkowski - - Load All Authors

File last commit:

r29444:284d742e default


                r31017:17b5cda5

default

Download file

             bitmanipulation.h
        
                    53 lines
            
             | 933 B
            
                | text/x-c
            
             |
                CLexer
            
             / mercurial / bitmanipulation.h
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #ifndef _HG_BITMANIPULATION_H_

      #define _HG_BITMANIPULATION_H_

      #include "compat.h"

      static inline uint32_t getbe32(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	return ((d[0] << 24) |

      		(d[1] << 16) |

      		(d[2] << 8) |

      		(d[3]));

      }

      static inline int16_t getbeint16(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	return ((d[0] << 8) |

      		(d[1]));

      }

      static inline uint16_t getbeuint16(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	return ((d[0] << 8) |

      		(d[1]));

      }

      static inline void putbe32(uint32_t x, char *c)

      {

      	c[0] = (x >> 24) & 0xff;

      	c[1] = (x >> 16) & 0xff;

      	c[2] = (x >> 8) & 0xff;

      	c[3] = (x) & 0xff;

      }

      static inline double getbefloat64(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	double ret;

      	int i;

      	uint64_t t = 0;

      	for (i = 0; i < 8; i++) {

      		t = (t<<8) + d[i];

      	}

      	memcpy(&ret, &t, sizeof(t));

      	return ret;

      }

      #endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#ifndef _HG_BITMANIPULATION_H_
				#define _HG_BITMANIPULATION_H_

				#include "compat.h"

				static inline uint32_t getbe32(const char *c)
				{
				const unsigned char d = (const unsigned char )c;

				return ((d[0] << 24) \|
				(d[1] << 16) \|
				(d[2] << 8) \|
				(d[3]));
				}

				static inline int16_t getbeint16(const char *c)
				{
				const unsigned char d = (const unsigned char )c;

				return ((d[0] << 8) \|
				(d[1]));
				}

				static inline uint16_t getbeuint16(const char *c)
				{
				const unsigned char d = (const unsigned char )c;

				return ((d[0] << 8) \|
				(d[1]));
				}

				static inline void putbe32(uint32_t x, char *c)
				{
				c[0] = (x >> 24) & 0xff;
				c[1] = (x >> 16) & 0xff;
				c[2] = (x >> 8) & 0xff;
				c[3] = (x) & 0xff;
				}

				static inline double getbefloat64(const char *c)
				{
				const unsigned char d = (const unsigned char )c;
				double ret;
				int i;
				uint64_t t = 0;
				for (i = 0; i < 8; i++) {
				t = (t<<8) + d[i];
				}
				memcpy(&ret, &t, sizeof(t));
				return ret;
				}

				#endif