upstream/mercurial-mirror Files · mercurial/mpatch.h

errors: create "similarity hint" for UnknownIdentifier eagerly in constructor...

errors: create "similarity hint" for UnknownIdentifier eagerly in constructor No code wanted to do anything but to produce a hint from it anyway, so we might as well just store the hint in the exception (which already extended `Hint`). That way we can easily convert it to a `ConfigException` when it's parsing of configuration that fails. I was wondering if the purpose of lazily creating the string was so we don't create it in cases where it won't get printed anyway. However, I couldn't find any places where that could happen. If we do find such places, we could instead revert to making it lazy but add a function on `UnknownIdentifier` for creating the hint string. I dropped the comment saying "make sure to check fileset first, as revset can invoke fileset", which was added in (dispatch: offer near-edit-distance suggestions for {file,rev}set functions, 2015-01-26). I couldn't figure out what it meant. The author of that patch also did not remember the reason for it. Perhaps changes that have happened since then made it so it no longer matters. Differential Revision: https://phab.mercurial-scm.org/D9346

Augie Fackler - - Load All Authors

File last commit:

r34801:76135583 default


                r46495:1817b668

default

Download file

             mpatch.h
        
                    26 lines
            
             | 717 B
            
                | text/x-c
            
             |
                CLexer
            
             / mercurial / mpatch.h
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #ifndef _HG_MPATCH_H_

      #define _HG_MPATCH_H_

      #define MPATCH_ERR_NO_MEM -3

      #define MPATCH_ERR_CANNOT_BE_DECODED -2

      #define MPATCH_ERR_INVALID_PATCH -1

      struct mpatch_frag {

      	int start, end, len;

      	const char *data;

      };

      struct mpatch_flist {

      	struct mpatch_frag *base, *head, *tail;

      };

      int mpatch_decode(const char *bin, ssize_t len, struct mpatch_flist **res);

      ssize_t mpatch_calcsize(ssize_t len, struct mpatch_flist *l);

      void mpatch_lfree(struct mpatch_flist *a);

      int mpatch_apply(char *buf, const char *orig, ssize_t len,

                       struct mpatch_flist *l);

      struct mpatch_flist *

      mpatch_fold(void *bins, struct mpatch_flist *(*get_next_item)(void *, ssize_t),

                  ssize_t start, ssize_t end);

      #endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#ifndef _HG_MPATCH_H_
				#define _HG_MPATCH_H_

				#define MPATCH_ERR_NO_MEM -3
				#define MPATCH_ERR_CANNOT_BE_DECODED -2
				#define MPATCH_ERR_INVALID_PATCH -1

				struct mpatch_frag {
				int start, end, len;
				const char *data;
				};

				struct mpatch_flist {
				struct mpatch_frag base, head, *tail;
				};

				int mpatch_decode(const char bin, ssize_t len, struct mpatch_flist *res);
				ssize_t mpatch_calcsize(ssize_t len, struct mpatch_flist *l);
				void mpatch_lfree(struct mpatch_flist *a);
				int mpatch_apply(char buf, const char orig, ssize_t len,
				struct mpatch_flist *l);
				struct mpatch_flist *
				mpatch_fold(void bins, struct mpatch_flist (get_next_item)(void , ssize_t),
				ssize_t start, ssize_t end);

				#endif