upstream/mercurial-mirror Files · mercurial/scmposix.py

worker: ignore meaningless exit status indication returned by os.waitpid()...

worker: ignore meaningless exit status indication returned by os.waitpid() Before this patch, worker implementation assumes that os.waitpid() with os.WNOHANG returns '(0, 0)' for still running child process. This is explicitly specified as below in Python API document. os.WNOHANG The option for waitpid() to return immediately if no child process status is available immediately. The function returns (0, 0) in this case. On the other hand, POSIX specification doesn't define the "stat_loc" value returned by waitpid() with WNOHANG for such child process. http://pubs.opengroup.org/onlinepubs/9699919799/functions/waitpid.html CPython implementation for os.waitpid() on POSIX doesn't take any care of this gap, and this may cause unexpected "exit status indication" even on POSIX conformance platform. For example, os.waitpid() with os.WNOHANG returns non-zero "exit status indication" on FreeBSD. This implies os.kill() with own pid or sys.exit() with non-zero exit code, even if no child process fails. To ignore meaningless exit status indication returned by os.waitpid(), this patch skips subsequent steps forcibly, if os.waitpid() returns 0 as pid. This patch also arranges examination of 'p' value for readability. FYI, there are some issues below about this behavior reported for CPython. https://bugs.python.org/issue21791 https://bugs.python.org/issue27808

David Demelier - - Load All Authors

File last commit:

r30941:35402007 default


                r31063:18fb3cf5

stable

Download file

             scmposix.py
        
                    72 lines
            
             | 1.8 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / scmposix.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import absolute_import

      import array

      import errno

      import fcntl

      import os

      import sys

      from . import (

          encoding,

          osutil,

          pycompat,

      )

      def _rcfiles(path):

          rcs = [os.path.join(path, 'hgrc')]

          rcdir = os.path.join(path, 'hgrc.d')

          try:

              rcs.extend([os.path.join(rcdir, f)

                          for f, kind in osutil.listdir(rcdir)

                          if f.endswith(".rc")])

          except OSError:

              pass

          return rcs

      def systemrcpath():

          path = []

          if pycompat.sysplatform == 'plan9':

              root = 'lib/mercurial'

          else:

              root = 'etc/mercurial'

          # old mod_python does not set sys.argv

          if len(getattr(sys, 'argv', [])) > 0:

              p = os.path.dirname(os.path.dirname(pycompat.sysargv[0]))

              if p != '/':

                  path.extend(_rcfiles(os.path.join(p, root)))

          path.extend(_rcfiles('/' + root))

          return path

      def userrcpath():

          if pycompat.sysplatform == 'plan9':

              return [encoding.environ['home'] + '/lib/hgrc']

          else:

              return [os.path.expanduser('~/.hgrc')]

      def termsize(ui):

          try:

              import termios

              TIOCGWINSZ = termios.TIOCGWINSZ  # unavailable on IRIX (issue3449)

          except (AttributeError, ImportError):

              return 80, 24

          for dev in (ui.ferr, ui.fout, ui.fin):

              try:

                  try:

                      fd = dev.fileno()

                  except AttributeError:

                      continue

                  if not os.isatty(fd):

                      continue

                  arri = fcntl.ioctl(fd, TIOCGWINSZ, '\0' * 8)

                  height, width = array.array('h', arri)[:2]

                  if width > 0 and height > 0:

                      return width, height

              except ValueError:

                  pass

              except IOError as e:

                  if e[0] == errno.EINVAL:

                      pass

                  else:

                      raise

          return 80, 24

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import absolute_import

				import array
				import errno
				import fcntl
				import os
				import sys

				from . import (
				encoding,
				osutil,
				pycompat,
				)

				def _rcfiles(path):
				rcs = [os.path.join(path, 'hgrc')]
				rcdir = os.path.join(path, 'hgrc.d')
				try:
				rcs.extend([os.path.join(rcdir, f)
				for f, kind in osutil.listdir(rcdir)
				if f.endswith(".rc")])
				except OSError:
				pass
				return rcs

				def systemrcpath():
				path = []
				if pycompat.sysplatform == 'plan9':
				root = 'lib/mercurial'
				else:
				root = 'etc/mercurial'
				# old mod_python does not set sys.argv
				if len(getattr(sys, 'argv', [])) > 0:
				p = os.path.dirname(os.path.dirname(pycompat.sysargv[0]))
				if p != '/':
				path.extend(_rcfiles(os.path.join(p, root)))
				path.extend(_rcfiles('/' + root))
				return path

				def userrcpath():
				if pycompat.sysplatform == 'plan9':
				return [encoding.environ['home'] + '/lib/hgrc']
				else:
				return [os.path.expanduser('~/.hgrc')]

				def termsize(ui):
				try:
				import termios
				TIOCGWINSZ = termios.TIOCGWINSZ # unavailable on IRIX (issue3449)
				except (AttributeError, ImportError):
				return 80, 24

				for dev in (ui.ferr, ui.fout, ui.fin):
				try:
				try:
				fd = dev.fileno()
				except AttributeError:
				continue
				if not os.isatty(fd):
				continue
				arri = fcntl.ioctl(fd, TIOCGWINSZ, '\0' * 8)
				height, width = array.array('h', arri)[:2]
				if width > 0 and height > 0:
				return width, height
				except ValueError:
				pass
				except IOError as e:
				if e[0] == errno.EINVAL:
				pass
				else:
				raise
				return 80, 24