upstream/mercurial-mirror Files · mercurial/dirstateguard.py

httppeer: remove support for connecting to <0.9.1 servers (BC)...

httppeer: remove support for connecting to <0.9.1 servers (BC) Previously, HTTP wire protocol clients would attempt a "capabilities" wire protocol command. If that failed, they would fall back to issuing a "between" command. The "capabilities" command was added in Mercurial 0.9.1 (released July 2006). The "between" command has been present for as long as the wire protocol has existed. So if the "between" command failed, it was safe to assume that the remote could not speak any version of the Mercurial wire protocol. The "between" fallback was added in in 2011. Before that changeset, Mercurial would *always* issue the "between" command and would issue "capabilities" if capabilities were requested. At that time, many connections would issue "capabilities" eventually, so it was decided to issue "capabilities" by default and fall back to "between" if that failed. This saved a round trip when connecting to modern servers while still preserving compatibility with legacy servers. Fast forward ~7 years. Mercurial servers supporting "capabilities" have been around for over a decade. If modern clients are connecting to <0.9.1 servers, they are getting a bad experience. They may even be getting bad data (an old server is vulnerable to numerous security issues and could have been p0wned, leading to a Mercurial repository serving backdoors or other badness). In addition, the fallback can harm experience for modern servers. If a client experiences an intermittent HTTP request failure (due to bad network, etc) and falls back to a "between" that works, it would assume an empty capability set and would attempt to communicate with the repository using a very ancient wire protocol. Auditing HTTP logs for hg.mozilla.org, I did find a handful of requests for the null range of the "between" command. However, requests can be days apart. And when I do see requests, they come in batches. Those batches seem to correlate to spikes of HTTP 500 or other server/network events. So I think these requests are fallbacks from failed "capabilities" requests and not from old clients. If you need even more evidence to discontinue support, apparently we have no test coverage for communicating with servers not supporting "capabilities." I know this because all tests pass with the "between" fallback removed. Finally, server-side support for <0.9.1 pushing (the "addchangegroup" wire protocol command along with locking-related commands) was dropped from the HTTP client in in 2017 and the SSH client in in 2015. I think this all adds up to enough justification for removing client support for communicating with servers not supporting "capabilities." So this commit removes that fallback. Differential Revision: https://phab.mercurial-scm.org/D2001

Martin von Zweigbergk - - Load All Authors

File last commit:

r33790:bbbbd3c3 default


                r35902:197d10e1

default

Download file

             dirstateguard.py
        
                    69 lines
            
             | 2.2 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / dirstateguard.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # dirstateguard.py - class to allow restoring dirstate after failure

      #

      # Copyright 2005-2007 Matt Mackall <mpm@selenic.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      from .i18n import _

      from . import (

          error,

          util,

      )

      class dirstateguard(util.transactional):

          '''Restore dirstate at unexpected failure.

          At the construction, this class does:

          - write current ``repo.dirstate`` out, and

          - save ``.hg/dirstate`` into the backup file

          This restores ``.hg/dirstate`` from backup file, if ``release()``

          is invoked before ``close()``.

          This just removes the backup file at ``close()`` before ``release()``.

          '''

          def __init__(self, repo, name):

              self._repo = repo

              self._active = False

              self._closed = False

              self._backupname = 'dirstate.backup.%s.%d' % (name, id(self))

              repo.dirstate.savebackup(repo.currenttransaction(), self._backupname)

              self._active = True

          def __del__(self):

              if self._active: # still active

                  # this may occur, even if this class is used correctly:

                  # for example, releasing other resources like transaction

                  # may raise exception before ``dirstateguard.release`` in

                  # ``release(tr, ....)``.

                  self._abort()

          def close(self):

              if not self._active: # already inactivated

                  msg = (_("can't close already inactivated backup: %s")

                         % self._backupname)

                  raise error.Abort(msg)

              self._repo.dirstate.clearbackup(self._repo.currenttransaction(),

                                               self._backupname)

              self._active = False

              self._closed = True

          def _abort(self):

              self._repo.dirstate.restorebackup(self._repo.currenttransaction(),

                                                 self._backupname)

              self._active = False

          def release(self):

              if not self._closed:

                  if not self._active: # already inactivated

                      msg = (_("can't release already inactivated backup: %s")

                             % self._backupname)

                      raise error.Abort(msg)

                  self._abort()

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# dirstateguard.py - class to allow restoring dirstate after failure
				#
				# Copyright 2005-2007 Matt Mackall <mpm@selenic.com>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import absolute_import

				from .i18n import _

				from . import (
				error,
				util,
				)

				class dirstateguard(util.transactional):
				'''Restore dirstate at unexpected failure.

				At the construction, this class does:

				- write current ``repo.dirstate`` out, and
				- save ``.hg/dirstate`` into the backup file

				This restores ``.hg/dirstate`` from backup file, if ``release()``
				is invoked before ``close()``.

				This just removes the backup file at ``close()`` before ``release()``.
				'''

				def __init__(self, repo, name):
				self._repo = repo
				self._active = False
				self._closed = False
				self._backupname = 'dirstate.backup.%s.%d' % (name, id(self))
				repo.dirstate.savebackup(repo.currenttransaction(), self._backupname)
				self._active = True

				def __del__(self):
				if self._active: # still active
				# this may occur, even if this class is used correctly:
				# for example, releasing other resources like transaction
				# may raise exception before ``dirstateguard.release`` in
				# ``release(tr, ....)``.
				self._abort()

				def close(self):
				if not self._active: # already inactivated
				msg = (_("can't close already inactivated backup: %s")
				% self._backupname)
				raise error.Abort(msg)

				self._repo.dirstate.clearbackup(self._repo.currenttransaction(),
				self._backupname)
				self._active = False
				self._closed = True

				def _abort(self):
				self._repo.dirstate.restorebackup(self._repo.currenttransaction(),
				self._backupname)
				self._active = False

				def release(self):
				if not self._closed:
				if not self._active: # already inactivated
				msg = (_("can't release already inactivated backup: %s")
				% self._backupname)
				raise error.Abort(msg)
				self._abort()