##// END OF EJS Templates
obsolescence: add test case B-7 for obsolescence markers exchange...
obsolescence: add test case B-7 for obsolescence markers exchange About 3 years ago, in August 2014, the logic to select what markers to select on push was ported from the evolve extension to Mercurial core. However, for some unclear reasons, the tests for that logic were not ported alongside. I realised it a couple of weeks ago while working on another push related issue. I've made a clean up pass on the tests and they are now ready to integrate the core test suite. This series of changesets do not change any logic. I just adds test for logic that has been around for about 10 versions of Mercurial. They are a patch for each test case. It makes it easier to review and postpone one with documentation issues without rejecting the wholes series. This patch introduce case B-7: Prune above non-targeted common changeset Each test case comes it in own test file. It help parallelism and does not introduce a significant overhead from having a single unified giant test file. Here are timing to support this claim. # Multiple test files version: # run-tests.py --local -j 1 test-exchange-*.t 53.40s user 6.82s system 85% cpu 1:10.76 total 52.79s user 6.97s system 85% cpu 1:09.97 total 52.94s user 6.82s system 85% cpu 1:09.69 total # Single test file version: # run-tests.py --local -j 1 test-exchange-obsmarkers.t 52.97s user 6.85s system 85% cpu 1:10.10 total 52.64s user 6.79s system 85% cpu 1:09.63 total 53.70s user 7.00s system 85% cpu 1:11.17 total

File last commit:

r31849:5c1abb4b default
r31919:2bf73e35 default
Show More
followlines.js
219 lines | 8.0 KiB | application/javascript | JavascriptLexer
// followlines.js - JavaScript utilities for followlines UI
//
// Copyright 2017 Logilab SA <contact@logilab.fr>
//
// This software may be used and distributed according to the terms of the
// GNU General Public License version 2 or any later version.
//** Install event listeners for line block selection and followlines action */
document.addEventListener('DOMContentLoaded', function() {
var sourcelines = document.getElementsByClassName('sourcelines')[0];
if (typeof sourcelines === 'undefined') {
return;
}
// URL to complement with "linerange" query parameter
var targetUri = sourcelines.dataset.logurl;
if (typeof targetUri === 'undefined') {
return;
}
// tooltip to invite on lines selection
var tooltip = document.createElement('div');
tooltip.id = 'followlines-tooltip';
tooltip.classList.add('hidden');
var initTooltipText = 'click to start following lines history from here';
tooltip.textContent = initTooltipText;
sourcelines.appendChild(tooltip);
//* position "element" on top-right of cursor */
function positionTopRight(element, event) {
var x = (event.clientX + 10) + 'px',
y = (event.clientY - 20) + 'px';
element.style.top = y;
element.style.left = x;
}
var tooltipTimeoutID;
//* move the "tooltip" with cursor (top-right) and show it after 1s */
function moveAndShowTooltip(e) {
if (typeof tooltipTimeoutID !== 'undefined') {
// avoid accumulation of timeout callbacks (blinking)
window.clearTimeout(tooltipTimeoutID);
}
tooltip.classList.add('hidden');
positionTopRight(tooltip, e);
tooltipTimeoutID = window.setTimeout(function() {
tooltip.classList.remove('hidden');
}, 1000);
}
// on mousemove, show tooltip close to cursor position
sourcelines.addEventListener('mousemove', moveAndShowTooltip);
// retrieve all direct <span> children of <pre class="sourcelines">
var spans = Array.prototype.filter.call(
sourcelines.children,
function(x) { return x.tagName === 'SPAN' });
// add a "followlines-select" class to change cursor type in CSS
for (var i = 0; i < spans.length; i++) {
spans[i].classList.add('followlines-select');
}
var lineSelectedCSSClass = 'followlines-selected';
//** add CSS class on <span> element in `from`-`to` line range */
function addSelectedCSSClass(from, to) {
for (var i = from; i <= to; i++) {
spans[i].classList.add(lineSelectedCSSClass);
}
}
//** remove CSS class from previously selected lines */
function removeSelectedCSSClass() {
var elements = sourcelines.getElementsByClassName(
lineSelectedCSSClass);
while (elements.length) {
elements[0].classList.remove(lineSelectedCSSClass);
}
}
// ** return the <span> element parent of `element` */
function findParentSpan(element) {
var parent = element.parentElement;
if (parent === null) {
return null;
}
if (element.tagName == 'SPAN' && parent.isSameNode(sourcelines)) {
return element;
}
return findParentSpan(parent);
}
//** event handler for "click" on the first line of a block */
function lineSelectStart(e) {
var startElement = findParentSpan(e.target);
if (startElement === null) {
// not a <span> (maybe <a>): abort, keeping event listener
// registered for other click with <span> target
return;
}
// update tooltip text
tooltip.textContent = 'click again to terminate line block selection here';
var startId = parseInt(startElement.id.slice(1));
startElement.classList.add(lineSelectedCSSClass); // CSS
// remove this event listener
sourcelines.removeEventListener('click', lineSelectStart);
//** event handler for "click" on the last line of the block */
function lineSelectEnd(e) {
var endElement = findParentSpan(e.target);
if (endElement === null) {
// not a <span> (maybe <a>): abort, keeping event listener
// registered for other click with <span> target
return;
}
// remove this event listener
sourcelines.removeEventListener('click', lineSelectEnd);
// hide tooltip and disable motion tracking
tooltip.classList.add('hidden');
sourcelines.removeEventListener('mousemove', moveAndShowTooltip);
window.clearTimeout(tooltipTimeoutID);
//* restore initial "tooltip" state */
function restoreTooltip() {
tooltip.textContent = initTooltipText;
sourcelines.addEventListener('mousemove', moveAndShowTooltip);
}
// compute line range (startId, endId)
var endId = parseInt(endElement.id.slice(1));
if (endId == startId) {
// clicked twice the same line, cancel and reset initial state
// (CSS, event listener for selection start, tooltip)
removeSelectedCSSClass();
sourcelines.addEventListener('click', lineSelectStart);
restoreTooltip();
return;
}
var inviteElement = endElement;
if (endId < startId) {
var tmp = endId;
endId = startId;
startId = tmp;
inviteElement = startElement;
}
addSelectedCSSClass(startId - 1, endId -1); // CSS
// append the <div id="followlines"> element to last line of the
// selection block
var divAndButton = followlinesBox(targetUri, startId, endId);
var div = divAndButton[0],
button = divAndButton[1];
inviteElement.appendChild(div);
// set position close to cursor (top-right)
positionTopRight(div, e);
//** event handler for cancelling selection */
function cancel() {
// remove invite box
div.parentNode.removeChild(div);
// restore initial event listeners
sourcelines.addEventListener('click', lineSelectStart);
sourcelines.removeEventListener('click', cancel);
// remove styles on selected lines
removeSelectedCSSClass();
// restore tooltip element
restoreTooltip();
}
// bind cancel event to click on <button>
button.addEventListener('click', cancel);
// as well as on an click on any source line
sourcelines.addEventListener('click', cancel);
}
sourcelines.addEventListener('click', lineSelectEnd);
}
sourcelines.addEventListener('click', lineSelectStart);
//** return a <div id="followlines"> and inner cancel <button> elements */
function followlinesBox(targetUri, fromline, toline) {
// <div id="followlines">
var div = document.createElement('div');
div.id = 'followlines';
// <div class="followlines-cancel">
var buttonDiv = document.createElement('div');
buttonDiv.classList.add('followlines-cancel');
// <button>x</button>
var button = document.createElement('button');
button.textContent = 'x';
buttonDiv.appendChild(button);
div.appendChild(buttonDiv);
// <div class="followlines-link">
var aDiv = document.createElement('div');
aDiv.classList.add('followlines-link');
// <a href="/log/<rev>/<file>?patch=&linerange=...">
var a = document.createElement('a');
var url = targetUri + '?patch=&linerange=' + fromline + ':' + toline;
a.setAttribute('href', url);
a.textContent = 'follow lines ' + fromline + ':' + toline;
aDiv.appendChild(a);
div.appendChild(aDiv);
return [div, button];
}
}, false);