upstream/mercurial-mirror Files · hgext/infinitepush/common.py

localrepo: automatically load lfs extension when required (BC)...

localrepo: automatically load lfs extension when required (BC) If an unrecognized requirement is present (possibly due to an unloaded extension), the user will get an error message telling them to go to https://mercurial-scm.org/wiki/MissingRequirement for more info. And some requirements clearly map to known extensions shipped by Mercurial. This commit teaches repository loading to automatically map requirements to extensions. We implement support for loading the lfs extension when the "lfs" requirement is present. This behavior feels more user-friendly to me and I'm having trouble coming up with a compelling reason to not do it. The strongest argument I have against is that - strictly speaking - requirements are general repository features and there could be N providers of that feature. e.g. in the case of LFS, there could be another extension implementing LFS support. And the user would want to use this non-official extension rather than the built-in one. The way this patch implements things, the non-official extension could be missing and Mercurial would load the official lfs extension, leading to unexpected behavior. But this feels like a highly marginal use case to me and doesn't outweigh the user benefit of "it just works." If someone really wanted to e.g. use a custom LFS extension, they could prevent the built-in one from being loaded by either defining "extensions.lfs=/path/to/custom/extension" or "extensions.lfs=!", as the automatic extension loading only occurs if there is no config entry for that extension. Differential Revision: https://phab.mercurial-scm.org/D4711

Yuya Nishihara - - Load All Authors

File last commit:

r38182:aac4be30 default


                r39888:2c2fadbc

default

Download file

             common.py
        
                    48 lines
            
             | 1.2 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / infinitepush / common.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Copyright 2017 Facebook, Inc.

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      import os

      from mercurial.node import hex

      from mercurial import (

          error,

          extensions,

          pycompat,

      )

      def isremotebooksenabled(ui):

          return ('remotenames' in extensions._extensions and

                  ui.configbool('remotenames', 'bookmarks'))

      def downloadbundle(repo, unknownbinhead):

          index = repo.bundlestore.index

          store = repo.bundlestore.store

          bundleid = index.getbundle(hex(unknownbinhead))

          if bundleid is None:

              raise error.Abort('%s head is not known' % hex(unknownbinhead))

          bundleraw = store.read(bundleid)

          return _makebundlefromraw(bundleraw)

      def _makebundlefromraw(data):

          fp = None

          fd, bundlefile = pycompat.mkstemp()

          try:  # guards bundlefile

              try:  # guards fp

                  fp = os.fdopen(fd, 'wb')

                  fp.write(data)

              finally:

                  fp.close()

          except Exception:

              try:

                  os.unlink(bundlefile)

              except Exception:

                  # we would rather see the original exception

                  pass

              raise

          return bundlefile

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Copyright 2017 Facebook, Inc.
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import absolute_import

				import os

				from mercurial.node import hex

				from mercurial import (
				error,
				extensions,
				pycompat,
				)

				def isremotebooksenabled(ui):
				return ('remotenames' in extensions._extensions and
				ui.configbool('remotenames', 'bookmarks'))

				def downloadbundle(repo, unknownbinhead):
				index = repo.bundlestore.index
				store = repo.bundlestore.store
				bundleid = index.getbundle(hex(unknownbinhead))
				if bundleid is None:
				raise error.Abort('%s head is not known' % hex(unknownbinhead))
				bundleraw = store.read(bundleid)
				return _makebundlefromraw(bundleraw)

				def _makebundlefromraw(data):
				fp = None
				fd, bundlefile = pycompat.mkstemp()
				try: # guards bundlefile
				try: # guards fp
				fp = os.fdopen(fd, 'wb')
				fp.write(data)
				finally:
				fp.close()
				except Exception:
				try:
				os.unlink(bundlefile)
				except Exception:
				# we would rather see the original exception
				pass
				raise

				return bundlefile