upstream/mercurial-mirror Files · mercurial/admin_commands.py

interfaces: mark a few dirstate methods abstract...

interfaces: mark a few dirstate methods abstract I'm not sure what's going on here, but when enabling pytype checking on this package, it spits out the following errors: File "/mnt/c/Users/Matt/hg/mercurial/interfaces/dirstate.py", line 136, in changing_parents: bad return type [bad-return-type] Expected: Iterator Actually returned: None Attributes of protocol Iterator are not implemented on None: __next__ File "/mnt/c/Users/Matt/hg/mercurial/interfaces/dirstate.py", line 145, in changing_files: bad return type [bad-return-type] Expected: Iterator Actually returned: None Attributes of protocol Iterator are not implemented on None: __next__ I guess technically that's true, because these methods only have a doc comment, and don't explicitly return something or unconditionally raise an error. The strange thing is that both before and after this change, the *.pyi file that is generated is unchanged, and contains: def changing_files(self, repo) -> contextlib._GeneratorContextManager: ... def changing_parents(self, repo) -> contextlib._GeneratorContextManager: ... I'm not sure if the `@abstractmethod` should be the most inner or most outer decoration. We'll roll the dice with being the innermost, because that's how `@abstractproperty` says it should be used in conjunction with `@property`. We should probably make all of the methods without an actual body abstract, like was done for some `mercurial.wireprototypes` classes in fd200f5bcaea. But let's hold off for now and do that enmass later.

Matt Harbison - - Load All Authors

File last commit:

r52756:f4733654 default


                r53328:2c8c46c3

default

Download file

             admin_commands.py
        
                    52 lines
            
             | 1.6 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / admin_commands.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # admin_commands.py - command processing for admin* commands

      #

      # Copyright 2022 Mercurial Developers

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import annotations

      from .i18n import _

      from .admin import chainsaw, verify

      from . import error, registrar, transaction

      table = {}

      table.update(chainsaw.command._table)

      command = registrar.command(table)

      @command(

          b'admin::verify',

          [

              (b'c', b'check', [], _(b'add a check'), _(b'CHECK')),

              (b'o', b'option', [], _(b'pass an option to a check'), _(b'OPTION')),

          ],

          helpcategory=command.CATEGORY_MAINTENANCE,

      )

      def admin_verify(ui, repo, **opts):

          """verify the integrity of the repository

          Alternative UI to `hg verify` with a lot more control over the

          verification process and better error reporting.

          """

          if not repo.url().startswith(b'file:'):

              raise error.Abort(_(b"cannot verify bundle or remote repos"))

          if transaction.has_abandoned_transaction(repo):

              ui.warn(_(b"abandoned transaction found - run hg recover\n"))

          checks = opts.get("check", [])

          options = opts.get("option", [])

          funcs = verify.get_checks(repo, ui, names=checks, options=options)

          ui.status(_(b"running %d checks\n") % len(funcs))

          # Done in two times so the execution is separated from the resolving step

          for name, func in sorted(funcs.items(), key=lambda x: x[0]):

              ui.status(_(b"running %s\n") % name)

              errors = func()

              if errors:

                  ui.warn(_(b"found %d errors\n") % errors)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# admin_commands.py - command processing for admin* commands
				#
				# Copyright 2022 Mercurial Developers
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import annotations

				from .i18n import _
				from .admin import chainsaw, verify
				from . import error, registrar, transaction


				table = {}
				table.update(chainsaw.command._table)
				command = registrar.command(table)


				@command(
				b'admin::verify',
				[
				(b'c', b'check', [], _(b'add a check'), _(b'CHECK')),
				(b'o', b'option', [], _(b'pass an option to a check'), _(b'OPTION')),
				],
				helpcategory=command.CATEGORY_MAINTENANCE,
				)
				def admin_verify(ui, repo, **opts):
				"""verify the integrity of the repository

				Alternative UI to `hg verify` with a lot more control over the
				verification process and better error reporting.
				"""

				if not repo.url().startswith(b'file:'):
				raise error.Abort(_(b"cannot verify bundle or remote repos"))

				if transaction.has_abandoned_transaction(repo):
				ui.warn(_(b"abandoned transaction found - run hg recover\n"))

				checks = opts.get("check", [])
				options = opts.get("option", [])

				funcs = verify.get_checks(repo, ui, names=checks, options=options)

				ui.status(_(b"running %d checks\n") % len(funcs))
				# Done in two times so the execution is separated from the resolving step
				for name, func in sorted(funcs.items(), key=lambda x: x[0]):
				ui.status(_(b"running %s\n") % name)
				errors = func()
				if errors:
				ui.warn(_(b"found %d errors\n") % errors)