upstream/mercurial-mirror Files · mercurial/typelib.py

interfaces: mark a few dirstate methods abstract...

interfaces: mark a few dirstate methods abstract I'm not sure what's going on here, but when enabling pytype checking on this package, it spits out the following errors: File "/mnt/c/Users/Matt/hg/mercurial/interfaces/dirstate.py", line 136, in changing_parents: bad return type [bad-return-type] Expected: Iterator Actually returned: None Attributes of protocol Iterator are not implemented on None: __next__ File "/mnt/c/Users/Matt/hg/mercurial/interfaces/dirstate.py", line 145, in changing_files: bad return type [bad-return-type] Expected: Iterator Actually returned: None Attributes of protocol Iterator are not implemented on None: __next__ I guess technically that's true, because these methods only have a doc comment, and don't explicitly return something or unconditionally raise an error. The strange thing is that both before and after this change, the *.pyi file that is generated is unchanged, and contains: def changing_files(self, repo) -> contextlib._GeneratorContextManager: ... def changing_parents(self, repo) -> contextlib._GeneratorContextManager: ... I'm not sure if the `@abstractmethod` should be the most inner or most outer decoration. We'll roll the dice with being the innermost, because that's how `@abstractproperty` says it should be used in conjunction with `@property`. We should probably make all of the methods without an actual body abstract, like was done for some `mercurial.wireprototypes` classes in fd200f5bcaea. But let's hold off for now and do that enmass later.

marmoute - - Load All Authors

File last commit:

r52995:82e2c99c default


                r53328:2c8c46c3

default

Download file

             typelib.py
        
                    55 lines
            
             | 1.4 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / typelib.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # typelib.py - type hint aliases and support

      #

      # Copyright 2022 Matt Harbison <matt_harbison@yahoo.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import annotations

      import typing

      from typing import (

          Callable,

      )

      # Note: this is slightly different from pycompat.TYPE_CHECKING, as using

      # pycompat causes the BinaryIO_Proxy type to be resolved to ``object`` when

      # used as the base class during a pytype run.

      TYPE_CHECKING = typing.TYPE_CHECKING

      # The BinaryIO class provides empty methods, which at runtime means that

      # ``__getattr__`` on the proxy classes won't get called for the methods that

      # should delegate to the internal object.  So to avoid runtime changes because

      # of the required typing inheritance, just use BinaryIO when typechecking, and

      # ``object`` otherwise.

      if TYPE_CHECKING:

          from typing import (

              BinaryIO,

              Union,

          )

          from . import (

              node,

              posix,

              util,

              windows,

          )

          BinaryIO_Proxy = BinaryIO

          CacheStat = Union[

              posix.cachestat,

              windows.cachestat,

              util.uncacheable_cachestat,

          ]

          NodeConstants = node.sha1nodeconstants

      else:

          from typing import Any

          BinaryIO_Proxy = object

          CacheStat = Any

          NodeConstants = Any

      # scmutil.getuipathfn() related callback.

      UiPathFn = Callable[[bytes], bytes]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# typelib.py - type hint aliases and support
				#
				# Copyright 2022 Matt Harbison <matt_harbison@yahoo.com>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import annotations

				import typing

				from typing import (
				Callable,
				)

				# Note: this is slightly different from pycompat.TYPE_CHECKING, as using
				# pycompat causes the BinaryIO_Proxy type to be resolved to ``object`` when
				# used as the base class during a pytype run.
				TYPE_CHECKING = typing.TYPE_CHECKING


				# The BinaryIO class provides empty methods, which at runtime means that
				# ``__getattr__`` on the proxy classes won't get called for the methods that
				# should delegate to the internal object. So to avoid runtime changes because
				# of the required typing inheritance, just use BinaryIO when typechecking, and
				# ``object`` otherwise.
				if TYPE_CHECKING:
				from typing import (
				BinaryIO,
				Union,
				)

				from . import (
				node,
				posix,
				util,
				windows,
				)

				BinaryIO_Proxy = BinaryIO
				CacheStat = Union[
				posix.cachestat,
				windows.cachestat,
				util.uncacheable_cachestat,
				]
				NodeConstants = node.sha1nodeconstants
				else:
				from typing import Any

				BinaryIO_Proxy = object
				CacheStat = Any
				NodeConstants = Any

				# scmutil.getuipathfn() related callback.
				UiPathFn = Callable[[bytes], bytes]