upstream/mercurial-mirror Files · contrib/packagelib.sh

hgweb: fix trust of templates path (BC)...

hgweb: fix trust of templates path (BC) Long ago we disabled trust of the templates path with a comment describing the (insecure) behavior before the change. At some later refactor, the code was apparently changed back to match the comment, unaware that the intent of the comment was to describe the behavior to avoid. This change disables the trust and updates the comment to explicitly say not only what the old problem was, but also that it was in fact a problem and the action taken to prevent it. Impact: prior to this change, if you had a UNIX-based hgweb server where users can write hgrc files, those users could potentially read any file readable by the web server. This is marked as a backwards compatibility issue because people may have configured templates without proper trust settings. Issue spotted by Greg Szorc.

Augie Fackler - - Load All Authors

File last commit:

r24972:56c64c91 default


                r26120:1a45e49a

3.5.1 stable

Download file

             packagelib.sh
        
                    19 lines
            
             | 619 B
            
                | application/x-sh
            
             |
                BashLexer
            
             / contrib / packagelib.sh
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      gethgversion() {

          make clean

          make local || make local PURE=--pure

          HG="$PWD/hg"

          $HG version > /dev/null || { echo 'abort: hg version failed!'; exit 1 ; }

          hgversion=`$HG version | sed -ne 's/.*(version \(.*\))$/\1/p'`

          if echo $hgversion | grep -- '-' > /dev/null 2>&1; then

              # nightly build case, version is like 1.3.1+250-20b91f91f9ca

              version=`echo $hgversion | cut -d- -f1`

              release=`echo $hgversion | cut -d- -f2 | sed -e 's/+.*//'`

          else

              # official tag, version is like 1.3.1

              version=`echo $hgversion | sed -e 's/+.*//'`

              release='0'

          fi

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				gethgversion() {
				make clean
				make local \|\| make local PURE=--pure
				HG="$PWD/hg"

				$HG version > /dev/null \|\| { echo 'abort: hg version failed!'; exit 1 ; }

				hgversion=`$HG version \| sed -ne 's/.(version \(.\))$/\1/p'`

				if echo $hgversion \| grep -- '-' > /dev/null 2>&1; then
				# nightly build case, version is like 1.3.1+250-20b91f91f9ca
				version=`echo $hgversion \| cut -d- -f1`
				release=`echo $hgversion \| cut -d- -f2 \| sed -e 's/+.*//'`
				else
				# official tag, version is like 1.3.1
				version=`echo $hgversion \| sed -e 's/+.*//'`
				release='0'
				fi
				}