upstream/mercurial-mirror Files · tests/test-issue522.t

sslutil: require TLS 1.1+ when supported...

sslutil: require TLS 1.1+ when supported Currently, Mercurial will use TLS 1.0 or newer when connecting to remote servers, selecting the highest TLS version supported by both peers. On older Pythons, only TLS 1.0 is available. On newer Pythons, TLS 1.1 and 1.2 should be available. Security professionals recommend avoiding TLS 1.0 if possible. PCI DSS 3.1 "strongly encourages" the use of TLS 1.2. Known attacks like BEAST and POODLE exist against TLS 1.0 (although mitigations are available and properly configured servers aren't vulnerable). I asked Eric Rescorla - Mozilla's resident crypto expert - whether Mercurial should drop support for TLS 1.0. His response was "if you can get away with it." Essentially, a number of servers on the Internet don't support TLS 1.1+. This is why web browsers continue to support TLS 1.0 despite desires from security experts. This patch changes Mercurial's default behavior on modern Python versions to require TLS 1.1+, thus avoiding known security issues with TLS 1.0 and making Mercurial more secure by default. Rather than drop TLS 1.0 support wholesale, we still allow TLS 1.0 to be used if configured. This is a compromise solution - ideally we'd disallow TLS 1.0. However, since we're not sure how many Mercurial servers don't support TLS 1.1+ and we're not sure how much user inconvenience this change will bring, I think it is prudent to ship an escape hatch that still allows usage of TLS 1.0. In the default case our users get better security. In the worst case, they are no worse off than before this patch. This patch has no effect when running on Python versions that don't support TLS 1.1+. As the added test shows, connecting to a server that doesn't support TLS 1.1+ will display a warning message with a link to our wiki, where we can guide people to configure their client to allow less secure connections.

Matt Mackall - - Load All Authors

File last commit:

r26420:2fc86d92 default


                r29560:303e9300

default

Download file

             test-issue522.t
        
                    55 lines
            
             | 1.6 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-issue522.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      https://bz.mercurial-scm.org/522

      In the merge below, the file "foo" has the same contents in both

      parents, but if we look at the file-level history, we'll notice that

      the version in p1 is an ancestor of the version in p2. This test makes

      sure that we'll use the version from p2 in the manifest of the merge

      revision.

        $ hg init

        $ echo foo > foo

        $ hg ci -qAm 'add foo'

        $ echo bar >> foo

        $ hg ci -m 'change foo'

        $ hg backout -r tip -m 'backout changed foo'

        reverting foo

        changeset 2:4d9e78aaceee backs out changeset 1:b515023e500e

        $ hg up -C 0

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ touch bar

        $ hg ci -qAm 'add bar'

        $ hg merge --debug

          searching for copies back to rev 1

          unmatched files in local:

           bar

        resolving manifests

         branchmerge: True, force: False, partial: False

         ancestor: bbd179dfa0a7, local: 71766447bdbb+, remote: 4d9e78aaceee

         foo: remote is newer -> g

        getting foo

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        (branch merge, don't forget to commit)

        $ hg debugstate | grep foo

        m   0         -2 unset               foo

        $ hg st -A foo

        M foo

        $ hg ci -m 'merge'

        $ hg manifest --debug | grep foo

        c6fc755d7e68f49f880599da29f15add41f42f5a 644   foo

        $ hg debugindex foo

           rev    offset  length  ..... linkrev nodeid       p1           p2 (re)

             0         0       5  .....       0 2ed2a3912a0b 000000000000 000000000000 (re)

             1         5       9  .....       1 6f4310b00b9a 2ed2a3912a0b 000000000000 (re)

             2        14       5  .....       2 c6fc755d7e68 6f4310b00b9a 000000000000 (re)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				https://bz.mercurial-scm.org/522

				In the merge below, the file "foo" has the same contents in both
				parents, but if we look at the file-level history, we'll notice that
				the version in p1 is an ancestor of the version in p2. This test makes
				sure that we'll use the version from p2 in the manifest of the merge
				revision.

				$ hg init

				$ echo foo > foo
				$ hg ci -qAm 'add foo'

				$ echo bar >> foo
				$ hg ci -m 'change foo'

				$ hg backout -r tip -m 'backout changed foo'
				reverting foo
				changeset 2:4d9e78aaceee backs out changeset 1:b515023e500e

				$ hg up -C 0
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved

				$ touch bar
				$ hg ci -qAm 'add bar'

				$ hg merge --debug
				searching for copies back to rev 1
				unmatched files in local:
				bar
				resolving manifests
				branchmerge: True, force: False, partial: False
				ancestor: bbd179dfa0a7, local: 71766447bdbb+, remote: 4d9e78aaceee
				foo: remote is newer -> g
				getting foo
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				(branch merge, don't forget to commit)

				$ hg debugstate \| grep foo
				m 0 -2 unset foo

				$ hg st -A foo
				M foo

				$ hg ci -m 'merge'

				$ hg manifest --debug \| grep foo
				c6fc755d7e68f49f880599da29f15add41f42f5a 644 foo

				$ hg debugindex foo
				rev offset length ..... linkrev nodeid p1 p2 (re)
				0 0 5 ..... 0 2ed2a3912a0b 000000000000 000000000000 (re)
				1 5 9 ..... 1 6f4310b00b9a 2ed2a3912a0b 000000000000 (re)
				2 14 5 ..... 2 c6fc755d7e68 6f4310b00b9a 000000000000 (re)