upstream/mercurial-mirror Files · tests/test-pull-http.t

sslutil: require TLS 1.1+ when supported...

sslutil: require TLS 1.1+ when supported Currently, Mercurial will use TLS 1.0 or newer when connecting to remote servers, selecting the highest TLS version supported by both peers. On older Pythons, only TLS 1.0 is available. On newer Pythons, TLS 1.1 and 1.2 should be available. Security professionals recommend avoiding TLS 1.0 if possible. PCI DSS 3.1 "strongly encourages" the use of TLS 1.2. Known attacks like BEAST and POODLE exist against TLS 1.0 (although mitigations are available and properly configured servers aren't vulnerable). I asked Eric Rescorla - Mozilla's resident crypto expert - whether Mercurial should drop support for TLS 1.0. His response was "if you can get away with it." Essentially, a number of servers on the Internet don't support TLS 1.1+. This is why web browsers continue to support TLS 1.0 despite desires from security experts. This patch changes Mercurial's default behavior on modern Python versions to require TLS 1.1+, thus avoiding known security issues with TLS 1.0 and making Mercurial more secure by default. Rather than drop TLS 1.0 support wholesale, we still allow TLS 1.0 to be used if configured. This is a compromise solution - ideally we'd disallow TLS 1.0. However, since we're not sure how many Mercurial servers don't support TLS 1.1+ and we're not sure how much user inconvenience this change will bring, I think it is prudent to ship an escape hatch that still allows usage of TLS 1.0. In the default case our users get better security. In the worst case, they are no worse off than before this patch. This patch has no effect when running on Python versions that don't support TLS 1.1+. As the added test shows, connecting to a server that doesn't support TLS 1.1+ will display a warning message with a link to our wiki, where we can guide people to configure their client to allow less secure connections.

Matt Mackall - - Load All Authors

File last commit:

r25474:8c14f87b default


                r29560:303e9300

default

Download file

             test-pull-http.t
        
                    80 lines
            
             | 2.2 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-pull-http.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require killdaemons

        $ hg init test

        $ cd test

        $ echo a > a

        $ hg ci -Ama

        adding a

        $ cd ..

        $ hg clone test test2

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cd test2

        $ echo a >> a

        $ hg ci -mb

      Cloning with a password in the URL should not save the password in .hg/hgrc:

        $ hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log

        $ cat hg.pid >> $DAEMON_PIDS

        $ hg clone http://foo:xyzzy@localhost:$HGPORT/ test3

        requesting all changes

        adding changesets

        adding manifests

        adding file changes

        added 2 changesets with 2 changes to 1 files

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cat test3/.hg/hgrc

        # example repository config (see "hg help config" for more info)

        [paths]

        default = http://foo@localhost:$HGPORT/

        # path aliases to other clones of this repo in URLs or filesystem paths

        # (see "hg help config.paths" for more info)

        #

        # default-push = ssh://jdoe@example.net/hg/jdoes-fork

        # my-fork      = ssh://jdoe@example.net/hg/jdoes-fork

        # my-clone     = /home/jdoe/jdoes-clone

        [ui]

        # name and email (local to this repository, optional), e.g.

        # username = Jane Doe <jdoe@example.com>

        $ killdaemons.py

      expect error, cloning not allowed

        $ echo '[web]' > .hg/hgrc

        $ echo 'allowpull = false' >> .hg/hgrc

        $ hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log

        $ cat hg.pid >> $DAEMON_PIDS

        $ hg clone http://localhost:$HGPORT/ test4 --config experimental.bundle2-exp=True

        requesting all changes

        abort: authorization failed

        [255]

        $ hg clone http://localhost:$HGPORT/ test4 --config experimental.bundle2-exp=False

        abort: authorization failed

        [255]

        $ killdaemons.py

      serve errors

        $ cat errors.log

        $ req() {

        >     hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log

        >     cat hg.pid >> $DAEMON_PIDS

        >     hg --cwd ../test pull http://localhost:$HGPORT/

        >     killdaemons.py hg.pid

        >     echo % serve errors

        >     cat errors.log

        > }

      expect error, pulling not allowed

        $ req

        pulling from http://localhost:$HGPORT/

        searching for changes

        abort: authorization failed

        % serve errors

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require killdaemons

				$ hg init test
				$ cd test
				$ echo a > a
				$ hg ci -Ama
				adding a
				$ cd ..
				$ hg clone test test2
				updating to branch default
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ cd test2
				$ echo a >> a
				$ hg ci -mb

				Cloning with a password in the URL should not save the password in .hg/hgrc:

				$ hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log
				$ cat hg.pid >> $DAEMON_PIDS
				$ hg clone http://foo:xyzzy@localhost:$HGPORT/ test3
				requesting all changes
				adding changesets
				adding manifests
				adding file changes
				added 2 changesets with 2 changes to 1 files
				updating to branch default
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ cat test3/.hg/hgrc
				# example repository config (see "hg help config" for more info)
				[paths]
				default = http://foo@localhost:$HGPORT/

				# path aliases to other clones of this repo in URLs or filesystem paths
				# (see "hg help config.paths" for more info)
				#
				# default-push = ssh://jdoe@example.net/hg/jdoes-fork
				# my-fork = ssh://jdoe@example.net/hg/jdoes-fork
				# my-clone = /home/jdoe/jdoes-clone

				[ui]
				# name and email (local to this repository, optional), e.g.
				# username = Jane Doe <jdoe@example.com>
				$ killdaemons.py

				expect error, cloning not allowed

				$ echo '[web]' > .hg/hgrc
				$ echo 'allowpull = false' >> .hg/hgrc
				$ hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log
				$ cat hg.pid >> $DAEMON_PIDS
				$ hg clone http://localhost:$HGPORT/ test4 --config experimental.bundle2-exp=True
				requesting all changes
				abort: authorization failed
				[255]
				$ hg clone http://localhost:$HGPORT/ test4 --config experimental.bundle2-exp=False
				abort: authorization failed
				[255]
				$ killdaemons.py

				serve errors

				$ cat errors.log
				$ req() {
				> hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log
				> cat hg.pid >> $DAEMON_PIDS
				> hg --cwd ../test pull http://localhost:$HGPORT/
				> killdaemons.py hg.pid
				> echo % serve errors
				> cat errors.log
				> }

				expect error, pulling not allowed

				$ req
				pulling from http://localhost:$HGPORT/
				searching for changes
				abort: authorization failed
				% serve errors

				$ cd ..