upstream/mercurial-mirror Files · tests/test-requires.t

sslutil: require TLS 1.1+ when supported...

sslutil: require TLS 1.1+ when supported Currently, Mercurial will use TLS 1.0 or newer when connecting to remote servers, selecting the highest TLS version supported by both peers. On older Pythons, only TLS 1.0 is available. On newer Pythons, TLS 1.1 and 1.2 should be available. Security professionals recommend avoiding TLS 1.0 if possible. PCI DSS 3.1 "strongly encourages" the use of TLS 1.2. Known attacks like BEAST and POODLE exist against TLS 1.0 (although mitigations are available and properly configured servers aren't vulnerable). I asked Eric Rescorla - Mozilla's resident crypto expert - whether Mercurial should drop support for TLS 1.0. His response was "if you can get away with it." Essentially, a number of servers on the Internet don't support TLS 1.1+. This is why web browsers continue to support TLS 1.0 despite desires from security experts. This patch changes Mercurial's default behavior on modern Python versions to require TLS 1.1+, thus avoiding known security issues with TLS 1.0 and making Mercurial more secure by default. Rather than drop TLS 1.0 support wholesale, we still allow TLS 1.0 to be used if configured. This is a compromise solution - ideally we'd disallow TLS 1.0. However, since we're not sure how many Mercurial servers don't support TLS 1.1+ and we're not sure how much user inconvenience this change will bring, I think it is prudent to ship an escape hatch that still allows usage of TLS 1.0. In the default case our users get better security. In the worst case, they are no worse off than before this patch. This patch has no effect when running on Python versions that don't support TLS 1.1+. As the added test shows, connecting to a server that doesn't support TLS 1.1+ will display a warning message with a link to our wiki, where we can guide people to configure their client to allow less secure connections.

Matt Mackall - - Load All Authors

File last commit:

r26421:4b0fc75f default


                r29560:303e9300

default

Download file

             test-requires.t
        
                    72 lines
            
             | 2.2 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-requires.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init t

        $ cd t

        $ echo a > a

        $ hg add a

        $ hg commit -m test

        $ rm .hg/requires

        $ hg tip

        abort: index 00changelog.i unknown format 2!

        [255]

        $ echo indoor-pool > .hg/requires

        $ hg tip

        abort: repository requires features unknown to this Mercurial: indoor-pool!

        (see https://mercurial-scm.org/wiki/MissingRequirement for more information)

        [255]

        $ echo outdoor-pool >> .hg/requires

        $ hg tip

        abort: repository requires features unknown to this Mercurial: indoor-pool outdoor-pool!

        (see https://mercurial-scm.org/wiki/MissingRequirement for more information)

        [255]

        $ cd ..

      Test checking between features supported locally and ones required in

      another repository of push/pull/clone on localhost:

        $ mkdir supported-locally

        $ cd supported-locally

        $ hg init supported

        $ echo a > supported/a

        $ hg -R supported commit -Am '#0 at supported'

        adding a

        $ echo 'featuresetup-test' >> supported/.hg/requires

        $ cat > $TESTTMP/supported-locally/supportlocally.py <<EOF

        > from mercurial import localrepo, extensions

        > def featuresetup(ui, supported):

        >     for name, module in extensions.extensions(ui):

        >         if __name__ == module.__name__:

        >             # support specific feature locally

        >             supported |= set(['featuresetup-test'])

        >             return

        > def uisetup(ui):

        >     localrepo.localrepository.featuresetupfuncs.add(featuresetup)

        > EOF

        $ cat > supported/.hg/hgrc <<EOF

        > [extensions]

        > # enable extension locally

        > supportlocally = $TESTTMP/supported-locally/supportlocally.py

        > EOF

        $ hg -R supported status

        $ hg init push-dst

        $ hg -R supported push push-dst

        pushing to push-dst

        abort: required features are not supported in the destination: featuresetup-test

        [255]

        $ hg init pull-src

        $ hg -R pull-src pull supported

        pulling from supported

        abort: required features are not supported in the destination: featuresetup-test

        [255]

        $ hg clone supported clone-dst

        abort: repository requires features unknown to this Mercurial: featuresetup-test!

        (see https://mercurial-scm.org/wiki/MissingRequirement for more information)

        [255]

        $ hg clone --pull supported clone-dst

        abort: required features are not supported in the destination: featuresetup-test

        [255]

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init t
				$ cd t
				$ echo a > a
				$ hg add a
				$ hg commit -m test
				$ rm .hg/requires
				$ hg tip
				abort: index 00changelog.i unknown format 2!
				[255]
				$ echo indoor-pool > .hg/requires
				$ hg tip
				abort: repository requires features unknown to this Mercurial: indoor-pool!
				(see https://mercurial-scm.org/wiki/MissingRequirement for more information)
				[255]
				$ echo outdoor-pool >> .hg/requires
				$ hg tip
				abort: repository requires features unknown to this Mercurial: indoor-pool outdoor-pool!
				(see https://mercurial-scm.org/wiki/MissingRequirement for more information)
				[255]
				$ cd ..

				Test checking between features supported locally and ones required in
				another repository of push/pull/clone on localhost:

				$ mkdir supported-locally
				$ cd supported-locally

				$ hg init supported
				$ echo a > supported/a
				$ hg -R supported commit -Am '#0 at supported'
				adding a

				$ echo 'featuresetup-test' >> supported/.hg/requires
				$ cat > $TESTTMP/supported-locally/supportlocally.py <<EOF
				> from mercurial import localrepo, extensions
				> def featuresetup(ui, supported):
				> for name, module in extensions.extensions(ui):
				> if __name__ == module.__name__:
				> # support specific feature locally
				> supported \|= set(['featuresetup-test'])
				> return
				> def uisetup(ui):
				> localrepo.localrepository.featuresetupfuncs.add(featuresetup)
				> EOF
				$ cat > supported/.hg/hgrc <<EOF
				> [extensions]
				> # enable extension locally
				> supportlocally = $TESTTMP/supported-locally/supportlocally.py
				> EOF
				$ hg -R supported status

				$ hg init push-dst
				$ hg -R supported push push-dst
				pushing to push-dst
				abort: required features are not supported in the destination: featuresetup-test
				[255]

				$ hg init pull-src
				$ hg -R pull-src pull supported
				pulling from supported
				abort: required features are not supported in the destination: featuresetup-test
				[255]

				$ hg clone supported clone-dst
				abort: repository requires features unknown to this Mercurial: featuresetup-test!
				(see https://mercurial-scm.org/wiki/MissingRequirement for more information)
				[255]
				$ hg clone --pull supported clone-dst
				abort: required features are not supported in the destination: featuresetup-test
				[255]

				$ cd ..