upstream/mercurial-mirror Files · tests/test-username-newline.t

context: stop catching RepoLookupError from namespace.singlenode()...

context: stop catching RepoLookupError from namespace.singlenode() As pointed out by Yuya, the RepoLookupError was there for catching errors from repo.branchtip(). However, since (localrepo: add ignoremissing parameter to branchtip, 2014-10-16), that should no longer happen. I think it should now be an error if a namespace raises a RepoLookupError, so we propagate the exception up and and make it easy to fix, rather than trying to interpret the changeid as nodeid prefix and raise a general "unknown revision '...'" error. I also don't think we should catch FilteredLookupError and LookupError from the changelog.rev() call, for the same reason as above: If a namespace returns a node that doesn't exist, we should provide a more helpful exception than "unknown revision '...'". Differential Revision: https://phab.mercurial-scm.org/D3145

Martin von Zweigbergk - - Load All Authors

File last commit:

r33619:5ac845ca stable


                r37409:3198d5a2

default

Download file

             test-username-newline.t
        
                    27 lines
            
             | 525 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-username-newline.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init

        $ touch a

        $ unset HGUSER

        $ echo "[ui]" >> .hg/hgrc

        $ echo "username= foo" >> .hg/hgrc

        $ echo "          bar1" >> .hg/hgrc

        $ hg ci -Am m

        adding a

        abort: username 'foo\nbar1' contains a newline

        [255]

        $ rm .hg/hgrc

        $ HGUSER=`(echo foo; echo bar2)` hg ci -Am m

        adding a

        abort: username 'foo\nbar2' contains a newline

        [255]

        $ hg ci -Am m -u "`(echo foo; echo bar3)`"

        adding a

        transaction abort!

        rollback completed

        abort: username 'foo\nbar3' contains a newline!

        [255]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init
				$ touch a

				$ unset HGUSER
				$ echo "[ui]" >> .hg/hgrc
				$ echo "username= foo" >> .hg/hgrc
				$ echo " bar1" >> .hg/hgrc

				$ hg ci -Am m
				adding a
				abort: username 'foo\nbar1' contains a newline

				[255]
				$ rm .hg/hgrc

				$ HGUSER=`(echo foo; echo bar2)` hg ci -Am m
				adding a
				abort: username 'foo\nbar2' contains a newline

				[255]
				$ hg ci -Am m -u "`(echo foo; echo bar3)`"
				adding a
				transaction abort!
				rollback completed
				abort: username 'foo\nbar3' contains a newline!
				[255]