##// END OF EJS Templates
interfaces: convert the dirstate zope interface to a Protocol class...
interfaces: convert the dirstate zope interface to a Protocol class This is a small trial run for converting the repository interfaces enmasse, in the same series of steps. I'm not sure that this current code is valid (it has zope attribute fields, and it's missing all of the `self` args on its functions, but that was the previous state of things, and made PyCharm really unhappy). But it will be easier to review the repository interface changes if this change is separate from adding `self` and dropping the zope attributes all over. Having an empty constructor in a protocol is weird. I'm not sure if these args should be converted to fields that all subclasses would have, and comments around existing attributes say some should be going away. Comment it out for now so that it's not in the way, but also not forgotten.
Matt Harbison -
r52814:382d9629 default
Show More
Name Size Modified Last Commit Author
/ mercurial / interfaces
__init__.py Loading ...
dirstate.py Loading ...
repository.py Loading ...
util.py Loading ...