upstream/mercurial-mirror Files · mercurial/policy.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

FUJIWARA Katsunori - - Load All Authors

File last commit:

r31361:8a17c541 default


                r32050:77eaf953

4.1.3 stable

Download file

             policy.py
        
                    45 lines
            
             | 1.4 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / policy.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # policy.py - module policy logic for Mercurial.

      #

      # Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      import os

      import sys

      # Rules for how modules can be loaded. Values are:

      #

      #    c - require C extensions

      #    allow - allow pure Python implementation when C loading fails

      #    cffi - required cffi versions (implemented within pure module)

      #    cffi-allow - allow pure Python implementation if cffi version is missing

      #    py - only load pure Python modules

      #

      # By default, require the C extensions for performance reasons.

      policy = 'c'

      policynoc = ('cffi', 'cffi-allow', 'py')

      policynocffi = ('c', 'py')

      try:

          from . import __modulepolicy__

          policy = __modulepolicy__.modulepolicy

      except ImportError:

          pass

      # PyPy doesn't load C extensions.

      #

      # The canonical way to do this is to test platform.python_implementation().

      # But we don't import platform and don't bloat for it here.

      if '__pypy__' in sys.builtin_module_names:

          policy = 'cffi'

      # Our C extensions aren't yet compatible with Python 3. So use pure Python

      # on Python 3 for now.

      if sys.version_info[0] >= 3:

          policy = 'py'

      # Environment variable can always force settings.

      policy = os.environ.get('HGMODULEPOLICY', policy)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# policy.py - module policy logic for Mercurial.
				#
				# Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import absolute_import

				import os
				import sys

				# Rules for how modules can be loaded. Values are:
				#
				# c - require C extensions
				# allow - allow pure Python implementation when C loading fails
				# cffi - required cffi versions (implemented within pure module)
				# cffi-allow - allow pure Python implementation if cffi version is missing
				# py - only load pure Python modules
				#
				# By default, require the C extensions for performance reasons.
				policy = 'c'
				policynoc = ('cffi', 'cffi-allow', 'py')
				policynocffi = ('c', 'py')

				try:
				from . import __modulepolicy__
				policy = __modulepolicy__.modulepolicy
				except ImportError:
				pass

				# PyPy doesn't load C extensions.
				#
				# The canonical way to do this is to test platform.python_implementation().
				# But we don't import platform and don't bloat for it here.
				if '__pypy__' in sys.builtin_module_names:
				policy = 'cffi'

				# Our C extensions aren't yet compatible with Python 3. So use pure Python
				# on Python 3 for now.
				if sys.version_info[0] >= 3:
				policy = 'py'

				# Environment variable can always force settings.
				policy = os.environ.get('HGMODULEPOLICY', policy)