upstream/mercurial-mirror Files · mercurial/scmposix.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Pulkit Goyal - - Load All Authors

File last commit:

r31339:7c09b071 default


                r32050:77eaf953

4.1.3 stable

Download file

             scmposix.py
        
                    72 lines
            
             | 1.8 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / scmposix.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import absolute_import

      import array

      import errno

      import fcntl

      import os

      import sys

      from . import (

          encoding,

          osutil,

          pycompat,

      )

      def _rcfiles(path):

          rcs = [os.path.join(path, 'hgrc')]

          rcdir = os.path.join(path, 'hgrc.d')

          try:

              rcs.extend([os.path.join(rcdir, f)

                          for f, kind in osutil.listdir(rcdir)

                          if f.endswith(".rc")])

          except OSError:

              pass

          return rcs

      def systemrcpath():

          path = []

          if pycompat.sysplatform == 'plan9':

              root = 'lib/mercurial'

          else:

              root = 'etc/mercurial'

          # old mod_python does not set sys.argv

          if len(getattr(sys, 'argv', [])) > 0:

              p = os.path.dirname(os.path.dirname(pycompat.sysargv[0]))

              if p != '/':

                  path.extend(_rcfiles(os.path.join(p, root)))

          path.extend(_rcfiles('/' + root))

          return path

      def userrcpath():

          if pycompat.sysplatform == 'plan9':

              return [encoding.environ['home'] + '/lib/hgrc']

          else:

              return [os.path.expanduser('~/.hgrc')]

      def termsize(ui):

          try:

              import termios

              TIOCGWINSZ = termios.TIOCGWINSZ  # unavailable on IRIX (issue3449)

          except (AttributeError, ImportError):

              return 80, 24

          for dev in (ui.ferr, ui.fout, ui.fin):

              try:

                  try:

                      fd = dev.fileno()

                  except AttributeError:

                      continue

                  if not os.isatty(fd):

                      continue

                  arri = fcntl.ioctl(fd, TIOCGWINSZ, '\0' * 8)

                  height, width = array.array('h', arri)[:2]

                  if width > 0 and height > 0:

                      return width, height

              except ValueError:

                  pass

              except IOError as e:

                  if e[0] == errno.EINVAL:

                      pass

                  else:

                      raise

          return 80, 24

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import absolute_import

				import array
				import errno
				import fcntl
				import os
				import sys

				from . import (
				encoding,
				osutil,
				pycompat,
				)

				def _rcfiles(path):
				rcs = [os.path.join(path, 'hgrc')]
				rcdir = os.path.join(path, 'hgrc.d')
				try:
				rcs.extend([os.path.join(rcdir, f)
				for f, kind in osutil.listdir(rcdir)
				if f.endswith(".rc")])
				except OSError:
				pass
				return rcs

				def systemrcpath():
				path = []
				if pycompat.sysplatform == 'plan9':
				root = 'lib/mercurial'
				else:
				root = 'etc/mercurial'
				# old mod_python does not set sys.argv
				if len(getattr(sys, 'argv', [])) > 0:
				p = os.path.dirname(os.path.dirname(pycompat.sysargv[0]))
				if p != '/':
				path.extend(_rcfiles(os.path.join(p, root)))
				path.extend(_rcfiles('/' + root))
				return path

				def userrcpath():
				if pycompat.sysplatform == 'plan9':
				return [encoding.environ['home'] + '/lib/hgrc']
				else:
				return [os.path.expanduser('~/.hgrc')]

				def termsize(ui):
				try:
				import termios
				TIOCGWINSZ = termios.TIOCGWINSZ # unavailable on IRIX (issue3449)
				except (AttributeError, ImportError):
				return 80, 24

				for dev in (ui.ferr, ui.fout, ui.fin):
				try:
				try:
				fd = dev.fileno()
				except AttributeError:
				continue
				if not os.isatty(fd):
				continue
				arri = fcntl.ioctl(fd, TIOCGWINSZ, '\0' * 8)
				height, width = array.array('h', arri)[:2]
				if width > 0 and height > 0:
				return width, height
				except ValueError:
				pass
				except IOError as e:
				if e[0] == errno.EINVAL:
				pass
				else:
				raise
				return 80, 24