upstream/mercurial-mirror Files · tests/autodiff.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Gregory Szorc - - Load All Authors

File last commit:

r27281:3b517f2a default


                r32050:77eaf953

4.1.3 stable

Download file

             autodiff.py
        
                    50 lines
            
             | 1.4 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / autodiff.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Extension dedicated to test patch.diff() upgrade modes

      from __future__ import absolute_import

      from mercurial import (

          cmdutil,

          error,

          patch,

          scmutil,

      )

      cmdtable = {}

      command = cmdutil.command(cmdtable)

      @command('autodiff',

          [('', 'git', '', 'git upgrade mode (yes/no/auto/warn/abort)')],

          '[OPTION]... [FILE]...')

      def autodiff(ui, repo, *pats, **opts):

          diffopts = patch.difffeatureopts(ui, opts)

          git = opts.get('git', 'no')

          brokenfiles = set()

          losedatafn = None

          if git in ('yes', 'no'):

              diffopts.git = git == 'yes'

              diffopts.upgrade = False

          elif git == 'auto':

              diffopts.git = False

              diffopts.upgrade = True

          elif git == 'warn':

              diffopts.git = False

              diffopts.upgrade = True

              def losedatafn(fn=None, **kwargs):

                  brokenfiles.add(fn)

                  return True

          elif git == 'abort':

              diffopts.git = False

              diffopts.upgrade = True

              def losedatafn(fn=None, **kwargs):

                  raise error.Abort('losing data for %s' % fn)

          else:

              raise error.Abort('--git must be yes, no or auto')

          node1, node2 = scmutil.revpair(repo, [])

          m = scmutil.match(repo[node2], pats, opts)

          it = patch.diff(repo, node1, node2, match=m, opts=diffopts,

                          losedatafn=losedatafn)

          for chunk in it:

              ui.write(chunk)

          for fn in sorted(brokenfiles):

              ui.write(('data lost for: %s\n' % fn))

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Extension dedicated to test patch.diff() upgrade modes

				from __future__ import absolute_import

				from mercurial import (
				cmdutil,
				error,
				patch,
				scmutil,
				)

				cmdtable = {}
				command = cmdutil.command(cmdtable)

				@command('autodiff',
				[('', 'git', '', 'git upgrade mode (yes/no/auto/warn/abort)')],
				'[OPTION]... [FILE]...')
				def autodiff(ui, repo, pats, *opts):
				diffopts = patch.difffeatureopts(ui, opts)
				git = opts.get('git', 'no')
				brokenfiles = set()
				losedatafn = None
				if git in ('yes', 'no'):
				diffopts.git = git == 'yes'
				diffopts.upgrade = False
				elif git == 'auto':
				diffopts.git = False
				diffopts.upgrade = True
				elif git == 'warn':
				diffopts.git = False
				diffopts.upgrade = True
				def losedatafn(fn=None, **kwargs):
				brokenfiles.add(fn)
				return True
				elif git == 'abort':
				diffopts.git = False
				diffopts.upgrade = True
				def losedatafn(fn=None, **kwargs):
				raise error.Abort('losing data for %s' % fn)
				else:
				raise error.Abort('--git must be yes, no or auto')

				node1, node2 = scmutil.revpair(repo, [])
				m = scmutil.match(repo[node2], pats, opts)
				it = patch.diff(repo, node1, node2, match=m, opts=diffopts,
				losedatafn=losedatafn)
				for chunk in it:
				ui.write(chunk)
				for fn in sorted(brokenfiles):
				ui.write(('data lost for: %s\n' % fn))