upstream/mercurial-mirror Files · tests/test-flagprocessor.t

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Jun Wu - - Load All Authors

File last commit:

r31856:0ab7f469 default


                r32050:77eaf953

4.1.3 stable

Download file

             test-flagprocessor.t
        
                    165 lines
            
             | 4.1 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-flagprocessor.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Create server

        $ hg init server

        $ cd server

        $ cat >> .hg/hgrc << EOF

        > [extensions]

        > extension=$TESTDIR/flagprocessorext.py

        > EOF

        $ cd ../

      # Clone server and enable extensions

        $ hg clone -q server client

        $ cd client

        $ cat >> .hg/hgrc << EOF

        > [extensions]

        > extension=$TESTDIR/flagprocessorext.py

        > EOF

      # Commit file that will trigger the noop extension

        $ echo '[NOOP]' > noop

        $ hg commit -Aqm "noop"

      # Commit file that will trigger the base64 extension

        $ echo '[BASE64]' > base64

        $ hg commit -Aqm 'base64'

      # Commit file that will trigger the gzip extension

        $ echo '[GZIP]' > gzip

        $ hg commit -Aqm 'gzip'

      # Commit file that will trigger noop and base64

        $ echo '[NOOP][BASE64]' > noop-base64

        $ hg commit -Aqm 'noop+base64'

      # Commit file that will trigger noop and gzip

        $ echo '[NOOP][GZIP]' > noop-gzip

        $ hg commit -Aqm 'noop+gzip'

      # Commit file that will trigger base64 and gzip

        $ echo '[BASE64][GZIP]' > base64-gzip

        $ hg commit -Aqm 'base64+gzip'

      # Commit file that will trigger base64, gzip and noop

        $ echo '[BASE64][GZIP][NOOP]' > base64-gzip-noop

        $ hg commit -Aqm 'base64+gzip+noop'

      # TEST: ensure the revision data is consistent

        $ hg cat noop

        [NOOP]

        $ hg debugdata noop 0

        [NOOP]

        $ hg cat -r . base64

        [BASE64]

        $ hg debugdata base64 0

        W0JBU0U2NF0K (no-eol)

        $ hg cat -r . gzip

        [GZIP]

        $ hg debugdata gzip 0

        x\x9c\x8bv\x8f\xf2\x0c\x88\xe5\x02\x00\x08\xc8\x01\xfd (no-eol) (esc)

        $ hg cat -r . noop-base64

        [NOOP][BASE64]

        $ hg debugdata noop-base64 0

        W05PT1BdW0JBU0U2NF0K (no-eol)

        $ hg cat -r . noop-gzip

        [NOOP][GZIP]

        $ hg debugdata noop-gzip 0

        x\x9c\x8b\xf6\xf3\xf7\x0f\x88\x8dv\x8f\xf2\x0c\x88\xe5\x02\x00\x1dH\x03\xf1 (no-eol) (esc)

        $ hg cat -r . base64-gzip

        [BASE64][GZIP]

        $ hg debugdata base64-gzip 0

        eJyLdnIMdjUziY12j/IMiOUCACLBBDo= (no-eol)

        $ hg cat -r . base64-gzip-noop

        [BASE64][GZIP][NOOP]

        $ hg debugdata base64-gzip-noop 0

        eJyLdnIMdjUziY12j/IMiI328/cPiOUCAESjBi4= (no-eol)

      # Push to the server

        $ hg push

        pushing to $TESTTMP/server (glob)

        searching for changes

        adding changesets

        adding manifests

        adding file changes

        added 7 changesets with 7 changes to 7 files

      # Initialize new client (not cloning) and setup extension

        $ cd ..

        $ hg init client2

        $ cd client2

        $ cat >> .hg/hgrc << EOF

        > [paths]

        > default = $TESTTMP/server

        > [extensions]

        > extension=$TESTDIR/flagprocessorext.py

        > EOF

      # Pull from server and update to latest revision

        $ hg pull default

        pulling from $TESTTMP/server (glob)

        requesting all changes

        adding changesets

        adding manifests

        adding file changes

        added 7 changesets with 7 changes to 7 files

        (run 'hg update' to get a working copy)

        $ hg update

        7 files updated, 0 files merged, 0 files removed, 0 files unresolved

      # TEST: ensure the revision data is consistent

        $ hg cat noop

        [NOOP]

        $ hg debugdata noop 0

        [NOOP]

        $ hg cat -r . base64

        [BASE64]

        $ hg debugdata base64 0

        W0JBU0U2NF0K (no-eol)

        $ hg cat -r . gzip

        [GZIP]

        $ hg debugdata gzip 0

        x\x9c\x8bv\x8f\xf2\x0c\x88\xe5\x02\x00\x08\xc8\x01\xfd (no-eol) (esc)

        $ hg cat -r . noop-base64

        [NOOP][BASE64]

        $ hg debugdata noop-base64 0

        W05PT1BdW0JBU0U2NF0K (no-eol)

        $ hg cat -r . noop-gzip

        [NOOP][GZIP]

        $ hg debugdata noop-gzip 0

        x\x9c\x8b\xf6\xf3\xf7\x0f\x88\x8dv\x8f\xf2\x0c\x88\xe5\x02\x00\x1dH\x03\xf1 (no-eol) (esc)

        $ hg cat -r . base64-gzip

        [BASE64][GZIP]

        $ hg debugdata base64-gzip 0

        eJyLdnIMdjUziY12j/IMiOUCACLBBDo= (no-eol)

        $ hg cat -r . base64-gzip-noop

        [BASE64][GZIP][NOOP]

        $ hg debugdata base64-gzip-noop 0

        eJyLdnIMdjUziY12j/IMiI328/cPiOUCAESjBi4= (no-eol)

      # TEST: ensure a missing processor is handled

        $ echo '[FAIL][BASE64][GZIP][NOOP]' > fail-base64-gzip-noop

        $ hg commit -Aqm 'fail+base64+gzip+noop'

        abort: missing processor for flag '0x1'!

        [255]

      # TEST: ensure we cannot register several flag processors on the same flag

        $ cat >> .hg/hgrc << EOF

        > [extensions]

        > extension=$TESTDIR/flagprocessorext.py

        > duplicate=$TESTDIR/flagprocessorext.py

        > EOF

        $ echo 'this should fail' > file

        $ hg commit -Aqm 'add file'

        abort: cannot register multiple processors on flag '0x8'.

        [255]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Create server
				$ hg init server
				$ cd server
				$ cat >> .hg/hgrc << EOF
				> [extensions]
				> extension=$TESTDIR/flagprocessorext.py
				> EOF
				$ cd ../

				# Clone server and enable extensions
				$ hg clone -q server client
				$ cd client
				$ cat >> .hg/hgrc << EOF
				> [extensions]
				> extension=$TESTDIR/flagprocessorext.py
				> EOF

				# Commit file that will trigger the noop extension
				$ echo '[NOOP]' > noop
				$ hg commit -Aqm "noop"

				# Commit file that will trigger the base64 extension
				$ echo '[BASE64]' > base64
				$ hg commit -Aqm 'base64'

				# Commit file that will trigger the gzip extension
				$ echo '[GZIP]' > gzip
				$ hg commit -Aqm 'gzip'

				# Commit file that will trigger noop and base64
				$ echo '[NOOP][BASE64]' > noop-base64
				$ hg commit -Aqm 'noop+base64'

				# Commit file that will trigger noop and gzip
				$ echo '[NOOP][GZIP]' > noop-gzip
				$ hg commit -Aqm 'noop+gzip'

				# Commit file that will trigger base64 and gzip
				$ echo '[BASE64][GZIP]' > base64-gzip
				$ hg commit -Aqm 'base64+gzip'

				# Commit file that will trigger base64, gzip and noop
				$ echo '[BASE64][GZIP][NOOP]' > base64-gzip-noop
				$ hg commit -Aqm 'base64+gzip+noop'

				# TEST: ensure the revision data is consistent
				$ hg cat noop
				[NOOP]
				$ hg debugdata noop 0
				[NOOP]

				$ hg cat -r . base64
				[BASE64]
				$ hg debugdata base64 0
				W0JBU0U2NF0K (no-eol)

				$ hg cat -r . gzip
				[GZIP]
				$ hg debugdata gzip 0
				x\x9c\x8bv\x8f\xf2\x0c\x88\xe5\x02\x00\x08\xc8\x01\xfd (no-eol) (esc)

				$ hg cat -r . noop-base64
				[NOOP][BASE64]
				$ hg debugdata noop-base64 0
				W05PT1BdW0JBU0U2NF0K (no-eol)

				$ hg cat -r . noop-gzip
				[NOOP][GZIP]
				$ hg debugdata noop-gzip 0
				x\x9c\x8b\xf6\xf3\xf7\x0f\x88\x8dv\x8f\xf2\x0c\x88\xe5\x02\x00\x1dH\x03\xf1 (no-eol) (esc)

				$ hg cat -r . base64-gzip
				[BASE64][GZIP]
				$ hg debugdata base64-gzip 0
				eJyLdnIMdjUziY12j/IMiOUCACLBBDo= (no-eol)

				$ hg cat -r . base64-gzip-noop
				[BASE64][GZIP][NOOP]
				$ hg debugdata base64-gzip-noop 0
				eJyLdnIMdjUziY12j/IMiI328/cPiOUCAESjBi4= (no-eol)

				# Push to the server
				$ hg push
				pushing to $TESTTMP/server (glob)
				searching for changes
				adding changesets
				adding manifests
				adding file changes
				added 7 changesets with 7 changes to 7 files

				# Initialize new client (not cloning) and setup extension
				$ cd ..
				$ hg init client2
				$ cd client2
				$ cat >> .hg/hgrc << EOF
				> [paths]
				> default = $TESTTMP/server
				> [extensions]
				> extension=$TESTDIR/flagprocessorext.py
				> EOF

				# Pull from server and update to latest revision
				$ hg pull default
				pulling from $TESTTMP/server (glob)
				requesting all changes
				adding changesets
				adding manifests
				adding file changes
				added 7 changesets with 7 changes to 7 files
				(run 'hg update' to get a working copy)
				$ hg update
				7 files updated, 0 files merged, 0 files removed, 0 files unresolved

				# TEST: ensure the revision data is consistent
				$ hg cat noop
				[NOOP]
				$ hg debugdata noop 0
				[NOOP]

				$ hg cat -r . base64
				[BASE64]
				$ hg debugdata base64 0
				W0JBU0U2NF0K (no-eol)

				$ hg cat -r . gzip
				[GZIP]
				$ hg debugdata gzip 0
				x\x9c\x8bv\x8f\xf2\x0c\x88\xe5\x02\x00\x08\xc8\x01\xfd (no-eol) (esc)

				$ hg cat -r . noop-base64
				[NOOP][BASE64]
				$ hg debugdata noop-base64 0
				W05PT1BdW0JBU0U2NF0K (no-eol)

				$ hg cat -r . noop-gzip
				[NOOP][GZIP]
				$ hg debugdata noop-gzip 0
				x\x9c\x8b\xf6\xf3\xf7\x0f\x88\x8dv\x8f\xf2\x0c\x88\xe5\x02\x00\x1dH\x03\xf1 (no-eol) (esc)

				$ hg cat -r . base64-gzip
				[BASE64][GZIP]
				$ hg debugdata base64-gzip 0
				eJyLdnIMdjUziY12j/IMiOUCACLBBDo= (no-eol)

				$ hg cat -r . base64-gzip-noop
				[BASE64][GZIP][NOOP]
				$ hg debugdata base64-gzip-noop 0
				eJyLdnIMdjUziY12j/IMiI328/cPiOUCAESjBi4= (no-eol)

				# TEST: ensure a missing processor is handled
				$ echo '[FAIL][BASE64][GZIP][NOOP]' > fail-base64-gzip-noop
				$ hg commit -Aqm 'fail+base64+gzip+noop'
				abort: missing processor for flag '0x1'!
				[255]

				# TEST: ensure we cannot register several flag processors on the same flag
				$ cat >> .hg/hgrc << EOF
				> [extensions]
				> extension=$TESTDIR/flagprocessorext.py
				> duplicate=$TESTDIR/flagprocessorext.py
				> EOF
				$ echo 'this should fail' > file
				$ hg commit -Aqm 'add file'
				abort: cannot register multiple processors on flag '0x8'.
				[255]