upstream/mercurial-mirror Files · tests/test-issue1802.t

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Pierre-Yves David - - Load All Authors

File last commit:

r25125:bd625cd4 default


                r32050:77eaf953

4.1.3 stable

Download file

             test-issue1802.t
        
                    72 lines
            
             | 1.6 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-issue1802.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require execbit

      Create extension that can disable exec checks:

        $ cat > noexec.py <<EOF

        > from mercurial import extensions, util

        > def setflags(orig, f, l, x):

        >     pass

        > def checkexec(orig, path):

        >     return False

        > def extsetup(ui):

        >     extensions.wrapfunction(util, 'setflags', setflags)

        >     extensions.wrapfunction(util, 'checkexec', checkexec)

        > EOF

        $ hg init unix-repo

        $ cd unix-repo

        $ touch a

        $ hg add a

        $ hg commit -m 'unix: add a'

        $ hg clone . ../win-repo

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ chmod +x a

        $ hg commit -m 'unix: chmod a'

        $ hg manifest -v

        755 * a

        $ cd ../win-repo

        $ touch b

        $ hg add b

        $ hg commit -m 'win: add b'

        $ hg manifest -v

        644   a

        644   b

        $ hg pull

        pulling from $TESTTMP/unix-repo

        searching for changes

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 0 changes to 0 files (+1 heads)

        (run 'hg heads' to see heads, 'hg merge' to merge)

        $ hg manifest -v -r tip

        755 * a

      Simulate a Windows merge:

        $ hg --config extensions.n=$TESTTMP/noexec.py merge --debug

          searching for copies back to rev 1

          unmatched files in local:

           b

        resolving manifests

         branchmerge: True, force: False, partial: False

         ancestor: a03b0deabf2b, local: d6fa54f68ae1+, remote: 2d8bcf2dda39

         a: update permissions -> e

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        (branch merge, don't forget to commit)

      Simulate a Windows commit:

        $ hg --config extensions.n=$TESTTMP/noexec.py commit -m 'win: merge'

        $ hg manifest -v

        755 * a

        644   b

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require execbit

				Create extension that can disable exec checks:

				$ cat > noexec.py <<EOF
				> from mercurial import extensions, util
				> def setflags(orig, f, l, x):
				> pass
				> def checkexec(orig, path):
				> return False
				> def extsetup(ui):
				> extensions.wrapfunction(util, 'setflags', setflags)
				> extensions.wrapfunction(util, 'checkexec', checkexec)
				> EOF

				$ hg init unix-repo
				$ cd unix-repo
				$ touch a
				$ hg add a
				$ hg commit -m 'unix: add a'
				$ hg clone . ../win-repo
				updating to branch default
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ chmod +x a
				$ hg commit -m 'unix: chmod a'
				$ hg manifest -v
				755 * a

				$ cd ../win-repo

				$ touch b
				$ hg add b
				$ hg commit -m 'win: add b'

				$ hg manifest -v
				644 a
				644 b

				$ hg pull
				pulling from $TESTTMP/unix-repo
				searching for changes
				adding changesets
				adding manifests
				adding file changes
				added 1 changesets with 0 changes to 0 files (+1 heads)
				(run 'hg heads' to see heads, 'hg merge' to merge)

				$ hg manifest -v -r tip
				755 * a

				Simulate a Windows merge:

				$ hg --config extensions.n=$TESTTMP/noexec.py merge --debug
				searching for copies back to rev 1
				unmatched files in local:
				b
				resolving manifests
				branchmerge: True, force: False, partial: False
				ancestor: a03b0deabf2b, local: d6fa54f68ae1+, remote: 2d8bcf2dda39
				a: update permissions -> e
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				(branch merge, don't forget to commit)

				Simulate a Windows commit:

				$ hg --config extensions.n=$TESTTMP/noexec.py commit -m 'win: merge'

				$ hg manifest -v
				755 * a
				644 b

				$ cd ..