upstream/mercurial-mirror Files · tests/test-newcgi.t

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Matt Mackall - - Load All Authors

File last commit:

r22046:7a9cbb31 default


                r32050:77eaf953

4.1.3 stable

Download file

             test-newcgi.t
        
                    66 lines
            
             | 1.7 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-newcgi.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require no-msys # MSYS will translate web paths as if they were file paths

      This tests if CGI files from after d0db3462d568 but

      before d74fc8dec2b4 still work.

        $ hg init test

        $ cat >hgweb.cgi <<HGWEB

        > #!/usr/bin/env python

        > #

        > # An example CGI script to use hgweb, edit as necessary

        > 

        > import cgitb

        > cgitb.enable()

        > 

        > from mercurial import demandimport; demandimport.enable()

        > from mercurial.hgweb import hgweb

        > from mercurial.hgweb import wsgicgi

        > from mercurial.hgweb.request import wsgiapplication

        > 

        > def make_web_app():

        >     return hgweb("test", "Empty test repository")

        > 

        > wsgicgi.launch(wsgiapplication(make_web_app))

        > HGWEB

        $ chmod 755 hgweb.cgi

        $ cat >hgweb.config <<HGWEBDIRCONF

        > [paths]

        > test = test

        > HGWEBDIRCONF

        $ cat >hgwebdir.cgi <<HGWEBDIR

        > #!/usr/bin/env python

        > #

        > # An example CGI script to export multiple hgweb repos, edit as necessary

        > 

        > import cgitb

        > cgitb.enable()

        > 

        > from mercurial import demandimport; demandimport.enable()

        > from mercurial.hgweb import hgwebdir

        > from mercurial.hgweb import wsgicgi

        > from mercurial.hgweb.request import wsgiapplication

        > 

        > def make_web_app():

        >     return hgwebdir("hgweb.config")

        > 

        > wsgicgi.launch(wsgiapplication(make_web_app))

        > HGWEBDIR

        $ chmod 755 hgwebdir.cgi

        $ . "$TESTDIR/cgienv"

        $ python hgweb.cgi > page1

        $ python hgwebdir.cgi > page2

        $ PATH_INFO="/test/"

        $ PATH_TRANSLATED="/var/something/test.cgi"

        $ REQUEST_URI="/test/test/"

        $ SCRIPT_URI="http://hg.omnifarious.org/test/test/"

        $ SCRIPT_URL="/test/test/"

        $ python hgwebdir.cgi > page3

        $ grep -i error page1 page2 page3

        [1]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require no-msys # MSYS will translate web paths as if they were file paths

				This tests if CGI files from after d0db3462d568 but
				before d74fc8dec2b4 still work.

				$ hg init test
				$ cat >hgweb.cgi <<HGWEB
				> #!/usr/bin/env python
				> #
				> # An example CGI script to use hgweb, edit as necessary
				>
				> import cgitb
				> cgitb.enable()
				>
				> from mercurial import demandimport; demandimport.enable()
				> from mercurial.hgweb import hgweb
				> from mercurial.hgweb import wsgicgi
				> from mercurial.hgweb.request import wsgiapplication
				>
				> def make_web_app():
				> return hgweb("test", "Empty test repository")
				>
				> wsgicgi.launch(wsgiapplication(make_web_app))
				> HGWEB

				$ chmod 755 hgweb.cgi

				$ cat >hgweb.config <<HGWEBDIRCONF
				> [paths]
				> test = test
				> HGWEBDIRCONF

				$ cat >hgwebdir.cgi <<HGWEBDIR
				> #!/usr/bin/env python
				> #
				> # An example CGI script to export multiple hgweb repos, edit as necessary
				>
				> import cgitb
				> cgitb.enable()
				>
				> from mercurial import demandimport; demandimport.enable()
				> from mercurial.hgweb import hgwebdir
				> from mercurial.hgweb import wsgicgi
				> from mercurial.hgweb.request import wsgiapplication
				>
				> def make_web_app():
				> return hgwebdir("hgweb.config")
				>
				> wsgicgi.launch(wsgiapplication(make_web_app))
				> HGWEBDIR

				$ chmod 755 hgwebdir.cgi

				$ . "$TESTDIR/cgienv"
				$ python hgweb.cgi > page1
				$ python hgwebdir.cgi > page2

				$ PATH_INFO="/test/"
				$ PATH_TRANSLATED="/var/something/test.cgi"
				$ REQUEST_URI="/test/test/"
				$ SCRIPT_URI="http://hg.omnifarious.org/test/test/"
				$ SCRIPT_URL="/test/test/"
				$ python hgwebdir.cgi > page3

				$ grep -i error page1 page2 page3
				[1]