upstream/mercurial-mirror Files · tests/test-symlink-os-yes-fs-no.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Yuya Nishihara - - Load All Authors

File last commit:

r30559:d83ca854 default


                r32050:77eaf953

4.1.3 stable

Download file

             test-symlink-os-yes-fs-no.py
        
                    57 lines
            
             | 1.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-symlink-os-yes-fs-no.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import absolute_import

      import os

      import sys

      import time

      from mercurial import (

          commands,

          hg,

          ui as uimod,

          util,

      )

      TESTDIR = os.environ["TESTDIR"]

      BUNDLEPATH = os.path.join(TESTDIR, 'bundles', 'test-no-symlinks.hg')

      # only makes sense to test on os which supports symlinks

      if not getattr(os, "symlink", False):

          sys.exit(80) # SKIPPED_STATUS defined in run-tests.py

      u = uimod.ui.load()

      # hide outer repo

      hg.peer(u, {}, '.', create=True)

      # clone with symlink support

      hg.clone(u, {}, BUNDLEPATH, 'test0')

      repo = hg.repository(u, 'test0')

      # wait a bit, or the status call wont update the dirstate

      time.sleep(1)

      commands.status(u, repo)

      # now disable symlink support -- this is what os.symlink would do on a

      # non-symlink file system

      def symlink_failure(src, dst):

          raise OSError(1, "Operation not permitted")

      os.symlink = symlink_failure

      def islink_failure(path):

          return False

      os.path.islink = islink_failure

      # dereference links as if a Samba server has exported this to a

      # Windows client

      for f in 'test0/a.lnk', 'test0/d/b.lnk':

          os.unlink(f)

          fp = open(f, 'wb')

          fp.write(util.readfile(f[:-4]))

          fp.close()

      # reload repository

      u = uimod.ui.load()

      repo = hg.repository(u, 'test0')

      commands.status(u, repo)

      # try cloning a repo which contains symlinks

      u = uimod.ui.load()

      hg.clone(u, {}, BUNDLEPATH, 'test1')

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import absolute_import

				import os
				import sys
				import time
				from mercurial import (
				commands,
				hg,
				ui as uimod,
				util,
				)

				TESTDIR = os.environ["TESTDIR"]
				BUNDLEPATH = os.path.join(TESTDIR, 'bundles', 'test-no-symlinks.hg')

				# only makes sense to test on os which supports symlinks
				if not getattr(os, "symlink", False):
				sys.exit(80) # SKIPPED_STATUS defined in run-tests.py

				u = uimod.ui.load()
				# hide outer repo
				hg.peer(u, {}, '.', create=True)

				# clone with symlink support
				hg.clone(u, {}, BUNDLEPATH, 'test0')

				repo = hg.repository(u, 'test0')

				# wait a bit, or the status call wont update the dirstate
				time.sleep(1)
				commands.status(u, repo)

				# now disable symlink support -- this is what os.symlink would do on a
				# non-symlink file system
				def symlink_failure(src, dst):
				raise OSError(1, "Operation not permitted")
				os.symlink = symlink_failure
				def islink_failure(path):
				return False
				os.path.islink = islink_failure

				# dereference links as if a Samba server has exported this to a
				# Windows client
				for f in 'test0/a.lnk', 'test0/d/b.lnk':
				os.unlink(f)
				fp = open(f, 'wb')
				fp.write(util.readfile(f[:-4]))
				fp.close()

				# reload repository
				u = uimod.ui.load()
				repo = hg.repository(u, 'test0')
				commands.status(u, repo)

				# try cloning a repo which contains symlinks
				u = uimod.ui.load()
				hg.clone(u, {}, BUNDLEPATH, 'test1')