upstream/mercurial-mirror Files · hgext/hooklib/enforce_draft_commits.py

typing: hide the interface version of `dirstate` during type checking...

typing: hide the interface version of `dirstate` during type checking As noted in the previous commit, the `dirstate` type is still inferred as `Any` by pytype, including where it is used as a base class for the largefiles dirstate. That effectively disables most type checking. The problems fixed two commits ago were flagged by this change. I'm not at all clear what the benefit of the original type is, but that was what was used at runtime, so I don't want to change the largefiles base class to the raw class. Having both a lowercase and camelcase name for the same thing isn't great, but given that this trivially finds problems without worrying about which symbol clients may be using, and the non-raw type is useless to pytype anyway, I'm not going to worry about it.

Gregory Szorc - - Load All Authors

File last commit:

r49730:6000f5b2 default


                r52702:45270e28

default

Download file

             enforce_draft_commits.py
        
                    44 lines
            
             | 1.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / hooklib / enforce_draft_commits.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Copyright 2020 Joerg Sonnenberger <joerg@bec.de>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      """enforce_draft_commits us a hook to ensure that all new changesets are

      in the draft phase. This allows enforcing policies for work-in-progress

      changes in overlay repositories, i.e. a shared hidden repositories with

      different views for work-in-progress code and public history.

      Usage:

        [hooks]

        pretxnclose-phase.enforce_draft_commits = \

          python:hgext.hooklib.enforce_draft_commits.hook

      """

      from mercurial.i18n import _

      from mercurial import (

          error,

          pycompat,

      )

      def hook(ui, repo, hooktype, node=None, **kwargs):

          if hooktype != b"pretxnclose-phase":

              raise error.Abort(

                  _(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)

              )

          ctx = repo.unfiltered()[node]

          if kwargs['oldphase']:

              raise error.Abort(

                  _(b'Phase change from %r to %r for %s rejected')

                  % (

                      pycompat.bytestr(kwargs['oldphase']),

                      pycompat.bytestr(kwargs['phase']),

                      ctx,

                  )

              )

          elif kwargs['phase'] != b'draft':

              raise error.Abort(

                  _(b'New changeset %s in phase %r rejected')

                  % (ctx, pycompat.bytestr(kwargs['phase']))

              )

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Copyright 2020 Joerg Sonnenberger <joerg@bec.de>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				"""enforce_draft_commits us a hook to ensure that all new changesets are
				in the draft phase. This allows enforcing policies for work-in-progress
				changes in overlay repositories, i.e. a shared hidden repositories with
				different views for work-in-progress code and public history.

				Usage:
				[hooks]
				pretxnclose-phase.enforce_draft_commits = \
				python:hgext.hooklib.enforce_draft_commits.hook
				"""


				from mercurial.i18n import _
				from mercurial import (
				error,
				pycompat,
				)


				def hook(ui, repo, hooktype, node=None, **kwargs):
				if hooktype != b"pretxnclose-phase":
				raise error.Abort(
				_(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)
				)
				ctx = repo.unfiltered()[node]
				if kwargs['oldphase']:
				raise error.Abort(
				_(b'Phase change from %r to %r for %s rejected')
				% (
				pycompat.bytestr(kwargs['oldphase']),
				pycompat.bytestr(kwargs['phase']),
				ctx,
				)
				)
				elif kwargs['phase'] != b'draft':
				raise error.Abort(
				_(b'New changeset %s in phase %r rejected')
				% (ctx, pycompat.bytestr(kwargs['phase']))
				)