upstream/mercurial-mirror Files · tests/filterpyflakes.py

extensions: register functions always at loading extension (issue5601)...

extensions: register functions always at loading extension (issue5601) Before this patch, functions defined in extensions are registered via extra loaders only in _dispatch(). Therefore, loading extensions in other code paths like below omits registration of functions. - WSGI service - operation across repositories (e.g. subrepo) - test-duplicateoptions.py, using extensions.loadall() directly To register functions always at loading new extension, this patch moves implementation for extra loading from dispatch._dispatch() to extensions.loadall(). AFAIK, only commands module causes cyclic dependency between extensions module, but this patch imports all related modules just before extra loading in loadall(), in order to centralize them. This patch makes extensions.py depend on many other modules, even though extensions.py itself doesn't. It should be avoided if possible, but I don't have any better idea. Some other places like below aren't reasonable for extra loading, IMHO. - specific function in newly added module: existing callers of extensions.loadall() should invoke it, too - hg.repository() or so: no-repo commands aren't covered by this. BTW, this patch removes _loaded.add(name) on relocation, because dispatch._loaded is used only for extraloaders (for similar reason, "exts" variable is removed, too).

Yuya Nishihara - - Load All Authors

File last commit:

r32510:50eaccb8 default


                r33052:45b0e9d0

default

Download file

             filterpyflakes.py
        
                    41 lines
            
             | 968 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / filterpyflakes.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/usr/bin/env python

      # Filter output by pyflakes to control which warnings we check

      from __future__ import absolute_import, print_function

      import re

      import sys

      lines = []

      for line in sys.stdin:

          # We blacklist tests that are too noisy for us

          pats = [

              r"undefined name 'WindowsError'",

              r"redefinition of unused '[^']+' from line",

              # for cffi, allow re-exports from pure.*

              r"cffi/[^:]*:.*\bimport \*' used",

              r"cffi/[^:]*:.*\*' imported but unused",

          ]

          keep = True

          for pat in pats:

              if re.search(pat, line):

                  keep = False

                  break # pattern matches

          if keep:

              fn = line.split(':', 1)[0]

              f = open(fn)

              data = f.read()

              f.close()

              if 'no-' 'check-code' in data:

                  continue

              lines.append(line)

      for line in lines:

          sys.stdout.write(line)

      print()

      # self test of "undefined name" detection

      if False:

          print(undefinedname)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/usr/bin/env python

				# Filter output by pyflakes to control which warnings we check

				from __future__ import absolute_import, print_function

				import re
				import sys

				lines = []
				for line in sys.stdin:
				# We blacklist tests that are too noisy for us
				pats = [
				r"undefined name 'WindowsError'",
				r"redefinition of unused '[^']+' from line",
				# for cffi, allow re-exports from pure.*
				r"cffi/[^:]:.\bimport \*' used",
				r"cffi/[^:]:.\*' imported but unused",
				]

				keep = True
				for pat in pats:
				if re.search(pat, line):
				keep = False
				break # pattern matches
				if keep:
				fn = line.split(':', 1)[0]
				f = open(fn)
				data = f.read()
				f.close()
				if 'no-' 'check-code' in data:
				continue
				lines.append(line)

				for line in lines:
				sys.stdout.write(line)
				print()

				# self test of "undefined name" detection
				if False:
				print(undefinedname)