upstream/mercurial-mirror Files · tests/test-lock-badness.t

extensions: register functions always at loading extension (issue5601)...

extensions: register functions always at loading extension (issue5601) Before this patch, functions defined in extensions are registered via extra loaders only in _dispatch(). Therefore, loading extensions in other code paths like below omits registration of functions. - WSGI service - operation across repositories (e.g. subrepo) - test-duplicateoptions.py, using extensions.loadall() directly To register functions always at loading new extension, this patch moves implementation for extra loading from dispatch._dispatch() to extensions.loadall(). AFAIK, only commands module causes cyclic dependency between extensions module, but this patch imports all related modules just before extra loading in loadall(), in order to centralize them. This patch makes extensions.py depend on many other modules, even though extensions.py itself doesn't. It should be avoided if possible, but I don't have any better idea. Some other places like below aren't reasonable for extra loading, IMHO. - specific function in newly added module: existing callers of extensions.loadall() should invoke it, too - hg.repository() or so: no-repo commands aren't covered by this. BTW, this patch removes _loaded.add(name) on relocation, because dispatch._loaded is used only for extraloaders (for similar reason, "exts" variable is removed, too).

Yuya Nishihara - - Load All Authors

File last commit:

r32337:46ba2cdd default


                r33052:45b0e9d0

default

Download file

             test-lock-badness.t
        
                    78 lines
            
             | 2.0 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-lock-badness.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require unix-permissions no-root no-windows

      Prepare

        $ hg init a

        $ echo a > a/a

        $ hg -R a ci -A -m a

        adding a

        $ hg clone a b

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

      Test that raising an exception in the release function doesn't cause the lock to choke

        $ cat > testlock.py << EOF

        > from mercurial import error, registrar

        > 

        > cmdtable = {}

        > command = registrar.command(cmdtable)

        > 

        > def acquiretestlock(repo, releaseexc):

        >     def unlock():

        >         if releaseexc:

        >             raise error.Abort('expected release exception')

        >     l = repo._lock(repo.vfs, 'testlock', False, unlock, None, 'test lock')

        >     return l

        > 

        > @command('testlockexc')

        > def testlockexc(ui, repo):

        >     testlock = acquiretestlock(repo, True)

        >     try:

        >         testlock.release()

        >     finally:

        >         try:

        >             testlock = acquiretestlock(repo, False)

        >         except error.LockHeld:

        >             raise error.Abort('lockfile on disk even after releasing!')

        >         testlock.release()

        > EOF

        $ cat >> $HGRCPATH << EOF

        > [extensions]

        > testlock=$TESTTMP/testlock.py

        > EOF

        $ hg -R b testlockexc

        abort: expected release exception

        [255]

      One process waiting for another

        $ cat > hooks.py << EOF

        > import time

        > def sleepone(**x): time.sleep(1)

        > def sleephalf(**x): time.sleep(0.5)

        > EOF

        $ echo b > b/b

        $ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout &

        $ hg -R b up -q --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \

        > > preup 2>&1

        $ wait

        $ cat preup

        waiting for lock on working directory of b held by process '*' on host '*' (glob)

        got lock after * seconds (glob)

        $ cat stdout

        adding b

      Pushing to a local read-only repo that can't be locked

        $ chmod 100 a/.hg/store

        $ hg -R b push a

        pushing to a

        searching for changes

        abort: could not lock repository a: Permission denied

        [255]

        $ chmod 700 a/.hg/store

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require unix-permissions no-root no-windows

				Prepare

				$ hg init a
				$ echo a > a/a
				$ hg -R a ci -A -m a
				adding a

				$ hg clone a b
				updating to branch default
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved

				Test that raising an exception in the release function doesn't cause the lock to choke

				$ cat > testlock.py << EOF
				> from mercurial import error, registrar
				>
				> cmdtable = {}
				> command = registrar.command(cmdtable)
				>
				> def acquiretestlock(repo, releaseexc):
				> def unlock():
				> if releaseexc:
				> raise error.Abort('expected release exception')
				> l = repo._lock(repo.vfs, 'testlock', False, unlock, None, 'test lock')
				> return l
				>
				> @command('testlockexc')
				> def testlockexc(ui, repo):
				> testlock = acquiretestlock(repo, True)
				> try:
				> testlock.release()
				> finally:
				> try:
				> testlock = acquiretestlock(repo, False)
				> except error.LockHeld:
				> raise error.Abort('lockfile on disk even after releasing!')
				> testlock.release()
				> EOF
				$ cat >> $HGRCPATH << EOF
				> [extensions]
				> testlock=$TESTTMP/testlock.py
				> EOF

				$ hg -R b testlockexc
				abort: expected release exception
				[255]

				One process waiting for another

				$ cat > hooks.py << EOF
				> import time
				> def sleepone(**x): time.sleep(1)
				> def sleephalf(**x): time.sleep(0.5)
				> EOF
				$ echo b > b/b
				$ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout &
				$ hg -R b up -q --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \
				> > preup 2>&1
				$ wait
				$ cat preup
				waiting for lock on working directory of b held by process '' on host '' (glob)
				got lock after * seconds (glob)
				$ cat stdout
				adding b

				Pushing to a local read-only repo that can't be locked

				$ chmod 100 a/.hg/store

				$ hg -R b push a
				pushing to a
				searching for changes
				abort: could not lock repository a: Permission denied
				[255]

				$ chmod 700 a/.hg/store