upstream/mercurial-mirror Files · rust/hg-core/src/dirstate/mod.rs

copies: do full filtering at end of _changesetforwardcopies()...

copies: do full filtering at end of _changesetforwardcopies() As mentioned earlier, pathcopies() is very slow when copies are stored in the changeset. Most of the cost comes from calling _chain() for every changeset, which is slow because it needs to read manifests. It needs to read manifests to be able to filter out copies that are were created in one commit and then deleted. (It also filters out copies that were created from a file that didn't exist in the starting revision, but that's a fixed revision across calls to _chain(), so it's much cheaper.) This patch changes from _chainandfilter() to just _chain() in the main loop in _changesetforwardcopies(). It instead removes copies that have subsequently been removed by using ctx.filesremoved(). We thus rely on that to be fast. It timed this command in mozilla-unified: hg debugpathcopies FIREFOX_59_0b3_BUILD2 FIREFOX_BETA_59_END It took 18s before and 1.1s after. It's still faster when copy information is stored in filelogs: 0.70s. It also still gets slow when there are merge commits involved, because we read manifests there too. We'll deal with that later. Differential Revision: https://phab.mercurial-scm.org/D6419

Raphaël Gomès - - Load All Authors

File last commit:

r42616:cc1cdce1 default


                r42685:4c39c99d

default

Download file

             mod.rs
        
                    28 lines
            
             | 648 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / dirstate / mod.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      pub mod parsers;

      #[derive(Debug, PartialEq, Copy, Clone)]

      pub struct DirstateParents<'a> {

          pub p1: &'a [u8],

          pub p2: &'a [u8],

      }

      /// The C implementation uses all signed types. This will be an issue

      /// either when 4GB+ source files are commonplace or in 2038, whichever

      /// comes first.

      #[derive(Debug, PartialEq)]

      pub struct DirstateEntry {

          pub state: i8,

          pub mode: i32,

          pub mtime: i32,

          pub size: i32,

      }

      pub type DirstateVec = Vec<(Vec<u8>, DirstateEntry)>;

      #[derive(Debug, PartialEq)]

      pub struct CopyVecEntry<'a> {

          pub path: &'a [u8],

          pub copy_path: &'a [u8],

      }

      pub type CopyVec<'a> = Vec<CopyVecEntry<'a>>;

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				pub mod parsers;

				#[derive(Debug, PartialEq, Copy, Clone)]
				pub struct DirstateParents<'a> {
				pub p1: &'a [u8],
				pub p2: &'a [u8],
				}

				/// The C implementation uses all signed types. This will be an issue
				/// either when 4GB+ source files are commonplace or in 2038, whichever
				/// comes first.
				#[derive(Debug, PartialEq)]
				pub struct DirstateEntry {
				pub state: i8,
				pub mode: i32,
				pub mtime: i32,
				pub size: i32,
				}

				pub type DirstateVec = Vec<(Vec<u8>, DirstateEntry)>;

				#[derive(Debug, PartialEq)]
				pub struct CopyVecEntry<'a> {
				pub path: &'a [u8],
				pub copy_path: &'a [u8],
				}

				pub type CopyVec<'a> = Vec<CopyVecEntry<'a>>;