upstream/mercurial-mirror Files · rust/hg-core/src/operations/debugdata.rs

rust: make `Revision` a newtype...

rust: make `Revision` a newtype This change is the one we've been building towards during this series. The aim is to make `Revision` mean more than a simple integer, holding the information that it is valid for a given revlog index. While this still allows for programmer error, since creating a revision directly and querying a different index with a "checked" revision are still possible, the friction created by the newtype will hopefully make us think twice about which type to use. Enough of the Rust ecosystem relies on the newtype pattern to be efficiently optimized away (even compiler in codegen tests¹), so I'm not worried about this being a fundamental problem. [1] https://github.com/rust-lang/rust/blob/7a70647f195f6b0a0f1ebd72b1542ba91a32f43a/tests/codegen/vec-in-place.rs#L47

Raphaël Gomès - - Load All Authors

File last commit:

r51870:1928b770 default


                r51872:4c5f6e95

default

Download file

             debugdata.rs
        
                    38 lines
            
             | 1.1 KiB
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / operations / debugdata.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      // debugdata.rs

      //

      // Copyright 2020 Antoine Cezar <antoine.cezar@octobus.net>

      //

      // This software may be used and distributed according to the terms of the

      // GNU General Public License version 2 or any later version.

      use crate::repo::Repo;

      use crate::requirements;

      use crate::revlog::{Revlog, RevlogError};

      /// Kind of data to debug

      #[derive(Debug, Copy, Clone)]

      pub enum DebugDataKind {

          Changelog,

          Manifest,

      }

      /// Dump the contents data of a revision.

      pub fn debug_data(

          repo: &Repo,

          revset: &str,

          kind: DebugDataKind,

      ) -> Result<Vec<u8>, RevlogError> {

          let index_file = match kind {

              DebugDataKind::Changelog => "00changelog.i",

              DebugDataKind::Manifest => "00manifest.i",

          };

          let use_nodemap = repo

              .requirements()

              .contains(requirements::NODEMAP_REQUIREMENT);

          let revlog =

              Revlog::open(&repo.store_vfs(), index_file, None, use_nodemap)?;

          let rev =

              crate::revset::resolve_rev_number_or_hex_prefix(revset, &revlog)?;

          let data = revlog.get_rev_data_for_checked_rev(rev)?;

          Ok(data.into_owned())

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				// debugdata.rs
				//
				// Copyright 2020 Antoine Cezar <antoine.cezar@octobus.net>
				//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

				use crate::repo::Repo;
				use crate::requirements;
				use crate::revlog::{Revlog, RevlogError};

				/// Kind of data to debug
				#[derive(Debug, Copy, Clone)]
				pub enum DebugDataKind {
				Changelog,
				Manifest,
				}

				/// Dump the contents data of a revision.
				pub fn debug_data(
				repo: &Repo,
				revset: &str,
				kind: DebugDataKind,
				) -> Result<Vec<u8>, RevlogError> {
				let index_file = match kind {
				DebugDataKind::Changelog => "00changelog.i",
				DebugDataKind::Manifest => "00manifest.i",
				};
				let use_nodemap = repo
				.requirements()
				.contains(requirements::NODEMAP_REQUIREMENT);
				let revlog =
				Revlog::open(&repo.store_vfs(), index_file, None, use_nodemap)?;
				let rev =
				crate::revset::resolve_rev_number_or_hex_prefix(revset, &revlog)?;
				let data = revlog.get_rev_data_for_checked_rev(rev)?;
				Ok(data.into_owned())
				}