upstream/mercurial-mirror Files · rust/hg-core/src/operations/mod.rs

rust: make `Revision` a newtype...

rust: make `Revision` a newtype This change is the one we've been building towards during this series. The aim is to make `Revision` mean more than a simple integer, holding the information that it is valid for a given revlog index. While this still allows for programmer error, since creating a revision directly and querying a different index with a "checked" revision are still possible, the friction created by the newtype will hopefully make us think twice about which type to use. Enough of the Rust ecosystem relies on the newtype pattern to be efficiently optimized away (even compiler in codegen tests¹), so I'm not worried about this being a fundamental problem. [1] https://github.com/rust-lang/rust/blob/7a70647f195f6b0a0f1ebd72b1542ba91a32f43a/tests/codegen/vec-in-place.rs#L47

Raphaël Gomès - - Load All Authors

File last commit:

r50875:95ffa065 default


                r51872:4c5f6e95

default

Download file

             mod.rs
        
                    10 lines
            
             | 409 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / operations / mod.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      //! A distinction is made between operations and commands.

      //! An operation is what can be done whereas a command is what is exposed by

      //! the cli. A single command can use several operations to achieve its goal.

      mod cat;

      mod debugdata;

      mod list_tracked_files;

      pub use cat::{cat, CatOutput};

      pub use debugdata::{debug_data, DebugDataKind};

      pub use list_tracked_files::{list_rev_tracked_files, FilesForRev};

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				//! A distinction is made between operations and commands.
				//! An operation is what can be done whereas a command is what is exposed by
				//! the cli. A single command can use several operations to achieve its goal.

				mod cat;
				mod debugdata;
				mod list_tracked_files;
				pub use cat::{cat, CatOutput};
				pub use debugdata::{debug_data, DebugDataKind};
				pub use list_tracked_files::{list_rev_tracked_files, FilesForRev};