upstream/mercurial-mirror Files · rust/hg-cpython/src/debug.rs

rust: make `Revision` a newtype...

rust: make `Revision` a newtype This change is the one we've been building towards during this series. The aim is to make `Revision` mean more than a simple integer, holding the information that it is valid for a given revlog index. While this still allows for programmer error, since creating a revision directly and querying a different index with a "checked" revision are still possible, the friction created by the newtype will hopefully make us think twice about which type to use. Enough of the Rust ecosystem relies on the newtype pattern to be efficiently optimized away (even compiler in codegen tests¹), so I'm not worried about this being a fundamental problem. [1] https://github.com/rust-lang/rust/blob/7a70647f195f6b0a0f1ebd72b1542ba91a32f43a/tests/codegen/vec-in-place.rs#L47

Raphaël Gomès - - Load All Authors

File last commit:

r45406:9f96beb9 default


                r51872:4c5f6e95

default

Download file

             debug.rs
        
                    24 lines
            
             | 822 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-cpython / src / debug.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      // debug.rs

      //

      // Copyright 2020 Raphaël Gomès <rgomes@octobus.net>

      //

      // This software may be used and distributed according to the terms of the

      // GNU General Public License version 2 or any later version.

      //! Module to get debug information about Rust extensions.

      use cpython::{PyDict, PyModule, PyResult, Python};

      /// Create the module, with `__package__` given from parent

      pub fn init_module(py: Python, package: &str) -> PyResult<PyModule> {

          let dotted_name = &format!("{}.debug", package);

          let m = PyModule::new(py, dotted_name)?;

          m.add(py, "__package__", package)?;

          m.add(py, "__doc__", "Rust debugging information")?;

          let sys = PyModule::import(py, "sys")?;

          let sys_modules: PyDict = sys.get(py, "modules")?.extract(py)?;

          sys_modules.set_item(py, dotted_name, &m)?;

          Ok(m)

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				// debug.rs
				//
				// Copyright 2020 Raphaël Gomès <rgomes@octobus.net>
				//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

				//! Module to get debug information about Rust extensions.
				use cpython::{PyDict, PyModule, PyResult, Python};

				/// Create the module, with `__package__` given from parent
				pub fn init_module(py: Python, package: &str) -> PyResult<PyModule> {
				let dotted_name = &format!("{}.debug", package);
				let m = PyModule::new(py, dotted_name)?;

				m.add(py, "__package__", package)?;
				m.add(py, "__doc__", "Rust debugging information")?;

				let sys = PyModule::import(py, "sys")?;
				let sys_modules: PyDict = sys.get(py, "modules")?.extract(py)?;
				sys_modules.set_item(py, dotted_name, &m)?;

				Ok(m)
				}