upstream/mercurial-mirror Files · tests/test-check-code.t

run-tests: fix race condition...

run-tests: fix race condition Before this patch, it was possible for run-tests to crash on a race condition. The race condition happens in the following case: - the last test finishes and calls: done.put(None) - the context switches to the main thread that clears the channels list - the context switches to the last test mentioned above, it tries to access channels[channel] and crashes This happened to me while running run-tests. This patch fixes the issue by clearing the channel before considering that the test is done.

Matt Mackall - - Load All Authors

File last commit:

r27909:3203dfe3 stable


                r27926:4c6053a6

stable

Download file

             test-check-code.t
        
                    15 lines
            
             | 661 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-code.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require test-repo

        $ check_code="$TESTDIR"/../contrib/check-code.py

        $ cd "$TESTDIR"/..

      New errors are not allowed. Warnings are strongly discouraged.

      (The writing "no-che?k-code" is for not skipping this file when checking.)

        $ hg locate | sed 's-\\-/-g' |

        >   xargs "$check_code" --warnings --per-file=0 || false

        Skipping hgext/zeroconf/Zeroconf.py it has no-che?k-code (glob)

        Skipping i18n/polib.py it has no-che?k-code (glob)

        Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)

        Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)

        Skipping mercurial/httpclient/socketutil.py it has no-che?k-code (glob)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require test-repo

				$ check_code="$TESTDIR"/../contrib/check-code.py
				$ cd "$TESTDIR"/..

				New errors are not allowed. Warnings are strongly discouraged.
				(The writing "no-che?k-code" is for not skipping this file when checking.)

				$ hg locate \| sed 's-\\-/-g' \|
				> xargs "$check_code" --warnings --per-file=0 \|\| false
				Skipping hgext/zeroconf/Zeroconf.py it has no-che?k-code (glob)
				Skipping i18n/polib.py it has no-che?k-code (glob)
				Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)
				Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)
				Skipping mercurial/httpclient/socketutil.py it has no-che?k-code (glob)