upstream/mercurial-mirror Files · tests/test-hghave.t

run-tests: fix race condition...

run-tests: fix race condition Before this patch, it was possible for run-tests to crash on a race condition. The race condition happens in the following case: - the last test finishes and calls: done.put(None) - the context switches to the main thread that clears the channels list - the context switches to the last test mentioned above, it tries to access channels[channel] and crashes This happened to me while running run-tests. This patch fixes the issue by clearing the channel before considering that the test is done.

timeless@mozdev.org - - Load All Authors

File last commit:

r26158:342ab95a default


                r27926:4c6053a6

stable

Download file

             test-hghave.t
        
                    39 lines
            
             | 893 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-hghave.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      Testing that hghave does not crash when checking features

        $ hghave --test-features 2>/dev/null

      Testing hghave extensibility for third party tools

        $ cat > hghaveaddon.py <<EOF

        > import hghave

        > @hghave.check("custom", "custom hghave feature")

        > def has_custom():

        >     return True

        > EOF

      (invocation via run-tests.py)

        $ cat > test-hghaveaddon.t <<EOF

        > #require custom

        >   $ echo foo

        >   foo

        > EOF

        $ run-tests.py $HGTEST_RUN_TESTS_PURE test-hghaveaddon.t

        .

        # Ran 1 tests, 0 skipped, 0 warned, 0 failed.

      (invocation via command line)

        $ unset TESTDIR

        $ hghave custom

      (terminate with exit code 2 at failure of importing hghaveaddon.py)

        $ rm hghaveaddon.*

        $ cat > hghaveaddon.py <<EOF

        > importing this file should cause syntax error

        > EOF

        $ hghave custom

        failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)

        [2]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				Testing that hghave does not crash when checking features

				$ hghave --test-features 2>/dev/null

				Testing hghave extensibility for third party tools

				$ cat > hghaveaddon.py <<EOF
				> import hghave
				> @hghave.check("custom", "custom hghave feature")
				> def has_custom():
				> return True
				> EOF

				(invocation via run-tests.py)

				$ cat > test-hghaveaddon.t <<EOF
				> #require custom
				> $ echo foo
				> foo
				> EOF
				$ run-tests.py $HGTEST_RUN_TESTS_PURE test-hghaveaddon.t
				.
				# Ran 1 tests, 0 skipped, 0 warned, 0 failed.

				(invocation via command line)

				$ unset TESTDIR
				$ hghave custom

				(terminate with exit code 2 at failure of importing hghaveaddon.py)

				$ rm hghaveaddon.*
				$ cat > hghaveaddon.py <<EOF
				> importing this file should cause syntax error
				> EOF

				$ hghave custom
				failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)
				[2]