upstream/mercurial-mirror Files · mercurial/policy.py

hgweb: cache fctx.parents() in annotate command (issue5414)...

hgweb: cache fctx.parents() in annotate command (issue5414) introduced a call to fctx.parents() for each line in annotate output. This function call isn't cheap, as it requires linkrev adjustment. Since multiple lines in annotate output tend to belong to the same file revision, a cache of fctx.parents() lookups for each input should be effective in the common case. So we implement one. Since the cache has to precompute parents so an aborted generator doesn't leave an incomplete cache, we could just return a list. However, we preserve the generator for backwards compatibility. The effect of this change when requesting /annotate/96ca0ecdcfa/ browser/locales/en-US/chrome/browser/downloads/downloads.dtd on the mozilla-aurora repo is significant: p1(9c37df347485) 5.5s 9c37df347485: 66.3s this patch: 10.8s We're still slower than before. But only by ~2x instead of ~12x. On the tip revisions of layout/base/nsCSSFrameConstructor.cpp file in the mozilla-unified repo, time went from 12.5s to 14.5s and back to 12.5s. I'm not sure why the mozilla-aurora repo is so slow. Looking at the code of basefilectx.parents(), there is room for further improvements. Notably, we still perform redundant calls to filelog.renamed() and basefilectx._parentfilectx(). And basefilectx.annotate() also makes similar calls, so there is potential for object reuse. However, introducing caches here are not appropriate for the stable branch.

Maciej Fijalkowski - - Load All Authors

File last commit:

r29490:b4d117ce default


                r30298:4ed8bb8a

stable

Download file

             policy.py
        
                    45 lines
            
             | 1.4 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / policy.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # policy.py - module policy logic for Mercurial.

      #

      # Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      import os

      import sys

      # Rules for how modules can be loaded. Values are:

      #

      #    c - require C extensions

      #    allow - allow pure Python implementation when C loading fails

      #    cffi - required cffi versions (implemented within pure module)

      #    cffi-allow - allow pure Python implementation if cffi version is missing

      #    py - only load pure Python modules

      #

      # By default, require the C extensions for performance reasons.

      policy = 'c'

      policynoc = ('cffi', 'cffi-allow', 'py')

      policynocffi = ('c', 'py')

      try:

          from . import __modulepolicy__

          policy = __modulepolicy__.modulepolicy

      except ImportError:

          pass

      # PyPy doesn't load C extensions.

      #

      # The canonical way to do this is to test platform.python_implementation().

      # But we don't import platform and don't bloat for it here.

      if '__pypy__' in sys.builtin_module_names:

          policy = 'cffi'

      # Our C extensions aren't yet compatible with Python 3. So use pure Python

      # on Python 3 for now.

      if sys.version_info[0] >= 3:

          policy = 'py'

      # Environment variable can always force settings.

      policy = os.environ.get('HGMODULEPOLICY', policy)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# policy.py - module policy logic for Mercurial.
				#
				# Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import absolute_import

				import os
				import sys

				# Rules for how modules can be loaded. Values are:
				#
				# c - require C extensions
				# allow - allow pure Python implementation when C loading fails
				# cffi - required cffi versions (implemented within pure module)
				# cffi-allow - allow pure Python implementation if cffi version is missing
				# py - only load pure Python modules
				#
				# By default, require the C extensions for performance reasons.
				policy = 'c'
				policynoc = ('cffi', 'cffi-allow', 'py')
				policynocffi = ('c', 'py')

				try:
				from . import __modulepolicy__
				policy = __modulepolicy__.modulepolicy
				except ImportError:
				pass

				# PyPy doesn't load C extensions.
				#
				# The canonical way to do this is to test platform.python_implementation().
				# But we don't import platform and don't bloat for it here.
				if '__pypy__' in sys.builtin_module_names:
				policy = 'cffi'

				# Our C extensions aren't yet compatible with Python 3. So use pure Python
				# on Python 3 for now.
				if sys.version_info[0] >= 3:
				policy = 'py'

				# Environment variable can always force settings.
				policy = os.environ.get('HGMODULEPOLICY', policy)