upstream/mercurial-mirror Files · tests/test-narrow-copies.t

posix: always seek to EOF when opening a file in append mode...

posix: always seek to EOF when opening a file in append mode Python 3 already does this, so skip it there. Consider the program: #include <stdio.h> int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("narf", "a"); printf("%ld\n", ftell(f)); fprintf(f, "troz\n"); printf("%ld\n", ftell(f)); return 0; } on macOS, FreeBSD, and Linux with glibc, this program prints 5 10 but on musl libc (Alpine Linux and probably others) this prints 0 10 By my reading of https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html this is technically correct, specifically: > Opening a file with append mode (a as the first character in the > mode argument) shall cause all subsequent writes to the file to be > forced to the then current end-of-file, regardless of intervening > calls to fseek(). in other words, the file position doesn't really matter in append-mode files, and we can't depend on it being at all meaningful unless we perform a seek() before tell() after open(..., 'a'). Experimentally after a .write() we can do a .tell() and it'll always be reasonable, but I'm unclear from reading the specification if that's a smart thing to rely on. This matches what we do on Windows and what Python 3 does for free, so let's just be consistent. Thanks to Yuya for the idea.

Martin von Zweigbergk - - Load All Authors

File last commit:

r40489:07a66c13 stable


                r43163:97ada9b8

5.0.2 stable

Download file

             test-narrow-copies.t
        
                    74 lines
            
             | 1.9 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-narrow-copies.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ . "$TESTDIR/narrow-library.sh"

      create full repo

        $ hg init master

        $ cd master

        $ mkdir inside

        $ echo inside > inside/f1

        $ mkdir outside

        $ echo outside > outside/f2

        $ hg ci -Aqm 'initial'

        $ hg mv outside/f2 inside/f2

        $ hg ci -qm 'move f2 from outside'

        $ echo modified > inside/f2

        $ hg ci -qm 'modify inside/f2'

        $ mkdir outside

        $ echo new > outside/f3

        $ hg ci -Aqm 'add outside/f3'

        $ cd ..

        $ hg clone --narrow ssh://user@dummy/master narrow --include inside -r 2

        adding changesets

        adding manifests

        adding file changes

        added 3 changesets with 3 changes to 2 files

        new changesets *:* (glob)

        updating to branch default

        2 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cd narrow

        $ hg co 'desc("move f2")'

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ hg status

        $ hg diff

        $ hg diff --change . --git

        diff --git a/inside/f2 b/inside/f2

        new file mode 100644

        --- /dev/null

        +++ b/inside/f2

        @@ -0,0 +1,1 @@

        +outside

        $ hg log --follow inside/f2 -r tip

        changeset:   2:bcfb756e0ca9

        tag:         tip

        user:        test

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     modify inside/f2

        changeset:   1:5a016133b2bb

        user:        test

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     move f2 from outside

        $ echo new > inside/f4

        $ hg ci -Aqm 'add inside/f4'

        $ hg pull -q

        $ hg --config extensions.rebase= rebase -d tip

        rebasing 3:4f84b666728c "add inside/f4"

        saved backup bundle to $TESTTMP/narrow/.hg/strip-backup/4f84b666728c-4269b76e-rebase.hg

        $ hg co -q 0

        $ echo modified > inside/f1

        $ hg ci -qm 'modify inside/f1'

        $ echo new > inside/f5

        $ hg ci -Aqm 'add inside/f5'

        $ hg --config extensions.rebase= rebase -d 'public()' -r .

        rebasing 6:610b60178c28 "add inside/f5" (tip)

        saved backup bundle to $TESTTMP/narrow/.hg/strip-backup/610b60178c28-65716a78-rebase.hg

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages


				$ . "$TESTDIR/narrow-library.sh"

				create full repo

				$ hg init master
				$ cd master

				$ mkdir inside
				$ echo inside > inside/f1
				$ mkdir outside
				$ echo outside > outside/f2
				$ hg ci -Aqm 'initial'

				$ hg mv outside/f2 inside/f2
				$ hg ci -qm 'move f2 from outside'

				$ echo modified > inside/f2
				$ hg ci -qm 'modify inside/f2'

				$ mkdir outside
				$ echo new > outside/f3
				$ hg ci -Aqm 'add outside/f3'
				$ cd ..

				$ hg clone --narrow ssh://user@dummy/master narrow --include inside -r 2
				adding changesets
				adding manifests
				adding file changes
				added 3 changesets with 3 changes to 2 files
				new changesets : (glob)
				updating to branch default
				2 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ cd narrow

				$ hg co 'desc("move f2")'
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ hg status
				$ hg diff
				$ hg diff --change . --git
				diff --git a/inside/f2 b/inside/f2
				new file mode 100644
				--- /dev/null
				+++ b/inside/f2
				@@ -0,0 +1,1 @@
				+outside

				$ hg log --follow inside/f2 -r tip
				changeset: 2:bcfb756e0ca9
				tag: tip
				user: test
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: modify inside/f2

				changeset: 1:5a016133b2bb
				user: test
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: move f2 from outside

				$ echo new > inside/f4
				$ hg ci -Aqm 'add inside/f4'
				$ hg pull -q
				$ hg --config extensions.rebase= rebase -d tip
				rebasing 3:4f84b666728c "add inside/f4"
				saved backup bundle to $TESTTMP/narrow/.hg/strip-backup/4f84b666728c-4269b76e-rebase.hg

				$ hg co -q 0
				$ echo modified > inside/f1
				$ hg ci -qm 'modify inside/f1'
				$ echo new > inside/f5
				$ hg ci -Aqm 'add inside/f5'
				$ hg --config extensions.rebase= rebase -d 'public()' -r .
				rebasing 6:610b60178c28 "add inside/f5" (tip)
				saved backup bundle to $TESTTMP/narrow/.hg/strip-backup/610b60178c28-65716a78-rebase.hg