##// END OF EJS Templates
posix: always seek to EOF when opening a file in append mode...
posix: always seek to EOF when opening a file in append mode Python 3 already does this, so skip it there. Consider the program: #include <stdio.h> int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("narf", "a"); printf("%ld\n", ftell(f)); fprintf(f, "troz\n"); printf("%ld\n", ftell(f)); return 0; } on macOS, FreeBSD, and Linux with glibc, this program prints 5 10 but on musl libc (Alpine Linux and probably others) this prints 0 10 By my reading of https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html this is technically correct, specifically: > Opening a file with append mode (a as the first character in the > mode argument) shall cause all subsequent writes to the file to be > forced to the then current end-of-file, regardless of intervening > calls to fseek(). in other words, the file position doesn't really matter in append-mode files, and we can't depend on it being at all meaningful unless we perform a seek() before tell() after open(..., 'a'). Experimentally after a .write() we can do a .tell() and it'll always be reasonable, but I'm unclear from reading the specification if that's a smart thing to rely on. This matches what we do on Windows and what Python 3 does for free, so let's just be consistent. Thanks to Yuya for the idea.

File last commit:

r36061:3b4d14be default
r43163:97ada9b8 5.0.2 stable
Show More
ext-phase-report.py
22 lines | 799 B | text/x-python | PythonLexer
# tiny extension to report phase changes during transaction
from __future__ import absolute_import
def reposetup(ui, repo):
def reportphasemove(tr):
for rev, move in sorted(tr.changes[b'phases'].items()):
if move[0] is None:
ui.write((b'test-debug-phase: new rev %d: x -> %d\n'
% (rev, move[1])))
else:
ui.write((b'test-debug-phase: move rev %d: %d -> %d\n'
% (rev, move[0], move[1])))
class reportphaserepo(repo.__class__):
def transaction(self, *args, **kwargs):
tr = super(reportphaserepo, self).transaction(*args, **kwargs)
tr.addpostclose(b'report-phase', reportphasemove)
return tr
repo.__class__ = reportphaserepo