##// END OF EJS Templates
lookup: add option to disambiguate prefix within revset...
lookup: add option to disambiguate prefix within revset When resolving a nodeid prefix that is not unique within the repo and the user has configured a revset that they want to disambiguate within, we now try to look up within that revset before we fail. If there is a unique match within the revset, we use that. This is of course most effective at allowing a short prefix if the revset contains few nodes. For most of our internal users at Google, "not public()" is sufficiently small that a hex digit or two is enough. The implementation is currently pretty slow, but good enough for small revsets (which is the expected use case). The scan in the revset is linear. We may want to use a prefix tree if we want to allow users to use a larger revset. Credit for the idea goes to Kyle Lippincott. Differential Revision: https://phab.mercurial-scm.org/D4037

File last commit:

r36121:9b5df6e1 default
r38878:503f9364 default
Show More
TODO.rst
37 lines | 1.7 KiB | text/x-rst | RstLexer

Integration with the share extension needs improvement. Right now we've seen some odd bugs, and the way we modify the contents of the .hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec().

Resolve commentary on narrowrepo.wraprepo.narrowrepository.status about the filtering of status being done at an awkward layer. This came up the import to hgext, but nobody's got concrete improvement ideas as of then.

Fold most (or preferably all) of narrowrevlog.py into core.

Address commentary in narrowrevlog.excludedmanifestrevlog.add - specifically we should improve the collaboration with core so that add() never gets called on an excluded directory and we can improve the stand-in to raise a ProgrammingError.

Figure out how to correctly produce narrowmanifestrevlog and narrowfilelog instances instead of monkeypatching regular revlogs at runtime to our subclass. Even better, merge the narrowing logic directly into core.

Reason more completely about rename-filtering logic in narrowfilelog. There could be some surprises lurking there.

Formally document the narrowspec format. Unify with sparse, if at all possible. For bonus points, unify with the server-specified narrowspec format.

narrowrepo.setnarrowpats() or narrowspec.save() need to make sure they're holding the wlock.

Implement a simple version of the expandnarrow wireproto command for core. Having configurable shorthands for narrowspecs has been useful at Google (and sparse has a similar feature from Facebook), so it probably makes sense to implement the feature in core. (Google's handler is entirely custom to Google, with a custom format related to bazel's build language, so it's not in the narrowhg distribution.)