upstream/mercurial-mirror Files · hgext/hooklib/enforce_draft_commits.py

shelve: raise an error when loading a corrupt state file in an impossible case...

shelve: raise an error when loading a corrupt state file in an impossible case The old return statement was flagged by pytype 2023.06.16 running under python 3.10.11. No idea why it isn't caught in CI running the same pytype with py3.7. This function is only called by `unshelvecmd()` (which first checks that either `--abort` or `--continue` is specified), and `hgabortunshelve()` and `hgcontinueunshelve()`, which locally apply `--abort` or `--continue` respectively. Therefore, there is no other way to call this, and this error should never be seen, but pytype can't figure that out on its own. Given that the abort case clears the state, it seems reasonable to defensively code this and not make that a blanket `else` case, on the off chance a 3rd way of calling this appears in the future.

Gregory Szorc - - Load All Authors

File last commit:

r49730:6000f5b2 default


                r52706:54b1a373

default

Download file

             enforce_draft_commits.py
        
                    44 lines
            
             | 1.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / hooklib / enforce_draft_commits.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Copyright 2020 Joerg Sonnenberger <joerg@bec.de>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      """enforce_draft_commits us a hook to ensure that all new changesets are

      in the draft phase. This allows enforcing policies for work-in-progress

      changes in overlay repositories, i.e. a shared hidden repositories with

      different views for work-in-progress code and public history.

      Usage:

        [hooks]

        pretxnclose-phase.enforce_draft_commits = \

          python:hgext.hooklib.enforce_draft_commits.hook

      """

      from mercurial.i18n import _

      from mercurial import (

          error,

          pycompat,

      )

      def hook(ui, repo, hooktype, node=None, **kwargs):

          if hooktype != b"pretxnclose-phase":

              raise error.Abort(

                  _(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)

              )

          ctx = repo.unfiltered()[node]

          if kwargs['oldphase']:

              raise error.Abort(

                  _(b'Phase change from %r to %r for %s rejected')

                  % (

                      pycompat.bytestr(kwargs['oldphase']),

                      pycompat.bytestr(kwargs['phase']),

                      ctx,

                  )

              )

          elif kwargs['phase'] != b'draft':

              raise error.Abort(

                  _(b'New changeset %s in phase %r rejected')

                  % (ctx, pycompat.bytestr(kwargs['phase']))

              )

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Copyright 2020 Joerg Sonnenberger <joerg@bec.de>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				"""enforce_draft_commits us a hook to ensure that all new changesets are
				in the draft phase. This allows enforcing policies for work-in-progress
				changes in overlay repositories, i.e. a shared hidden repositories with
				different views for work-in-progress code and public history.

				Usage:
				[hooks]
				pretxnclose-phase.enforce_draft_commits = \
				python:hgext.hooklib.enforce_draft_commits.hook
				"""


				from mercurial.i18n import _
				from mercurial import (
				error,
				pycompat,
				)


				def hook(ui, repo, hooktype, node=None, **kwargs):
				if hooktype != b"pretxnclose-phase":
				raise error.Abort(
				_(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)
				)
				ctx = repo.unfiltered()[node]
				if kwargs['oldphase']:
				raise error.Abort(
				_(b'Phase change from %r to %r for %s rejected')
				% (
				pycompat.bytestr(kwargs['oldphase']),
				pycompat.bytestr(kwargs['phase']),
				ctx,
				)
				)
				elif kwargs['phase'] != b'draft':
				raise error.Abort(
				_(b'New changeset %s in phase %r rejected')
				% (ctx, pycompat.bytestr(kwargs['phase']))
				)