##// END OF EJS Templates
rebase: make collapsing use explicit logic to decide on the rev to reuse...
rebase: make collapsing use explicit logic to decide on the rev to reuse This code: for rev in sortedstate: ... ... newnode = concludenode(repo, rev, p1, rbsrt.external, commitmsg=commitmsg, extrafn=extrafn, editor=editor, keepbranches=rbsrt.keepbranchesf, date=rbsrt.date) uses 'rev' variable in 'concludenode' function invocation. It is not explicitly assigned before, but its value comes as last value or 'rev' in a for loop, e.g. last element in a 'sortedstate'. IMO this a bad style and it also makes it hard to refactor the function, so it is better to explicitly define the value passed to 'concludenode'.
Kostia Balytskyi -
r29474:56641501 default
Show More
Name Size Modified Last Commit Author
/ hgext / zeroconf
Zeroconf.py Loading ...
__init__.py Loading ...