upstream/mercurial-mirror Files · mercurial/revlogutils/constants.py

progress: avoid ui.configbool() lookup when progress bar is active...

progress: avoid ui.configbool() lookup when progress bar is active Profiling revealed that the ui.configbool('progress', 'debug') during progress bar updates was consuming a significant amount of overhead. This commit adds an attribute on progress bar instances that caches this config option. The impact on `hg perfprogress` with default options is significant: before: ! wall 4.641942 comb 4.580000 user 4.210000 sys 0.370000 (best of 3) after: ! wall 1.948626 comb 1.950000 user 1.950000 sys 0.000000 (best of 5) After this change, profiling reveals that progress.progbar.progress() is now consuming ~73% of time. This change does not improve the execution time if the progress bar is disabled. We may want a more comprehensive solution for that case, as the progress bar won't be enabled in a number of scenarios (e.g. servers and processes not attached to an interactive TTY). I also think that overhead of ~2.0s for 1M updates is a bit high. I suspect further refactoring of the progress bar can significantly reduce overhead. I don't have plans to do this, however. Differential Revision: https://phab.mercurial-scm.org/D5408

Boris Feld - - Load All Authors

File last commit:

r39542:b66ea3fc default


                r41093:6603de28

default

Download file

             constants.py
        
                    54 lines
            
             | 1.7 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / revlogutils / constants.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # revlogdeltas.py - constant used for revlog logic

      #

      # Copyright 2005-2007 Matt Mackall <mpm@selenic.com>

      # Copyright 2018 Octobus <contact@octobus.net>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      """Helper class to compute deltas stored inside revlogs"""

      from __future__ import absolute_import

      from .. import (

          repository,

          util,

      )

      # revlog header flags

      REVLOGV0 = 0

      REVLOGV1 = 1

      # Dummy value until file format is finalized.

      # Reminder: change the bounds check in revlog.__init__ when this is changed.

      REVLOGV2 = 0xDEAD

      FLAG_INLINE_DATA = (1 << 16)

      FLAG_GENERALDELTA = (1 << 17)

      REVLOG_DEFAULT_FLAGS = FLAG_INLINE_DATA

      REVLOG_DEFAULT_FORMAT = REVLOGV1

      REVLOG_DEFAULT_VERSION = REVLOG_DEFAULT_FORMAT | REVLOG_DEFAULT_FLAGS

      REVLOGV1_FLAGS = FLAG_INLINE_DATA | FLAG_GENERALDELTA

      REVLOGV2_FLAGS = REVLOGV1_FLAGS

      # revlog index flags

      # For historical reasons, revlog's internal flags were exposed via the

      # wire protocol and are even exposed in parts of the storage APIs.

      # revision has censor metadata, must be verified

      REVIDX_ISCENSORED = repository.REVISION_FLAG_CENSORED

      # revision hash does not match data (narrowhg)

      REVIDX_ELLIPSIS = repository.REVISION_FLAG_ELLIPSIS

      # revision data is stored externally

      REVIDX_EXTSTORED = repository.REVISION_FLAG_EXTSTORED

      REVIDX_DEFAULT_FLAGS = 0

      # stable order in which flags need to be processed and their processors applied

      REVIDX_FLAGS_ORDER = [

          REVIDX_ISCENSORED,

          REVIDX_ELLIPSIS,

          REVIDX_EXTSTORED,

      ]

      REVIDX_KNOWN_FLAGS = util.bitsfrom(REVIDX_FLAGS_ORDER)

      # bitmark for flags that could cause rawdata content change

      REVIDX_RAWTEXT_CHANGING_FLAGS = REVIDX_ISCENSORED | REVIDX_EXTSTORED

      SPARSE_REVLOG_MAX_CHAIN_LENGTH = 1000

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# revlogdeltas.py - constant used for revlog logic
				#
				# Copyright 2005-2007 Matt Mackall <mpm@selenic.com>
				# Copyright 2018 Octobus <contact@octobus.net>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.
				"""Helper class to compute deltas stored inside revlogs"""

				from __future__ import absolute_import

				from .. import (
				repository,
				util,
				)

				# revlog header flags
				REVLOGV0 = 0
				REVLOGV1 = 1
				# Dummy value until file format is finalized.
				# Reminder: change the bounds check in revlog.__init__ when this is changed.
				REVLOGV2 = 0xDEAD
				FLAG_INLINE_DATA = (1 << 16)
				FLAG_GENERALDELTA = (1 << 17)
				REVLOG_DEFAULT_FLAGS = FLAG_INLINE_DATA
				REVLOG_DEFAULT_FORMAT = REVLOGV1
				REVLOG_DEFAULT_VERSION = REVLOG_DEFAULT_FORMAT \| REVLOG_DEFAULT_FLAGS
				REVLOGV1_FLAGS = FLAG_INLINE_DATA \| FLAG_GENERALDELTA
				REVLOGV2_FLAGS = REVLOGV1_FLAGS

				# revlog index flags

				# For historical reasons, revlog's internal flags were exposed via the
				# wire protocol and are even exposed in parts of the storage APIs.

				# revision has censor metadata, must be verified
				REVIDX_ISCENSORED = repository.REVISION_FLAG_CENSORED
				# revision hash does not match data (narrowhg)
				REVIDX_ELLIPSIS = repository.REVISION_FLAG_ELLIPSIS
				# revision data is stored externally
				REVIDX_EXTSTORED = repository.REVISION_FLAG_EXTSTORED
				REVIDX_DEFAULT_FLAGS = 0
				# stable order in which flags need to be processed and their processors applied
				REVIDX_FLAGS_ORDER = [
				REVIDX_ISCENSORED,
				REVIDX_ELLIPSIS,
				REVIDX_EXTSTORED,
				]
				REVIDX_KNOWN_FLAGS = util.bitsfrom(REVIDX_FLAGS_ORDER)
				# bitmark for flags that could cause rawdata content change
				REVIDX_RAWTEXT_CHANGING_FLAGS = REVIDX_ISCENSORED \| REVIDX_EXTSTORED

				SPARSE_REVLOG_MAX_CHAIN_LENGTH = 1000