upstream/mercurial-mirror Files · mercurial/templates/monoblue/changelogentry.tmpl

progress: avoid ui.configbool() lookup when progress bar is active...

progress: avoid ui.configbool() lookup when progress bar is active Profiling revealed that the ui.configbool('progress', 'debug') during progress bar updates was consuming a significant amount of overhead. This commit adds an attribute on progress bar instances that caches this config option. The impact on `hg perfprogress` with default options is significant: before: ! wall 4.641942 comb 4.580000 user 4.210000 sys 0.370000 (best of 3) after: ! wall 1.948626 comb 1.950000 user 1.950000 sys 0.000000 (best of 5) After this change, profiling reveals that progress.progbar.progress() is now consuming ~73% of time. This change does not improve the execution time if the progress bar is disabled. We may want a more comprehensive solution for that case, as the progress bar won't be enabled in a number of scenarios (e.g. servers and processes not attached to an interactive TTY). I also think that overhead of ~2.0s for 1M updates is a bit high. I suspect further refactoring of the progress bar can significantly reduce overhead. I don't have plans to do this, however. Differential Revision: https://phab.mercurial-scm.org/D5408

av6 - - Load All Authors

File last commit:

r35052:e9a8a941 default


                r41093:6603de28

default

Download file

             changelogentry.tmpl
        
                    11 lines
            
             | 467 B
            
                | application/x-cheetah
            
             |
                CheetahLexer
            
             / mercurial / templates / monoblue / changelogentry.tmpl
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      <h3 class="changelog">

          <a class="title" href="{url|urlescape}rev/{node|short}{sessionvars%urlparameter}">

              {desc|strip|firstline|escape|nonempty}

              {alltags}

          </a>

      </h3>

      <ul class="changelog-entry">

          <li class="age">{date|rfc822date}</li>

          <li>by <span class="name">{author|obfuscate}</span> <span class="revdate">[{date|rfc822date}] rev {rev}</span></li>

          <li class="description">{desc|strip|escape|websub|addbreaks|nonempty}</li>

      </ul>

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				<h3 class="changelog">
				<a class="title" href="{url\|urlescape}rev/{node\|short}{sessionvars%urlparameter}">
				{desc\|strip\|firstline\|escape\|nonempty}
				{alltags}
				</a>
				</h3>
				<ul class="changelog-entry">
				<li class="age">{date\|rfc822date}</li>
				<li>by <span class="name">{author\|obfuscate}</span> <span class="revdate">[{date\|rfc822date}] rev {rev}</span></li>
				<li class="description">{desc\|strip\|escape\|websub\|addbreaks\|nonempty}</li>
				</ul>