upstream/mercurial-mirror Files · hgext/infinitepush/common.py

phabricator: don't infer the old `fctx` in `notutf8()`...

phabricator: don't infer the old `fctx` in `notutf8()` This is used along with `fctx.isbinary()` to gate `addoldbinary()`, so it seems like a good idea to provide the caller similar control over the current and parent filecontext. Unlike `addoldbinary()`, it doesn't need both previous and current contexts at the same time, so make the caller responsible for testing both cases, as appropriate. I haven't worked out all of the problems around marking files as binary for move/remove/copy, but this will definitely help with `--no-stack` too. It also turns out to have been doing too much- in the remove case, it tested not just the removed file in the parent context (which is what gets passed in that case), but also in the parent of the parent context (which should be irrelevant). The previous code also required the `fctx.parents()` check to work in the add (but without rename) case. Now the add and remove cases test only what they need to. But now that it is written this way, the fact that only the current `fctx` is checked to be binary in the case of modification or being renamed seems wrong. Differential Revision: https://phab.mercurial-scm.org/D8220

Augie Fackler - - Load All Authors

File last commit:

r43812:2fe6121c default


                r44913:66a05dbb

default

Download file

             common.py
        
                    52 lines
            
             | 1.2 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / infinitepush / common.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Copyright 2017 Facebook, Inc.

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      import os

      from mercurial.node import hex

      from mercurial import (

          error,

          extensions,

          pycompat,

      )

      def isremotebooksenabled(ui):

          return b'remotenames' in extensions._extensions and ui.configbool(

              b'remotenames', b'bookmarks'

          )

      def downloadbundle(repo, unknownbinhead):

          index = repo.bundlestore.index

          store = repo.bundlestore.store

          bundleid = index.getbundle(hex(unknownbinhead))

          if bundleid is None:

              raise error.Abort(b'%s head is not known' % hex(unknownbinhead))

          bundleraw = store.read(bundleid)

          return _makebundlefromraw(bundleraw)

      def _makebundlefromraw(data):

          fp = None

          fd, bundlefile = pycompat.mkstemp()

          try:  # guards bundlefile

              try:  # guards fp

                  fp = os.fdopen(fd, 'wb')

                  fp.write(data)

              finally:

                  fp.close()

          except Exception:

              try:

                  os.unlink(bundlefile)

              except Exception:

                  # we would rather see the original exception

                  pass

              raise

          return bundlefile

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Copyright 2017 Facebook, Inc.
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import absolute_import

				import os

				from mercurial.node import hex

				from mercurial import (
				error,
				extensions,
				pycompat,
				)


				def isremotebooksenabled(ui):
				return b'remotenames' in extensions._extensions and ui.configbool(
				b'remotenames', b'bookmarks'
				)


				def downloadbundle(repo, unknownbinhead):
				index = repo.bundlestore.index
				store = repo.bundlestore.store
				bundleid = index.getbundle(hex(unknownbinhead))
				if bundleid is None:
				raise error.Abort(b'%s head is not known' % hex(unknownbinhead))
				bundleraw = store.read(bundleid)
				return _makebundlefromraw(bundleraw)


				def _makebundlefromraw(data):
				fp = None
				fd, bundlefile = pycompat.mkstemp()
				try: # guards bundlefile
				try: # guards fp
				fp = os.fdopen(fd, 'wb')
				fp.write(data)
				finally:
				fp.close()
				except Exception:
				try:
				os.unlink(bundlefile)
				except Exception:
				# we would rather see the original exception
				pass
				raise

				return bundlefile