upstream/mercurial-mirror Files · hgext/hooklib/enforce_draft_commits.py

logtoprocess: avoid traceback when running long commands...

logtoprocess: avoid traceback when running long commands $ hg log -r "present($(yes | tr -d '\n' | head -c 130000))" "$(yes | tr -d '\n' | head -c 5000)" --config extensions.logtoprocess= --config logtoprocess.commandfinish=whatever Traceback (most recent call last): File "/usr/bin/hg", line 67, in <module> dispatch.run() File "/usr/lib64/python2.7/site-packages/mercurial/dispatch.py", line 111, in run status = dispatch(req) File "/usr/lib64/python2.7/site-packages/mercurial/dispatch.py", line 290, in dispatch canonical_command=req.canonical_command, File "/usr/lib64/python2.7/site-packages/mercurial/ui.py", line 1991, in log logger.log(self, event, msg, opts) File "/usr/lib64/python2.7/site-packages/hgext/logtoprocess.py", line 72, in log procutil.runbgcommand(script, fullenv, shell=True) File "/usr/lib64/python2.7/site-packages/mercurial/utils/procutil.py", line 597, in runbgcommand b'error running %r: %s' % (cmd, os.strerror(returncode)), OSError: [Errno 7] error running 'whatever': Argument list too long This can happen if you pass a bunch of filenames to hg commit, for instance. This is due to a size limit on individual env vars (on linux, but I imagine there are similar limits in other OSes): $ FOO=$(yes | head -c 131000) /usr/bin/true $ FOO=$(yes | head -c 132000) /usr/bin/true -bash: /usr/bin/true: Argument list too long I propose to avoid this by truncating the message. I didn't make the limit configurable as it doesn't seem particularly convenient to customize this. I'm not sure if various OSes would want radically different limits here? Differential Revision: https://phab.mercurial-scm.org/D8203

Joerg Sonnenberger - - Load All Authors

File last commit:

r44897:4cabeea6 default


                r44900:69392460

default

Download file

             enforce_draft_commits.py
        
                    45 lines
            
             | 1.4 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / hooklib / enforce_draft_commits.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Copyright 2020 Joerg Sonnenberger <joerg@bec.de>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      """enforce_draft_commits us a hook to ensure that all new changesets are

      in the draft phase. This allows enforcing policies for work-in-progress

      changes in overlay repositories, i.e. a shared hidden repositories with

      different views for work-in-progress code and public history.

      Usage:

        [hooks]

        pretxnclose-phase.enforce_draft_commits = \

          python:hgext.hooklib.enforce_draft_commits.hook

      """

      from __future__ import absolute_import

      from mercurial.i18n import _

      from mercurial import (

          error,

          pycompat,

      )

      def hook(ui, repo, hooktype, node=None, **kwargs):

          if hooktype != b"pretxnclose-phase":

              raise error.Abort(

                  _(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)

              )

          ctx = repo.unfiltered()[node]

          if kwargs['oldphase']:

              raise error.Abort(

                  _(b'Phase change from %r to %r for %s rejected')

                  % (

                      pycompat.bytestr(kwargs['oldphase']),

                      pycompat.bytestr(kwargs['phase']),

                      ctx,

                  )

              )

          elif kwargs['phase'] != b'draft':

              raise error.Abort(

                  _(b'New changeset %s in phase %r rejected')

                  % (ctx, pycompat.bytestr(kwargs['phase']))

              )

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Copyright 2020 Joerg Sonnenberger <joerg@bec.de>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				"""enforce_draft_commits us a hook to ensure that all new changesets are
				in the draft phase. This allows enforcing policies for work-in-progress
				changes in overlay repositories, i.e. a shared hidden repositories with
				different views for work-in-progress code and public history.

				Usage:
				[hooks]
				pretxnclose-phase.enforce_draft_commits = \
				python:hgext.hooklib.enforce_draft_commits.hook
				"""

				from __future__ import absolute_import

				from mercurial.i18n import _
				from mercurial import (
				error,
				pycompat,
				)


				def hook(ui, repo, hooktype, node=None, **kwargs):
				if hooktype != b"pretxnclose-phase":
				raise error.Abort(
				_(b'Unsupported hook type %r') % pycompat.bytestr(hooktype)
				)
				ctx = repo.unfiltered()[node]
				if kwargs['oldphase']:
				raise error.Abort(
				_(b'Phase change from %r to %r for %s rejected')
				% (
				pycompat.bytestr(kwargs['oldphase']),
				pycompat.bytestr(kwargs['phase']),
				ctx,
				)
				)
				elif kwargs['phase'] != b'draft':
				raise error.Abort(
				_(b'New changeset %s in phase %r rejected')
				% (ctx, pycompat.bytestr(kwargs['phase']))
				)