upstream/mercurial-mirror Files · rust/hg-cpython/src/exceptions.rs

logtoprocess: avoid traceback when running long commands...

logtoprocess: avoid traceback when running long commands $ hg log -r "present($(yes | tr -d '\n' | head -c 130000))" "$(yes | tr -d '\n' | head -c 5000)" --config extensions.logtoprocess= --config logtoprocess.commandfinish=whatever Traceback (most recent call last): File "/usr/bin/hg", line 67, in <module> dispatch.run() File "/usr/lib64/python2.7/site-packages/mercurial/dispatch.py", line 111, in run status = dispatch(req) File "/usr/lib64/python2.7/site-packages/mercurial/dispatch.py", line 290, in dispatch canonical_command=req.canonical_command, File "/usr/lib64/python2.7/site-packages/mercurial/ui.py", line 1991, in log logger.log(self, event, msg, opts) File "/usr/lib64/python2.7/site-packages/hgext/logtoprocess.py", line 72, in log procutil.runbgcommand(script, fullenv, shell=True) File "/usr/lib64/python2.7/site-packages/mercurial/utils/procutil.py", line 597, in runbgcommand b'error running %r: %s' % (cmd, os.strerror(returncode)), OSError: [Errno 7] error running 'whatever': Argument list too long This can happen if you pass a bunch of filenames to hg commit, for instance. This is due to a size limit on individual env vars (on linux, but I imagine there are similar limits in other OSes): $ FOO=$(yes | head -c 131000) /usr/bin/true $ FOO=$(yes | head -c 132000) /usr/bin/true -bash: /usr/bin/true: Argument list too long I propose to avoid this by truncating the message. I didn't make the limit configurable as it doesn't seem particularly convenient to customize this. I'm not sure if various OSes would want radically different limits here? Differential Revision: https://phab.mercurial-scm.org/D8203

Yuya Nishihara - - Load All Authors

File last commit:

r44667:b556400b default


                r44900:69392460

default

Download file

             exceptions.rs
        
                    42 lines
            
             | 1.3 KiB
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-cpython / src / exceptions.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      // ancestors.rs

      //

      // Copyright 2018 Georges Racinet <gracinet@anybox.fr>

      //

      // This software may be used and distributed according to the terms of the

      // GNU General Public License version 2 or any later version.

      //! Bindings for Rust errors

      //!

      //! [`GraphError`] exposes `hg::GraphError` as a subclass of `ValueError`

      //! but some variants of `hg::GraphError` can be converted directly to other

      //! existing Python exceptions if appropriate.

      //!

      //! [`GraphError`]: struct.GraphError.html

      use cpython::{

          exc::{RuntimeError, ValueError},

          py_exception, PyErr, Python,

      };

      use hg;

      py_exception!(rustext, GraphError, ValueError);

      impl GraphError {

          pub fn pynew(py: Python, inner: hg::GraphError) -> PyErr {

              match inner {

                  hg::GraphError::ParentOutOfRange(r) => {

                      GraphError::new(py, ("ParentOutOfRange", r))

                  }

                  hg::GraphError::WorkingDirectoryUnsupported => {

                      match py

                          .import("mercurial.error")

                          .and_then(|m| m.get(py, "WdirUnsupported"))

                      {

                          Err(e) => e,

                          Ok(cls) => PyErr::from_instance(py, cls),

                      }

                  }

              }

          }

      }

      py_exception!(rustext, HgPathPyError, RuntimeError);

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				// ancestors.rs
				//
				// Copyright 2018 Georges Racinet <gracinet@anybox.fr>
				//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

				//! Bindings for Rust errors
				//!
				//! [`GraphError`] exposes `hg::GraphError` as a subclass of `ValueError`
				//! but some variants of `hg::GraphError` can be converted directly to other
				//! existing Python exceptions if appropriate.
				//!
				//! [`GraphError`]: struct.GraphError.html
				use cpython::{
				exc::{RuntimeError, ValueError},
				py_exception, PyErr, Python,
				};
				use hg;

				py_exception!(rustext, GraphError, ValueError);

				impl GraphError {
				pub fn pynew(py: Python, inner: hg::GraphError) -> PyErr {
				match inner {
				hg::GraphError::ParentOutOfRange(r) => {
				GraphError::new(py, ("ParentOutOfRange", r))
				}
				hg::GraphError::WorkingDirectoryUnsupported => {
				match py
				.import("mercurial.error")
				.and_then(\|m\| m.get(py, "WdirUnsupported"))
				{
				Err(e) => e,
				Ok(cls) => PyErr::from_instance(py, cls),
				}
				}
				}
				}
				}

				py_exception!(rustext, HgPathPyError, RuntimeError);