upstream/mercurial-mirror Files · mercurial/dirstateguard.py

changegroup: don't fail on empty changegroup (API)...

changegroup: don't fail on empty changegroup (API) I don't know why applying an empty changegroup should be an error. It seems harmless. I suspect the check was there to find code that creates empty changegroups just because that would be wasteful. Let's use develwarn() for that instead, so we catch any such cases that run with our test runner, but we still allow others to generate empty changegroups if they want to. We have run into this check at Google once or twice and had to work around it, but I'm changing this not so much because of that, but because it seems like it shouldn't be an error. I also changed the message slightly to be more modern ("changelog group" -> "changegroup") and more generic ("received" -> "applied").

Augie Fackler - - Load All Authors

File last commit:

r30488:751639bf default


                r33309:69c4493a

default

Download file

             dirstateguard.py
        
                    69 lines
            
             | 2.2 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / dirstateguard.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # dirstateguard.py - class to allow restoring dirstate after failure

      #

      # Copyright 2005-2007 Matt Mackall <mpm@selenic.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      from .i18n import _

      from . import (

          error,

      )

      class dirstateguard(object):

          '''Restore dirstate at unexpected failure.

          At the construction, this class does:

          - write current ``repo.dirstate`` out, and

          - save ``.hg/dirstate`` into the backup file

          This restores ``.hg/dirstate`` from backup file, if ``release()``

          is invoked before ``close()``.

          This just removes the backup file at ``close()`` before ``release()``.

          '''

          def __init__(self, repo, name):

              self._repo = repo

              self._active = False

              self._closed = False

              self._suffix = '.backup.%s.%d' % (name, id(self))

              repo.dirstate.savebackup(repo.currenttransaction(), self._suffix)

              self._active = True

          def __del__(self):

              if self._active: # still active

                  # this may occur, even if this class is used correctly:

                  # for example, releasing other resources like transaction

                  # may raise exception before ``dirstateguard.release`` in

                  # ``release(tr, ....)``.

                  self._abort()

          def close(self):

              if not self._active: # already inactivated

                  msg = (_("can't close already inactivated backup: dirstate%s")

                         % self._suffix)

                  raise error.Abort(msg)

              self._repo.dirstate.clearbackup(self._repo.currenttransaction(),

                                               self._suffix)

              self._active = False

              self._closed = True

          def _abort(self):

              self._repo.dirstate.restorebackup(self._repo.currenttransaction(),

                                                 self._suffix)

              self._active = False

          def release(self):

              if not self._closed:

                  if not self._active: # already inactivated

                      msg = (_("can't release already inactivated backup:"

                               " dirstate%s")

                             % self._suffix)

                      raise error.Abort(msg)

                  self._abort()

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# dirstateguard.py - class to allow restoring dirstate after failure
				#
				# Copyright 2005-2007 Matt Mackall <mpm@selenic.com>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import absolute_import

				from .i18n import _

				from . import (
				error,
				)

				class dirstateguard(object):
				'''Restore dirstate at unexpected failure.

				At the construction, this class does:

				- write current ``repo.dirstate`` out, and
				- save ``.hg/dirstate`` into the backup file

				This restores ``.hg/dirstate`` from backup file, if ``release()``
				is invoked before ``close()``.

				This just removes the backup file at ``close()`` before ``release()``.
				'''

				def __init__(self, repo, name):
				self._repo = repo
				self._active = False
				self._closed = False
				self._suffix = '.backup.%s.%d' % (name, id(self))
				repo.dirstate.savebackup(repo.currenttransaction(), self._suffix)
				self._active = True

				def __del__(self):
				if self._active: # still active
				# this may occur, even if this class is used correctly:
				# for example, releasing other resources like transaction
				# may raise exception before ``dirstateguard.release`` in
				# ``release(tr, ....)``.
				self._abort()

				def close(self):
				if not self._active: # already inactivated
				msg = (_("can't close already inactivated backup: dirstate%s")
				% self._suffix)
				raise error.Abort(msg)

				self._repo.dirstate.clearbackup(self._repo.currenttransaction(),
				self._suffix)
				self._active = False
				self._closed = True

				def _abort(self):
				self._repo.dirstate.restorebackup(self._repo.currenttransaction(),
				self._suffix)
				self._active = False

				def release(self):
				if not self._closed:
				if not self._active: # already inactivated
				msg = (_("can't release already inactivated backup:"
				" dirstate%s")
				% self._suffix)
				raise error.Abort(msg)
				self._abort()