upstream/mercurial-mirror Files · tests/test-issue672.t

copies: make mergecopies() distinguish between copies on each side...

copies: make mergecopies() distinguish between copies on each side I find it confusing that most of the dicts returned from `mergecopies()` have entries specific to one branch of the merge, but they're still combined into dict. For example, you can't tell if `copy = {"bar": "foo"}` means that "foo" was copied to "bar" on the first branch or the second. It also feels like there are bugs lurking here because we may mistake which side the copy happened on. However, for most of the dicts, it's not possible that there is disagreement. For example, `renamedelete` keeps track of renames that happened on one side of the merge where the other side deleted the file. There can't be a disagreement there (because we record that in the `diverge` dict instead). For regular copies/renames, there can be a disagreement. Let's say file "foo" was copied to "bar" on one branch and file "baz" was copied to "bar" on the other. Beacause we only return one `copy` dict, we end up replacing the `{"bar": "foo"}` entry by `{"bar": "baz"}`. The merge code (`manifestmerge()`) will then decide that that means "both renamed from 'baz'". We should probably treat it as a conflict instead. The next few patches will make `mergecopies()` return two instances of most of the returned copies. That will lead to a bit more code (~40 lines), but I think it makes both `copies.mergecopies()` and `merge.manifestmerge()` clearer. Differential Revision: https://phab.mercurial-scm.org/D7986

Valentin Gatien-Baron - - Load All Authors

File last commit:

r42827:b928b229 default


                r44657:6ca9f45b

default

Download file

             test-issue672.t
        
                    96 lines
            
             | 2.8 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-issue672.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      https://bz.mercurial-scm.org/672

      # 0-2-4

      #  \ \ \

      #   1-3-5

      #

      # rename in #1, content change in #4.

        $ hg init

        $ touch 1

        $ touch 2

        $ hg commit -Am init  # 0

        adding 1

        adding 2

        $ hg rename 1 1a

        $ hg commit -m rename # 1

        $ hg co -C 0

        1 files updated, 0 files merged, 1 files removed, 0 files unresolved

        $ echo unrelated >> 2

        $ hg ci -m unrelated1 # 2

        created new head

        $ hg merge --debug 1

          unmatched files in other:

           1a

          all copies found (* = to merge, ! = divergent, % = renamed and deleted):

           src: '1' -> dst: '1a' 

          checking for directory renames

        resolving manifests

         branchmerge: True, force: False, partial: False

         ancestor: 81f4b099af3d, local: c64f439569a9+, remote: c12dcd37c90a

         1: other deleted -> r

        removing 1

         1a: remote created -> g

        getting 1a

        1 files updated, 0 files merged, 1 files removed, 0 files unresolved

        (branch merge, don't forget to commit)

        $ hg ci -m merge1 # 3

        $ hg co -C 2

        1 files updated, 0 files merged, 1 files removed, 0 files unresolved

        $ echo hello >> 1

        $ hg ci -m unrelated2 # 4

        created new head

        $ hg co -C 3

        1 files updated, 0 files merged, 1 files removed, 0 files unresolved

        $ hg merge -y --debug 4

          unmatched files in local:

           1a

          all copies found (* = to merge, ! = divergent, % = renamed and deleted):

           src: '1' -> dst: '1a' *

          checking for directory renames

        resolving manifests

         branchmerge: True, force: False, partial: False

         ancestor: c64f439569a9, local: f4a9cff3cd0b+, remote: 746e9549ea96

         preserving 1a for resolve of 1a

        starting 4 threads for background file closing (?)

         1a: local copied/moved from 1 -> m (premerge)

        picked tool ':merge' for 1a (binary False symlink False changedelete False)

        merging 1a and 1 to 1a

        my 1a@f4a9cff3cd0b+ other 1@746e9549ea96 ancestor 1@c64f439569a9

         premerge successful

        0 files updated, 1 files merged, 0 files removed, 0 files unresolved

        (branch merge, don't forget to commit)

        $ hg co -C 4

        1 files updated, 0 files merged, 1 files removed, 0 files unresolved

        $ hg merge -y --debug 3

          unmatched files in other:

           1a

          all copies found (* = to merge, ! = divergent, % = renamed and deleted):

           src: '1' -> dst: '1a' *

          checking for directory renames

        resolving manifests

         branchmerge: True, force: False, partial: False

         ancestor: c64f439569a9, local: 746e9549ea96+, remote: f4a9cff3cd0b

         preserving 1 for resolve of 1a

        removing 1

        starting 4 threads for background file closing (?)

         1a: remote moved from 1 -> m (premerge)

        picked tool ':merge' for 1a (binary False symlink False changedelete False)

        merging 1 and 1a to 1a

        my 1a@746e9549ea96+ other 1a@f4a9cff3cd0b ancestor 1@c64f439569a9

         premerge successful

        0 files updated, 1 files merged, 0 files removed, 0 files unresolved

        (branch merge, don't forget to commit)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				https://bz.mercurial-scm.org/672

				# 0-2-4
				# \ \ \
				# 1-3-5
				#
				# rename in #1, content change in #4.

				$ hg init

				$ touch 1
				$ touch 2
				$ hg commit -Am init # 0
				adding 1
				adding 2

				$ hg rename 1 1a
				$ hg commit -m rename # 1

				$ hg co -C 0
				1 files updated, 0 files merged, 1 files removed, 0 files unresolved

				$ echo unrelated >> 2
				$ hg ci -m unrelated1 # 2
				created new head

				$ hg merge --debug 1
				unmatched files in other:
				1a
				all copies found (* = to merge, ! = divergent, % = renamed and deleted):
				src: '1' -> dst: '1a'
				checking for directory renames
				resolving manifests
				branchmerge: True, force: False, partial: False
				ancestor: 81f4b099af3d, local: c64f439569a9+, remote: c12dcd37c90a
				1: other deleted -> r
				removing 1
				1a: remote created -> g
				getting 1a
				1 files updated, 0 files merged, 1 files removed, 0 files unresolved
				(branch merge, don't forget to commit)

				$ hg ci -m merge1 # 3

				$ hg co -C 2
				1 files updated, 0 files merged, 1 files removed, 0 files unresolved

				$ echo hello >> 1
				$ hg ci -m unrelated2 # 4
				created new head

				$ hg co -C 3
				1 files updated, 0 files merged, 1 files removed, 0 files unresolved

				$ hg merge -y --debug 4
				unmatched files in local:
				1a
				all copies found (* = to merge, ! = divergent, % = renamed and deleted):
				src: '1' -> dst: '1a' *
				checking for directory renames
				resolving manifests
				branchmerge: True, force: False, partial: False
				ancestor: c64f439569a9, local: f4a9cff3cd0b+, remote: 746e9549ea96
				preserving 1a for resolve of 1a
				starting 4 threads for background file closing (?)
				1a: local copied/moved from 1 -> m (premerge)
				picked tool ':merge' for 1a (binary False symlink False changedelete False)
				merging 1a and 1 to 1a
				my 1a@f4a9cff3cd0b+ other 1@746e9549ea96 ancestor 1@c64f439569a9
				premerge successful
				0 files updated, 1 files merged, 0 files removed, 0 files unresolved
				(branch merge, don't forget to commit)

				$ hg co -C 4
				1 files updated, 0 files merged, 1 files removed, 0 files unresolved

				$ hg merge -y --debug 3
				unmatched files in other:
				1a
				all copies found (* = to merge, ! = divergent, % = renamed and deleted):
				src: '1' -> dst: '1a' *
				checking for directory renames
				resolving manifests
				branchmerge: True, force: False, partial: False
				ancestor: c64f439569a9, local: 746e9549ea96+, remote: f4a9cff3cd0b
				preserving 1 for resolve of 1a
				removing 1
				starting 4 threads for background file closing (?)
				1a: remote moved from 1 -> m (premerge)
				picked tool ':merge' for 1a (binary False symlink False changedelete False)
				merging 1 and 1a to 1a
				my 1a@746e9549ea96+ other 1a@f4a9cff3cd0b ancestor 1@c64f439569a9
				premerge successful
				0 files updated, 1 files merged, 0 files removed, 0 files unresolved
				(branch merge, don't forget to commit)